Before applying the patch, I get this output:
FILE: /var/www/html/repos/video_embed_twitter/src/Plugin/video_embed_field/Provider/Twitter.php
-----------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------
7 | ERROR | Missing short description in doc comment
-----------------------------------------------------------------------------------------------
FILE: /var/www/html/repos/video_embed_twitter/tests/src/Unit/ProviderUrlParseTest.php
-------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------
15 | ERROR | Missing short description in doc comment
-------------------------------------------------------------------------------------FILE: /var/www/html/repos/video_embed_twitter/video_embed_twitter.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
But the patch provided by @Harsh Panchal worked well for me. Tested with Gitpod on Drupal version 9.5.11- Status changed to Needs work
over 1 year ago 9:09am 28 December 2023 - šµšPhilippines clarkssquared
Hi
I applied patch #2 and I confirmed that it fixes the PHPCS errors, but I will transition this to needs work because there is 1 file in the patch that was rejected and failed to apply.
ā video_embed_twitter git:(master) ā curl https://www.drupal.org/files/issues/2022-07-09/phpcs-drupal-standard-3295104-2.patch | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 1404 100 1404 0 0 3031 0 --:--:-- --:--:-- --:--:-- 3072 patching file 'src/Plugin/video_embed_field/Provider/Twitter.php' patching file 'tests/src/Unit/ProviderUrlParseTest.php' patching file video_embed_twitter.info.yml 1 out of 1 hunks failed--saving rejects to video_embed_twitter.info.yml.rej ā video_embed_twitter git:(master) ā .. ā contrib git:(master) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml video_embed_twitter FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/video_embed_twitter/video_embed_twitter.info.yml ------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically 7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" ------------------------------------------------------------------------------------------------------------------------- Time: 215ms; Memory: 10MB ā contrib git:(master) ā
- Status changed to Needs review
over 1 year ago 3:06pm 28 December 2023 - š®š³India ankithashetty Karnataka, India
PHPCS errors are fixed in MR and ready for review.
The MR has an additional fix :WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
Thanks!
- Issue was unassigned.
- š®š¹Italy apaderno Brescia, š®š¹
I am resetting the Assigned field, since the person to which this issue was assigned has not worked on it in more than seven days. I apologize for bumping this issue.