🇮🇳India @ankithashetty

+1 to a stable relaese.

+1 to this.

+1 to this request.

+1 to this issue.

+1

ankithashetty → created an issue.

+1 to this Issue.

+1 to this issue.
Anu suggestions?

Thanks for the patch @gcb!
Able to see the mappings on UI after the patch.

The only thing is, even if we select one record type to pull from Salesforce, it pulls in all the record types, not just the one I selected.
Any way to handle that?

Thanks again!

MR !4 ready for review.

Thanks!

ankithashetty → created an issue.

Thanks @lucashedding, addressed #11 MR comments.
Please review.

+1 to this error.

I am seeing this error during the D9 to D10 upgrade while trying to visit /update.php (no access to drush commands as the site is using Cpanel)
No help from #2998372: issue after updating from RC18 to RC21 →

Thanks!

PHPCS errors are fixed in MR and ready for review.
The MR has an additional fix : WARNING | All dependencies must be prefixed with the project name, for example "drupal:"

Thanks!

Yes, @droplet.
As shared above, to make the module D10 compatible, we generally check the results from the upgrade status ( https://www.drupal.org/project/upgrade_status → )

Error reported:

web/modules/contrib/toolbar_anti_flicker/toolbar_anti_flicker.module	125	Call to deprecated function drupal_get_path(). Deprecated in drupal:9.3.0 and is removed from drupal:10.0.0. Use Drupal\Core\Extension\ExtensionPathResolver::getPath() instead.

web/modules/contrib/toolbar_anti_flicker/toolbar_anti_flicker.libraries.yml	0	The 'toolbar-anti-flicker' library is depending on a deprecated library. The core/jquery.cookie asset library is deprecated in Drupal 9.0.0 and will be removed in Drupal 10.0.0. Use the core/js-cookie library instead. See https://www.drupal.org/node/3104677

web/modules/contrib/toolbar_anti_flicker/toolbar_anti_flicker.info.yml	0	Value of core_version_requirement: ^9 is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687.

Here,

1. we replaced the deprecated function drupal_get_path() with \Drupal::service('extension.list.module')->getPath('toolbar_anti_flicker')
2. core/jquery.cookie asset library is removed in Drupal 10.0.0. Now, to make it work with core D10, we must replace it with core/js-cookie library
3. Updated core_version_requirement key to support D10
4. Added a composer.json file to include D10 compatibility. (Please note: IF this file is not needed, we can remove it from MR. The above changes seems necessary. Please suggest, will make relevant changes.)

Thank you!

Raised an MR with D10 compatibility fixes.

Resolved the below errors reported by upgrade status:

web/modules/contrib/toolbar_anti_flicker/toolbar_anti_flicker.module	125	Call to deprecated function drupal_get_path(). Deprecated in drupal:9.3.0 and is removed from drupal:10.0.0. Use Drupal\Core\Extension\ExtensionPathResolver::getPath() instead.

web/modules/contrib/toolbar_anti_flicker/toolbar_anti_flicker.libraries.yml	0	The 'toolbar-anti-flicker' library is depending on a deprecated library. The core/jquery.cookie asset library is deprecated in Drupal 9.0.0 and will be removed in Drupal 10.0.0. Use the core/js-cookie library instead. See https://www.drupal.org/node/3104677

web/modules/contrib/toolbar_anti_flicker/toolbar_anti_flicker.info.yml	0	Value of core_version_requirement: ^9 is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687.

Thanks!

ankithashetty → made their first commit to this issue’s fork.

Addressed comments from #7, thanks!

ankithashetty → made their first commit to this issue’s fork.

Rerolled the MR, thanks!

ankithashetty → made their first commit to this issue’s fork.

Rerolled the patch in #2 as MR ✨ Create helper method for getting order type in cart adder Needs review . Please review, thanks!

ankithashetty → made their first commit to this issue’s fork.

Rerolled the patch in #6 as an MR against 2.x, thanks!

ankithashetty → made their first commit to this issue’s fork.

+1 to this issue.
For now tried the #4 suggestion as a workaround.

+1 to this request.

Sure, thanks for that @VladimirAus! 🙂

Addressed the above feedback and rebased MR. Thanks!

ankithashetty → made their first commit to this issue’s fork.

Alright, @VladimirAus!
One quick question though. if we buy this premium version, how can we incorporate it with this module to get it working on CKeditor 5? Any upgrade path needed?

+1 to this!

+1 to this request!
Would love this to have CKeditor 5 compatibility.

Updated MR with #9 suggestion.
Thanks!

MR is rebased and updated with #6 changes.

Noticed the below error:

/key_auth/src/KeyAuth.php
---------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------
 5 | WARNING | [x] Unused use statement
 5 | ERROR   | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements

Looks like it was added in 🐛 Key Auth authenticator should query for users without access check Fixed . Was it deliberately added or can we clean it?

Thanks!

ankithashetty → made their first commit to this issue’s fork.

ankithashetty → made their first commit to this issue’s fork.

MR updated with relevant changes. Ready for review now.

Just a thought on #8 comment: Noyiced the lines $_POST['g-recaptcha-response'] and \Drupal::request()->getClientIp() were added in different commits, may be that's why there is a difference? Am not 100% sure here, maintiner can confirm.

Thanks!

ankithashetty → made their first commit to this issue’s fork.

MR is created with the necessary details. This might need some additional input from the maintainers/community :)

Thanks!

On it.

ankithashetty → made their first commit to this issue’s fork.

+1 to RTBC. The changes look good to me.

Steps followed for testing:

• Enable the module.
• Navigate to page /admin/structure/types/manage/{content-type} , look for Flippy settings
• Enable the option Build a pager for this content type
• Look for the description under the fields like Label for Previous, Next, first and last link.

Before MR:

After MR:

Thanks!

ankithashetty → made their first commit to this issue’s fork.

Opened an MR for the changes made in #47, thanks!

ankithashetty → made their first commit to this issue’s fork.

Updated the MR with relevant functions doc comments. Retaining 'needs work' for tests and CR.

Thanks!

ankithashetty → made their first commit to this issue’s fork.

MR updated with relevant changes, thanks!

ankithashetty → made their first commit to this issue’s fork.

Added a 'use' statement for referencing the namespaced interface + rebased MR. Thanks!

ankithashetty → made their first commit to this issue’s fork.

Patch in #3 still gets applied on 10.1, 10.2 and 11.x.

ankithashetty → made their first commit to this issue’s fork.

ankithashetty → made their first commit to this issue’s fork.

Looks like all the required changes already exist in 8.x-1.x branch https://git.drupalcode.org/project/tasty_backend. So we don't need a patch.

The only thing we can request from the maintainer is for a stable release of the module for D10 on the module page. 🙂

I believe we are good to close this issue.
Thanks!

Will check on this.

Updated version to 10.2.0.
Thanks!

ankithashetty → made their first commit to this issue’s fork.

Uploading a patch with regards to pending changes from #11.

We can use the existing issue 📌 [11.x] Adjust parameters in interfaces Active to update the interfaces in 11.x.

Thanks!

Thanks again @kostyashupenko!

+1 to RTBC

Steps to reproduce (shared in IS)
1- Create an entity reference field on a content type.
2- Choose 2 items or more on the "number of values" setting.
3- Visit the form page and open it at 712px width, open the main navigation.

Tested:
case #1. The fix works when we have a single autocomplete field.
case #2.Also works when we add another item.

Thanks!

Addressed #10 and #11, thanks!

Thanks for the update!

Tested again with the same steps, here are my observations:
* After applying the latest change, disabled aggregation and cleared cache (multiple times)

case #1. The fix works when we have a single autocomplete field

case #2. If we add another term/item, then we still see the scrolling issue. (Fix in #3 worked in both the scenarios)

Need to check on case 2.
Thanks!

In MR !3775 (against 10.1.x), if the change is not as expected, we can just revert the latest commit.

Thanks! 🙂 Was just thinking about working on #14 suggestions.

Can we create a new MR for 11.x instead of changing the target branch in the existing MR?

Hello @longwave, noticed in #3238192: Allow omitting @var for strictly typed class properties → that we can omit @var only for strictly typed class properties.
If we look at the Proposed resolution → section, it says "This type can not be represented in the PHP typesystem yet." to variables like @var int|string|NULL

class Foo {
  /**
    * Where one can order a soda.
    */
  protected Bar $baz;

  /**
    * Some complex type that probably needs cleaning up in a future.
    * 
    * This type can not be represented in the PHP typesystem yet.
    *
    * @var int|string|NULL
    */
   public $someVar;
}

So can we really remove @var here:

• https://git.drupalcode.org/project/drupal/-/merge_requests/3775/diffs#59...
• https://git.drupalcode.org/project/drupal/-/merge_requests/3775/diffs#c6...
• And many more instances in this MR...

Update:
The test results shared in #8 are w.r.t to MR in #3. => Works as per expectation.

Tried the #7 MR, but it didn't fix the scroll issue for me.

Changing back to 'Needs work' status.
@kostyashupenko Could you please check again? Hope you have opened the main navigation during the fix while testing.
Thanks!

+ RTBC.
Tested the MR and it fixed the reported issue. Also IS updated with required SS.

Followed the same steps shared in IS to test it.

After applying the MR:

Rabsed the MR, it's ready for review now.
Thanks!

ankithashetty → made their first commit to this issue’s fork.

MR is ready for 11.x, thanks!

ankithashetty → made their first commit to this issue’s fork.

While reviewing noticed the following phpcs errors:

FILE: /nature_blog/README.md
----------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
----------------------------------------------------------------------------------------
  3 | WARNING | Line exceeds 80 characters; contains 84 characters
  4 | WARNING | Line exceeds 80 characters; contains 89 characters
  5 | WARNING | Line exceeds 80 characters; contains 89 characters
 46 | WARNING | Line exceeds 80 characters; contains 87 characters
 52 | WARNING | Line exceeds 80 characters; contains 95 characters
----------------------------------------------------------------------------------------

Addressed them in the latest commit. Thanks!

ankithashetty → made their first commit to this issue’s fork.

Addressed the request made in #5.
Capitalized the references of the module names (the current module monolog_extra → and also its dependent module monolog → ). Please review.
Thanks!

ankithashetty → made their first commit to this issue’s fork.

Fixed the existing MR as the tests had failed, thanks!

ankithashetty → made their first commit to this issue’s fork.

Updated MR and used DI to use logger service, thanks!

ankithashetty → made their first commit to this issue’s fork.

MR updated with the required changes, thanks!

ankithashetty → made their first commit to this issue’s fork.

Cherry-picked the commits from the previous MR !2112 and raised a new MR !2116 for 5.x.
(Assuming that was the ask made in #8)

Thanks!

ankithashetty → made their first commit to this issue’s fork.

Rebased the existing MR with the expected changes, hope this helps to proceed.
(Please note: My apologies, I kind of missed checking that the issue was already assigned to someone else 🙌🏼)

Thanks!

ankithashetty → made their first commit to this issue’s fork.

Updating MR with changes requested in #13. Thanks!

ankithashetty → made their first commit to this issue’s fork.

Rebased the MR and updated the description as suggested in #22, thanks!

ankithashetty → made their first commit to this issue’s fork.

Resolved conflicts and rebased the MR.
Thanks!

ankithashetty → made their first commit to this issue’s fork.

Raised an MR for the changes in #31, thanks!

ankithashetty → made their first commit to this issue’s fork.