- Issue created by @yogesh_ghatode
- First commit to issue fork.
- Merge request !15Issue #3391606: README.txt has no content and replace README.txt with README.md โ (Open) created by sandipta
- ๐ต๐ญPhilippines kenyoOwen
Hi sandipta
I reviewed your MR!15 but it doesn't follow the README.md template โ . These are the sections that Drupal recommends:
Project name and introduction (required) Table of contents (optional) Requirements (required) Recommended modules (optional) Installation (required, unless a separate INSTALL.md is provided) Configuration (required) Troubleshooting & FAQ (optional) Maintainers (optional)
Thank you
- Assigned to AditiVB
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 11:37am 10 October 2023 - Status changed to Needs work
about 1 year ago 11:48pm 10 October 2023 - ๐ต๐ญPhilippines kenyoOwen
Hi Aditi Saraf
I reviewed your patch it also not follow README.md template.
- # Nature Blog Drupal Module [remove Drupal Module since it is a theme and not a module]
- ## Table of contents [Missing information in table of contents section]
- ## Configuration [You should explain how enabling/disabling the theme will affect the site]
- ## Maintainer [Wrong format this a example of the format (- Daniel F. Kudwien - [sun]( https://www.drupal.org/u/sun โ ))]Thank you.
- Status changed to Needs review
about 1 year ago 1:17pm 11 October 2023 - ๐ฎ๐ณIndia Nupur Badola
Reviewed the patch, the only issue I found out was the incorrect for of Maintainers
It should be for instance "Peter Wolanin - [pwolanin]( https://www.drupal.org/u/pwolanin โ )", like this.
Sending it to need work. - Status changed to Needs work
about 1 year ago 11:15am 26 October 2023 - Assigned to AditiVB
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 12:10pm 27 October 2023 - Status changed to Needs work
12 months ago 6:56am 30 November 2023 - ๐ต๐ญPhilippines kenyoOwen
Hi Aditi Saraf
Based on comment #11 incorrect format for the "Maintainers" section not on the "Author" section. "Maintaners" section format should be example
## Maintainers - Daniel F. Kudwien - [sun](https://www.drupal.org/u/sun) - Peter Wolanin - [pwolanin](https://www.drupal.org/u/pwolanin) - Stefan M. Kudwien - [smk-ka](https://www.drupal.org/u/smk-ka) - Dave Reid - [Dave Reid](https://www.drupal.org/u/dave-reid)
Thank you
- ๐ฎ๐ณIndia Anjali Mehta
Anjali Mehta โ made their first commit to this issueโs fork.
- Status changed to Needs review
12 months ago 6:28am 1 December 2023 - ๐ฎ๐ณIndia Nupur Badola
Reviewed MR!15, the name of the maintainers are still missing.
[Jitendra Verma](drupal.org/u/jitendra-verma) - [Asheesh kumar Pal](drupal.org/u/asheesh-kumar-pal) - Kritika Gautam - [Kritika_21](drupal.org/u/kritika_21)
- Status changed to Needs work
12 months ago 6:41am 1 December 2023 - Status changed to Needs review
12 months ago 7:02am 1 December 2023 - ๐ฎ๐ณIndia Anjali Mehta
The maintainers does not show their full name on their user profile. It is not possible to show it.
- Status changed to Needs work
12 months ago 4:11am 4 December 2023 - ๐ต๐ญPhilippines kenyoOwen
Hi Anjali Mehta
I reviewed and confirmed that the maintainer is correct. But the title is still module
# Nature Blog Drupal Module
while this project is theme. It also has module text in the introductionThe Nature Blog module is designed to enhance your Drupal website with a feature-rich blogging platform focused on nature and environmental topics.
Thank you.
- Status changed to Needs review
12 months ago 6:15am 4 December 2023 - First commit to issue fork.
- ๐ฎ๐ณIndia ankithashetty Karnataka, India
While reviewing noticed the following phpcs errors:
FILE: /nature_blog/README.md ---------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES ---------------------------------------------------------------------------------------- 3 | WARNING | Line exceeds 80 characters; contains 84 characters 4 | WARNING | Line exceeds 80 characters; contains 89 characters 5 | WARNING | Line exceeds 80 characters; contains 89 characters 46 | WARNING | Line exceeds 80 characters; contains 87 characters 52 | WARNING | Line exceeds 80 characters; contains 95 characters ----------------------------------------------------------------------------------------
Addressed them in the latest commit. Thanks!
- Status changed to RTBC
12 months ago 1:43am 5 December 2023 - ๐ต๐ญPhilippines kenyoOwen
Hi ankithashetty
I reviewed the new changes and confirmed it fixed the remaining issues and it follows the README.md template.
Thank you