- Issue created by @arx-e
- Status changed to Needs review
over 1 year ago 10:03pm 20 April 2023 - Status changed to RTBC
over 1 year ago 6:34am 21 April 2023 - 🇮🇳India keshavv India
Reviewed the code of #2 patch and tested the patch locally. it is working perfect.
Moving to RTBC. - 🇬🇧United Kingdom stevewilson
I'm seeing a further PHP8.1 deprecation in views_pdf_template.php:
Deprecated function: Automatic conversion of false to array is deprecated in PdfTemplate->addPage() (line 988 of /var/www/html/d7-dev.localhost/sites/all/modules/views_pdf/views_pdf_template.php).
Should we address that one here also, or shall I create a separate issue?
- 🇸🇪Sweden killua99
@stevewilson could you please add it in here, really appreciate it.
Can try to build a new tag this week with several PHP related issues and fixes.
- Status changed to Needs work
12 months ago 9:51pm 25 November 2023 - 🇬🇧United Kingdom stevewilson
@killua99 - I've added this new deprecation to the Issue summary - I hope that's what you wanted.
If you need any further information please let me know.
Changed Status to "Needs work" as the existing patch doesn't cover this latest deprecation and I don't feel confident to provide a fix for it. - First commit to issue fork.
- Merge request !5Issue #3355499: Fix PHP8 deprecated function warnings. → (Open) created by ankithashetty
- Issue was unassigned.
- Status changed to Needs review
12 months ago 7:58am 27 November 2023 - 🇮🇳India ankithashetty Karnataka, India
- Status changed to RTBC
12 months ago 3:05pm 27 November 2023 - 🇬🇧United Kingdom stevewilson
Thank you @ankithashetty. I've manually incorporated your MR !5 changes into my test site and I'm no longer seeing the deprecation reported at comment #5 🐛 PHP8 deprecated function warnings Needs review . Given that the patch at #2 🐛 PHP8 deprecated function warnings Needs review was previously RTBCed for the deprecations reported originally, it seems safe now to set this issue back to RTBC - done.
- 🇬🇧United Kingdom stevewilson
I should perhaps add that I was also seeing PHP8.1 deprecations reported by TCPDF - I was using version 6.3.2. I've since updated to the latest version (6.6.5) and everything seems to be fine now.
- 🇬🇧United Kingdom stevewilson
I've added a further deprecation to the Issue summary - as seen with PHP 8.2.