- last update
about 1 year ago Custom Commands Failed - Status changed to Needs work
about 1 year ago 5:31pm 8 November 2023 - ๐บ๐ธUnited States smustgrave
Thanks for continuing this issue.
Seems to have been tagged for tests and a CR which are still needed.
Thanks!
- ๐ฎ๐ณIndia Akhil Babu Chengannur
Akhil Babu โ made their first commit to this issueโs fork.
- Merge request !5794issues/3201624: Dispatch a MigrateRowFailEvent when a row fails. โ (Open) created by Akhil Babu
- ๐ฎ๐ณIndia Akhil Babu Chengannur
Moved patch #7 to Github. I've also tried to create a test for validating the migration row fail event.
MigrateEventsTest::testMigrateEvents() already uses a simple migration to test existing events$definition = [ 'migration_tags' => ['Event test'], 'source' => [ 'plugin' => 'embedded_data', 'data_rows' => [ ['data' => 'dummy value'], ], 'ids' => [ 'data' => ['type' => 'string'], ], ], 'process' => ['value' => 'data'], 'destination' => ['plugin' => 'dummy'], ];
But I was not able to trigger a 'failed row' with this migration. Instead, I created a new simple node migration. I'm not sure if that's the correct approach or not.
- Status changed to Needs review
about 1 year ago 12:04pm 19 December 2023 - Status changed to Needs work
about 1 year ago 3:57pm 19 December 2023 - First commit to issue fork.
- ๐ฎ๐ณIndia ankithashetty Karnataka, India
Addressed the above feedback and rebased MR. Thanks!
- ๐ฎ๐ณIndia Akhil Babu Chengannur
Thanks @ankithashetty,@smustgrave
Review comments addressed. Moving back to needs review - Status changed to Needs review
about 1 year ago 2:03pm 20 December 2023 - Status changed to Needs work
about 1 year ago 2:30pm 20 December 2023 - ๐ท๐ดRomania bbu23
Thank you for providing a patch for this, it works well for me!