Replace views_add_contextual_links() in views.module with service

I will add the Draft CR once this MR is approved.

Think this could use an IS and title update. Seems to talk about page controller and block tests

Left a question on the MR

Did a quick service for views_add_contextual_links and seems they were all replaced.

Only moving to NW for the change record to announce the deprecation.

CR added.

Thanks!

I'm triaging RTBC issues → . I read the IS, the comments and the CR. Nice to see BC considered and requests for the IS and title to be updated. I didn't find any unanswered questions. And the CR is brief and clear.

It is good to see all the documentation added to the new service. Thanks!

However, many of the comments both the new ones and the ones copied from existing code to the service are not wrapped at 80 columns. And there are some other changes needed for coding standards. I also had trouble following the long sentences is some of the paragraphs so am hoping that can be changed to make it easier for the reader.

Setting to needs work for the comments.

Changes done as suggested.

Left a comment on the one thread.

Believe this is ready.

Resolved conflicts and rebased the MR.
Thanks!

Reroll seems fine.

I'm triaging RTBC issues → . I read the IS and the comments.

I read the MR and left comments. Since there is work to do I am changing the status. For me, the key thing is to improve the docblock for \Drupal\views\ContextualLinks::addLinks. Oh, and to add return types.

Cheers