- Issue created by @codebymikey
- 🇮🇳India SandeepSingh199
@codebymikey, updated parameter type Drupal\Core\Field\BaseFieldDefinition to Drupal\field\Entity\FieldConfig .
- Status changed to Needs review
7 months ago 11:57am 5 December 2023 - last update
7 months ago Custom Commands Failed - Status changed to Needs work
7 months ago 12:24pm 5 December 2023 The Needs Review Queue Bot → tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
- 🇮🇳India sijumpk
Patch #2 is changing FieldDefinitionInterface to FieldConfig, which wont fix the problem. Both BaseFieldDefinition and FieldConfig are implementations of FieldDefinitionInterface. In order to fix the issue, argument type of hook_field_purge_field in field.api.php should be changed to FieldDefinitionInterface.
- 🇮🇳India Akhil Babu Chengannur
Akhil Babu → made their first commit to this issue’s fork.
- Merge request !5692Update hook_field_purge_field documentation to use correct parameter → (Open) created by Akhil Babu
- Status changed to Needs review
7 months ago 12:49pm 5 December 2023 - 🇮🇳India Akhil Babu Chengannur
The hook hook_field_purge_field() is documented with wrong parameter in field.api.php https://api.drupal.org/api/drupal/core%21modules%21field%21field.api.php...
I have updated it - Status changed to Needs work
7 months ago 1:27pm 5 December 2023 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- First commit to issue fork.
- Status changed to Needs review
7 months ago 4:38pm 6 December 2023 - 🇮🇳India ankithashetty Karnataka, India
Added a 'use' statement for referencing the namespaced interface + rebased MR. Thanks!
- Status changed to Needs work
7 months ago 6:54pm 6 December 2023 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇮🇳India Akhil Babu Chengannur
I also noticed that FieldConfig implemets FieldConfigInterface which implements FieldDefinitionInterface. hook_field_purge_field() is invoked with Drupal\field\Entity\FieldConfig $field when deleting a field created from UI or custom field and hook works as expected without any errors. Could you please post detailed steps to reproduce the error?
- Status changed to Postponed: needs info
6 months ago 1:02pm 19 December 2023 - 🇮🇳India Akhil Babu Chengannur
Need proper steps to reproduce. So changing the status to postponed.