Rename RendererInterface::renderPlain() to ::renderInIsolation()

I don't know if that is still relevant but I've switched the patch in #1 to a MR, added back the renderPlain() with some deprecation messages and switched again the code for more calls of this method. Also a draft CR is ready

Seems to have some failures in the MR.

Deprecation can version can be 10.3 and removed in 11.x

Thank you @smustgrave!

I don't know why the test-only job fails, the error is that it cannot find the renderInIsolation() method. And I cannot trigger the other jobs

Also for the spellcheck failure, shall I apply the following change? It capitalizes one letter

    */
-  public function testRenderRecursionWithNestedrenderInIsolation() {
+  public function testRenderRecursionWithNestedRenderInIsolation() {
     [$complex_child_markup, $parent_markup, $complex_child_template] = $this->setUpRenderRecursionComplexElements();

The R should be capitalized, tests aren't running because of the spelling error.

All green now, thanks again @smustgrave

Left a few nitpicks, but believe we should add a test that checks the deprecated message.

All instances were replaced though, did a search for renderPlain()

Test looks good!

It's still under discussion, but given the amount of changes in core and also usages in contrib, and that 11.0 and 10.3 could be released on the same day, and because the bc layer is just the old function calling the new one, this is the kind of deprecation I think we might now want to do for removal in Drupal 12 instead of 11 so that it doesn't block contrib compatibility with Drupal 11.

Moved removal for 12.0.0

Remarking but per slack conversation https://drupal.slack.com/archives/C04CHUX484T/p1702418568197489 this is dependent on what the strategy going forward for 10.3 and 11.x will be.

I applied the diff and searched, $ grep -r renderPlain core, and found some instances in comments that need to be changed. Setting to Needs work for those.

I read the CR and it is short and concise which is fine in this case.

MR is not mergable

Have not re-reviewed yet.

I rebased yesterday but it wasn't enough
I also found more findings

it originally meant "turn this render array into a plain string,

It certainly has confused this old ghost a few times when this method returned HTML instead of plain text.

Strong support for renaming it.

Applied the MR and did a search for renderPlain() and all instances minus deprecation have been replaced.

The title of the issue implies that this is still under discussion. Can someone change the title so it reflects the change being made?

Thanks

Appears to no longer be mergable

dimitriskr → changed the visibility of the branch 11.x to hidden.

Now it's ready again

Rebase appears good.

Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!

Can someone close the MR?

longwave → closed merge request !5766

Automatically closed - issue fixed for 2 weeks with no activity.