Refactor to native JavaScript from jQuery (k8s_cost_block.js)

Issue created by @phyllanthus
Merge request !2112Issue #3404519: Refactor to native JavaScript from jQuery (k8s_cost_block.js) → (Merged) created by Unnamed author
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update 12 months ago
Composer require failure
Status changed to Needs review 12 months ago5:29am 28 November 2023
Comment 12 months ago →
phyllanthus
Comment 12 months ago →
phyllanthus
Comment 12 months ago →
phyllanthus
@yas
Please review the code, thank you.
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update 12 months ago
Composer require failure
Status changed to RTBC 12 months ago11:03pm 29 November 2023
Comment 12 months ago →
🇺🇸United States yas California 🇺🇸
@nakamurarts

Thank you for the refactoring. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update 12 months ago
Composer require failure
Comment 12 months ago →
System Message

yas → committed e8253439 on 6.x authored by nakamurarts →
Issue #3404519 by nakamurarts, yas: Refactor to native JavaScript from...
Status changed to Needs work 12 months ago11:13pm 29 November 2023
Comment 12 months ago →
🇺🇸United States yas California 🇺🇸
@nakamurarts

Can you please provide the individual patch / merge request for 5.x? Since you included the previous fix at https://git.drupalcode.org/project/cloud/-/merge_requests/2112/diffs#34a...

Thanks
First commit to issue fork.
Merge request !2116Issue #3404519: Refactor to native JavaScript from jQuery (k8s_cost_block.js) → (Merged) created by ankithashetty
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.1 & MariaDB 10.3.22
last update 12 months ago
367 pass
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.1 & MariaDB 10.3.22
last update 12 months ago
367 pass
Status changed to Needs review 12 months ago11:39am 30 November 2023
Comment 12 months ago →
🇮🇳India ankithashetty Karnataka, India
Cherry-picked the commits from the previous MR !2112 and raised a new MR !2116 for 5.x.
(Assuming that was the ask made in #8)

Thanks!
Status changed to RTBC 12 months ago9:32am 3 December 2023
Comment 12 months ago →
🇺🇸United States yas California 🇺🇸
@ankithashetty

Thank you for supplying the patch for 5.x. I tested it and it looks good. I'll merge the patch to 6.x, and close this issue as Fixed.
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.1 & MariaDB 10.3.22
last update 12 months ago
367 pass
Status changed to Fixed 12 months ago9:33am 3 December 2023
Comment 12 months ago →
System Message

yas → committed ac699d78 on 5.x authored by ankithashetty →
Issue #3404519 by nakamurarts, ankithashetty, yas: Refactor to native...
Comment 12 months ago →
🇺🇸United States yas California 🇺🇸
Comment 12 months ago →
🇺🇸United States yas California 🇺🇸
Comment 11 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Refactor to native JavaScript from jQuery (k8s_cost_block.js)

Problem/Motivation

Merge Requests

!2116Refactor to native JavaScript from jQuery (k8s_cost_block.js)
Merged

!2112Refactor to native JavaScript from jQuery (k8s_cost_block.js)
Merged

Comments & Activities

Refactor to native JavaScript from jQuery (k8s_cost_block.js)

Problem/Motivation

Merge Requests

!2116Refactor to native JavaScript from jQuery (k8s_cost_block.js)Merged

!2112Refactor to native JavaScript from jQuery (k8s_cost_block.js)Merged

Comments & Activities

!2116Refactor to native JavaScript from jQuery (k8s_cost_block.js)
Merged

!2112Refactor to native JavaScript from jQuery (k8s_cost_block.js)
Merged