🇺🇸United States @yas

@sayan_k_dutta

Thank you for the update. Sorry, I gave you a wrong suggestion. Can you please take a look at my comment? Thanks

@sayan_k_dutta

Thank you for the update. I posted my comments. Thanks

@alok_singh

Thank you for supplying the patch. I posted my comments. Can you please check the ones? Thanks!

yas → changed the visibility of the branch rigel-3491834 to hidden.

@dhruv.mittal

Thank you for the update.

@baldwinlouie

Thank you for your review.

I’ll merge the patch into 7.x and 8.x; and close this issue as Fixed.

@lavanyatalwar

Thank you for updating your MR.

@baldwinlouie

Thank you for your review.

I’ll merge the patch into 7.x and 8.x; and close this issue as Fixed.

@baldwinlouie

Thank you for your review. I’ll merge the patch into 7.x and 8.x; and close this issue as Fixed.

@dhruv.mittal

Thank you for the update.

@lavanyatalwar

Thank you for your review.

I’ll merge the patch into 7.x and 8.x; and close this issue as Fixed.

@jaydeep_patel

Thank you for fixing the issue and supplying the patch.

@dhruvmittal

Thank you for your review.

I’ll merge the patch into 7.x and 8.x; and close this issue as Fixed.

@dhruvmittal

Thank you for supplying the patch.

@baldwinlouie

What do you think?

Thanks

@all

The phpcs tests have been passed successfully, so I’ll merge the patch into 7.x and 8.x; and close this issue as Fixed.

yas → created an issue.

@all

The phpcs tests have been passed successfully, so I’ll merge the patch into 6.x, 7.x and 8.x; and close this issue as Fixed.

yas → created an issue.

@all

I ran the Behat tests and looks good. I’ll merge the patch into 7.x and 8.x; and close this issue as Fixed.

@baldwinlouie

Thank you for your confirmation by your own testing!

@dhruvmittal

Thank you for supplying MR. I’ll merge the patch into 7.x and 8.x; and close this issue as Fixed.

@akulsaxena

By the way, did you read the contributor guide?

https://www.drupal.org/community/contributor-guide/skill/software-testin... →

@akulsaxena

Thank you for your contribution and for taking the initiative to work on the PHPCS issue. While the issue may have been closed as outdated, your effort is still appreciated as part of the community's collaborative spirit.

In terms of credits, contributions that result in a merged patch or tangible improvement are typically what count towards formal recognition.
Since the patch in this case did not proceed to completion due to the issue's outdated status, it may not count as a final credit. However, your engagement and attempt to contribute are valuable experiences that will undoubtedly help in future contributions.

I encourage you to continue participating in issues, as every effort builds your understanding of the process and increases the likelihood of future successes. If you have further questions or need guidance on other issues, feel free to ask.

Thanks

@akulsaxena

No, it doesn't mean we can make this issue RTBC. PHPUnit tests are not enough in this case since the patch has so many changes.

We need to test the patch more carefully. I'm now testing the patch by running Behat.

@all

This issue had been created before a 8.x branch is released; therefore the issue fork doesn't have the 8.x branch. Therefore I cloned this issue to 📌 Comply with Drupal coding standards (34) (phpcs) Needs work . I will close this issue by marking Closed (outdated).

Thanks

yas → created an issue.

@akulsaxena

I found the problem on your MR. You changed the order of the arguments to fix the nullable type hints. The way how you fixed broke the signature of the interfaces/methods, therefore obviously the existing code base won't work.

I'll take over this issue.

Thanks!

@akulsaxena

Thank you for your efforts. The PHPUnit errors must be fixed before we merge the MR. I assume that all PHPUnit errors are caused by nullable type hint. Therefore I suggest that you can create the MR only focused on the only namespace alphabetical order.

Thanks¥

@baldwinlouie

Thank you for your comment.

@dhruvmittal

As @baldwinlouie mentioned, I agree to `sass`.

@all

I’ll merge the patch into 7.x and 2.0.x; and close this issue as Fixed.

yas → created an issue.

@all

The job at https://git.drupalcode.org/project/cloud_orchestrator/-/jobs/3390910 has been succeeded, so I’ll merge the patch into 7.x and 8.x; and close this issue as Fixed.

@dhruvmittal

Thank you for your suggestion.

@baldwinlouie

What do you think?

yas → changed the visibility of the branch 3488073-update-.gitlab-ci.yml-to to hidden.

yas → created an issue.

@all

The job at https://git.drupalcode.org/project/rigel/-/jobs/3390523 has been succeeded, so I’ll merge the patch into 7.x and 8.x; and close this issue as Fixed.

yas → created an issue.

@dhruvmittal

Thank you for the update.

@baldwinlouie

Thank you for your review.

I’ll merge the patch into 7.x and 8.x; and close this issue as Fixed.

@akulsaxena

Thank you for your message and for taking a look at this issue.

I appreciate your interest and efforts. In this particular case, the issue was already resolved and the fix was confirmed by the automated testing, therefore additional contributions were minimal (The Drupal credit system doesn't add your credit by default, too), so I have decided not to add additional credits. However, your enthusiasm and willingness to contribute are greatly appreciated.

I encourage you to continue participating in the community, and I look forward to collaborating with you on future issues.

Thanks

@akulsaxena

Close the current branch and restart.

1. Please create a new branch w/ Version 8.x-dev for the branch 8.x branch on this issue and update the branch.
2. Change the Version to 7.x-dev on this issue and update the branch 7.x.

By the way, your patch has not passed the PHPUnit at https://git.drupalcode.org/issue/cloud-3461750/-/jobs/3366433. Please check your fixes.

Thanks

@akulsaxena

Thank you for your review. I’ll merge the patch into 7.x and 8.x; and close this issue as Fixed.

@all

I’ll merge the patch into 6.x, 7.x and 8.x; and close this issue as Fixed.

yas → changed the visibility of the branch 3487704-add-the-location to hidden.

yas → created an issue. See original summary → .

@akulsaxena

This one should be merged into 8.x, but you started with the 7.x branch. So can you please create two MRs for 7.x and 8.x?

I found the alphabetical order problem on the 8.x branch at https://git.drupalcode.org/project/cloud/-/jobs/3364912.
If you are trying to fix the use statements for the alphabetical order, can you please try to apply the fixes to the 8.x branch?

Thanks!

@akulsaxena

I refactored the line because the PHPCS standards for drupal specified that namespaces should be alphabetically arranged and although they dont affect the code, it is considered good coding practice. Do you want me to change it back to as it was earlier or keep it as it is now?

I checked the Drupal core code, and the use statements for namespaces are basically sorted in a case-insensitive alphabetical order. Since the use statements in our codebase are already sorted alphabetically, please keep them as they are.

yas → changed the visibility of the branch 3487684-update-a-.gitlab-ci.yml-8.x to active.

yas → changed the visibility of the branch 3487684-update-a-.gitlab-ci.yml to hidden.

yas → created an issue.

@akulsaxena

Thank you for your suggested patch.

You seem to try to change the lines of entire all the namespace order, however I don't think we need to refactor them.

Also, Since the 8.x branch has been released, so please rebase your base branch from 7.x to 8.x as the latest one. Thanks!

Thanks

@jaydeep_patel

Thank you for your review.

@dhruvmittal

Thank you for the update. Please fix the Sytlelint issue at https://git.drupalcode.org/issue/rigel-3483048/-/jobs/3364430.

For the other issues, please create a new issue if you can work on it.

Thanks

@zterry95

Since we have not had any further comments or feedback, so let us close this issue.

Thanks

@akulsaxena

Since the 8.x branch has been released, so please rebase your base branch from 7.x to 8.x as the latest one. Thanks!

@akulsaxena

Thank you for your suggested patch. I posted my comments. Also, I don't think we need to refactor the order of all the namespaces.

Thanks

@jaydeep_patel

Thank you for the update. Since the previous suggested patch is merged, can you please update your MR, too?

Thanks!

@anish.ir

Thank you for the fixes. It looks good now.

@baldwinlouie

Thank you for your review.

I’ll merge the patch into 7.x and 8.x; and close this issue as Fixed.

@esha_kundu

Thank you for the fix.

@jaydeep_patel

Thank you for your review.

I’ll merge the patch into 7.x and 8.x; and close this issue as Fixed.

@jaydeep_patel

Thank you for the MR. It seems you used the 6.x branch as the base and are merging into the 8.x branch, resulting in a large number of differences. Most of these changes are already addressed in the 8.x branch. Could you please make your fixes directly based on the 8.x branch? We are currently maintaining the 8.x branch.

Thanks!

@anish.ir

Thank you for the MR. I posted my comment. Can you please take a look at it? Thanks!

@esha_kundu

Thank you for taking care of the issue. Can you please fix the conflicts after merging 🐛 Read more and add new comment need to be styled. Active ? Also, can you fix the Stylelint errors at https://git.drupalcode.org/issue/rigel-3483051/-/jobs/3269077?

Please see also at the README.md about how to do it.

Thanks!

@dhruvmittal

Thank you for fixing the issue.

@chandansha

Thank you for your review.

I’ll merge the patch into 6.x , 7.x and 8.x; and close this issue as Fixed.

@dhruvmittal

Thank you for the fix. It looks good to me now. I’ll merge the patch into 7.x and 8.x; and close this issue as Fixed.

@dhruvmittal

Thank you for supplying the patch. We need to modify the scss file(s) instead of the direct fix to css. Please take a look at the README.md about how to do it.

Thanks!

@dhruvmittal

Thank you for supplying the patch. It looks good but we need to modify the scss file(s) instead. Please take a look at the README.md about how to do it.

Thanks!

@alok_singh

Thank you for supplying the patch. I posted my minor comment. Thanks!

@sachin.addweb

Yes, we merged your MR for 7.x-dev and 8.x-dev, so let us close this issue. Thanks

@sachin.addweb

Thank you for supplying the patches. I’ll merge the patch into 7.x and 8.x; and close this issue as Fixed.

@sachin.addweb

Thank you for the update. It looks having the conflicts in drupal/rigel:8.x. Therefore, could you please create the MR for both 7.x-dev and 8.x-dev, too? I'll merge the current MR for 6.x-dev anyway, though.

Thanks!

@sachin.addweb

Thank you for the patch. I posted my minor comment. Thanks!