🇺🇸United States @yas

@baldwinlouie

Thank you for the great patch. I’ll merge the patch into 8.x; and close this issue as Fixed.

@baldwinlouie

Thank you for the MR. I’ll merge the patch into 8.x; and close this issue as Fixed.

@esha_kundu

Thank you for the update. I’ll merge the patch into 6.x and 7.x; and close this issue as Fixed.

@esha_kundu

Sorry, can you please rebase the patch again due to the previous merge at 🐛 Menu, submenu is not visual, needs to be fixed. Active ? Unfortunately, the patch is concentrated to the specific files, so we need to rebase and merge one by one.

Thanks!

@sagartiwari

Thank you for your review. I’ll merge the patch into 6.x and 7.x; and close this issue as Fixed.

@esha_kundu

Thank you for the update. I’ll merge the patch into 6.x and 7.x; and close this issue as Fixed.

@sagartiwari

It looks you assigned yourself for this issue. Do you have anything that you want to fix regarding the patch? If so, please change the status to Needs work. Otherwise, I'll merge the patch. Thanks

@esha_kundu

Thank you for the update. I’ll merge the patch into 6.x and 7.x; and close this issue as Fixed.

@baldwinlouie

Thank you for your review.

@alok_singh @jaydeep_patel

Can you please rebase the MR due to the previous merge? Thanks!

@baldwinlouie @sdhruvi5142

Thank you for your review.

@alok_singh @jaydeep_patel

Thank you for your patch. Can you please rebase the MR due to the previous merge? Thanks!

@rohitsharma401 @baldwinlouie

Thank you for your review.

@esha_kundu

Thank you for the patch. Can you please rebase the MR due to the previous merge? Thanks!

@sdhruvi5142

Thank you for your review.

@alok_singh

Can you please resolve the conflicts due to the previous merge? Thanks!

@alok_singh

Thank you for your contribution.

@sdhruvi5142

Thank you for your review. I’ll merge the patch into 6.x and 7.x; and close this issue as Fixed.

@alok_singh @esha_kundu

Can you please resolve the conflicts due to the previous merge? Thanks!

@alok_singh @esha_kundu

Thank you for your contribution.

@baldwinlouie

Thank you for your review. I’ll merge the patch into 6.x and 7.x; and close this issue as Fixed.

@baldwinlouie

Thank you for supplying the patch. I’ll merge the patch into 8.x; and close this issue as Fixed.

@alok_singh

Can you please rebase the patch due to the previous merge? Thanks!

@alok_singh

Thank you for your contribution.

@sdhruvi5142

Thank you for your review. I’ll merge the patch into 6.x and 7.x; and close this issue as Fixed.

@alok_singh

Can you please rebase the patch due to the previous merge? Thanks!

@alok_singh

Thank you for your contribution.

@sdhruvi5142

Thank you for your review. I’ll merge the patch into 6.x and 7.x; and close this issue as Fixed.

@vivek-panicker

Thank you for your contribution. I'll merge the patch. Thanks!

@baldwinlouie

Thank you for the fix. I’ll merge the patch into 6.x and 7.x; and close this issue as Fixed.

@baldwinlouie

Thank you for the fix. I’ll merge the patch into 7.x and 8.x; and close this issue as Fixed.

@baldwinlouie

Thank you for the fix. I’ll merge the patch into 7.x and 8.x; and close this issue as Fixed.

@baldwinlouie

Thank you for the update. I’ll merge the patch into 7.x and 8.x; and close this issue as Fixed.

@baldwinlouie

I’ll merge the patch into 7.x and 8.x; and close this issue as Fixed.

@baldwinlouie

Thank you for the update. The patch looks good to me. I’ll merge the patch into 7.x and 8.x; and close this issue as Fixed.

@baldwinlouie

I tried to merge the patch however it looks having some conflicts? Could you please take a look at it? Thanks!

@baldwinlouie

Thank you for the update. I’ll merge the patch into 7.x and 8.x; and close this issue as Fixed.

@all

I’ll merge the patch into 5.x, 6.x, 7.x and 8.x; and close this issue as Fixed.

@all

I’ll merge the patch into 5.x, 6.x, 7.x and 8.x; and close this issue as Fixed.

yas → created an issue.

yas → created an issue.

@sayan_k_dutta

Thank you for the update.

@baldwinlouie

Thank you for your review. I’ll merge the patch into 6.x and 7.x; and close this issue as Fixed.

surabhi-gokte → credited yas → .

@sayan_k_dutta

Thank you for the update. Sorry, I gave you a wrong suggestion. Can you please take a look at my comment? Thanks

@sayan_k_dutta

Thank you for the update. I posted my comments. Thanks

@alok_singh

Thank you for supplying the patch. I posted my comments. Can you please check the ones? Thanks!

yas → changed the visibility of the branch rigel-3491834 to hidden.

@dhruv.mittal

Thank you for the update.

@baldwinlouie

Thank you for your review.

I’ll merge the patch into 7.x and 8.x; and close this issue as Fixed.

@lavanyatalwar

Thank you for updating your MR.

@baldwinlouie

Thank you for your review.

I’ll merge the patch into 7.x and 8.x; and close this issue as Fixed.

@baldwinlouie

Thank you for your review. I’ll merge the patch into 7.x and 8.x; and close this issue as Fixed.

@dhruv.mittal

Thank you for the update.

@lavanyatalwar

Thank you for your review.

I’ll merge the patch into 7.x and 8.x; and close this issue as Fixed.

@jaydeep_patel

Thank you for fixing the issue and supplying the patch.

@dhruvmittal

Thank you for your review.

I’ll merge the patch into 7.x and 8.x; and close this issue as Fixed.

@dhruvmittal

Thank you for supplying the patch.

@baldwinlouie

What do you think?

Thanks

@all

The phpcs tests have been passed successfully, so I’ll merge the patch into 7.x and 8.x; and close this issue as Fixed.

yas → created an issue.

@all

The phpcs tests have been passed successfully, so I’ll merge the patch into 6.x, 7.x and 8.x; and close this issue as Fixed.

yas → created an issue.

@all

I ran the Behat tests and looks good. I’ll merge the patch into 7.x and 8.x; and close this issue as Fixed.

@baldwinlouie

Thank you for your confirmation by your own testing!

@dhruvmittal

Thank you for supplying MR. I’ll merge the patch into 7.x and 8.x; and close this issue as Fixed.

@akulsaxena

By the way, did you read the contributor guide?

https://www.drupal.org/community/contributor-guide/skill/software-testin... →

@akulsaxena

Thank you for your contribution and for taking the initiative to work on the PHPCS issue. While the issue may have been closed as outdated, your effort is still appreciated as part of the community's collaborative spirit.

In terms of credits, contributions that result in a merged patch or tangible improvement are typically what count towards formal recognition.
Since the patch in this case did not proceed to completion due to the issue's outdated status, it may not count as a final credit. However, your engagement and attempt to contribute are valuable experiences that will undoubtedly help in future contributions.

I encourage you to continue participating in issues, as every effort builds your understanding of the process and increases the likelihood of future successes. If you have further questions or need guidance on other issues, feel free to ask.

Thanks

@akulsaxena

No, it doesn't mean we can make this issue RTBC. PHPUnit tests are not enough in this case since the patch has so many changes.

We need to test the patch more carefully. I'm now testing the patch by running Behat.

@all

This issue had been created before a 8.x branch is released; therefore the issue fork doesn't have the 8.x branch. Therefore I cloned this issue to 📌 Comply with Drupal coding standards (34) (phpcs) Needs work . I will close this issue by marking Closed (outdated).

Thanks

yas → created an issue.

@akulsaxena

I found the problem on your MR. You changed the order of the arguments to fix the nullable type hints. The way how you fixed broke the signature of the interfaces/methods, therefore obviously the existing code base won't work.

I'll take over this issue.

Thanks!

@akulsaxena

Thank you for your efforts. The PHPUnit errors must be fixed before we merge the MR. I assume that all PHPUnit errors are caused by nullable type hint. Therefore I suggest that you can create the MR only focused on the only namespace alphabetical order.

Thanks¥

@baldwinlouie

Thank you for your comment.

@dhruvmittal

As @baldwinlouie mentioned, I agree to `sass`.

@all

I’ll merge the patch into 7.x and 2.0.x; and close this issue as Fixed.

yas → created an issue.

@all

The job at https://git.drupalcode.org/project/cloud_orchestrator/-/jobs/3390910 has been succeeded, so I’ll merge the patch into 7.x and 8.x; and close this issue as Fixed.