- Issue created by @alok_singh
- Merge request !86rigel-3491824: Readmore and Add new comment, needs to be styled. → (Open) created by alok_singh
- 🇮🇳India lavanyatalwar
Hi @alok_singh,
You have done changes in _components.scss file but your changes are not reflecting in main.css.
Moving it back to NW. - 🇮🇳India alok_singh
@lavanyatalwar Compile scss in your system.
@dhruvmittal No need work on this, only compile in your system.Thanks
Hi @alok_singh it's better to compile scss and update css code before pushing the code to the repo
Thanks- 🇮🇳India Vivek Panicker Kolkata
I see a lot of us are assigning/unassigning themselves from the issue.
Please note that this is not a good practice, unnecessarily pollutes the issue history and makes things difficult for the maintainers.As you are new contributors, please speak to the mentors in your company about the contribution guidelines.
@dhruv.mittal, @akulsaxena, @lavanyatalwar let's connect on a call to discuss any doubts we have regarding contribution best practices.
- 🇮🇳India jaydeep_patel Ahmedabad
I have tested mr!86, It's applied successfully. But I came to know that issue not been fixed due to scss not compiled to main.css, So I have compiled it and pushed the code.
Now Read more and Add new comment buttons looks good after compiled scss to css.
Moving it to RTBC.
Thank you
- 🇺🇸United States baldwinlouie
@jaydeep_patel. Thank you so much for your patch. The compiled
main.css
looks to have a lot of change. I think most of them is because thenpx prettier
did not run. Can you please review the https://git.drupalcode.org/project/rigel/-/blob/8.x/README.md?ref_type=h... and rungrunt
to do the SCSS compilation. It will runnpx prettier
so themain.css
is formatted properly and we can review the changes made tomain.css