Account created on 27 March 2007, about 18 years ago
#

Merge Requests

More

Recent comments

🇺🇸United States baldwinlouie

@yas, Please review this patch. This add support for creating the Scope entity for drupal/simple_oauth:6.x

🇺🇸United States baldwinlouie

@yas, please review this patch. It fixes some Drupal 11 compatibility issues.

🇺🇸United States baldwinlouie

@esha_kundu Thank you for the patch. It looks good to me. Marking RTBC

🇺🇸United States baldwinlouie

@esha_kundu, @rohitsharma401 Thank you for the patch. It looks good to me.

🇺🇸United States baldwinlouie

@yas Please review this patch. This fixes the 500 error from our config forms.

🇺🇸United States baldwinlouie

@yas, I fixed the ESLint errors. Please review when you get a chance.

🇺🇸United States baldwinlouie

@yas, please review this patch. This fixes the ordering issue with dark-theme.css. I'm forcing it to be rendered after all the bootstrap libraries are declared.

Also, I fixed the issue with jquery.once. In global.js, there were still references to jquery.once which has been deprecated for drupal/once. This code was causing Javascript errors and the "tabs" on the dashboard were not working.

🇺🇸United States baldwinlouie

@jaydeep_patel, thank you for the patch. It looks good to me. Moving to RTBC

🇺🇸United States baldwinlouie

@jaydeep_patel, thank you for the patch. It looks good to me. Moving to RTBC

🇺🇸United States baldwinlouie

@yas. Please review this patch. This updates the maclof/kubernetes-client to 0.31 in prep for Drupal 11

🇺🇸United States baldwinlouie

@yas, I updated the MR. It looks like it is mergeable now.

🇺🇸United States baldwinlouie

@yas, please review this patch. This removes the deprecated default_argument_skip_url from our view configuration files.

This also removes the {% apply spaceless %} twig filter, which has also been deprecated.

🇺🇸United States baldwinlouie

@yas, please review this patch. This adds support for Drupal 11 into the submodules.

🇺🇸United States baldwinlouie

@sayan_k_dutta , thank you for the patch. It looks good to me now. Moving to RTBC.

🇺🇸United States baldwinlouie

@sdhruvi5142, Thank you for the patch. I have one comment. Can you please check it out.

🇺🇸United States baldwinlouie

@sayan_k_dutta, Thank you for the patch. I have one comment. Can you please check it out.

🇺🇸United States baldwinlouie

@alok_singh, Thank you for the patch. I have one comment. Can you please check it out.

🇺🇸United States baldwinlouie

@kanchan bhogade, Thank you for the patch. I have one comment. Can you please check it out.

🇺🇸United States baldwinlouie

@alok_singh, Thank you for the patch. I have one comment. Can you please check it out.

🇺🇸United States baldwinlouie

@dhruv.mittal, Thank you for updating the patch. It looks good to me now. Marking RTBC.

🇺🇸United States baldwinlouie

@lavanyatalwar and @jaydeep_patel,

Thank you for the patch. It looks good to me.

🇺🇸United States baldwinlouie

@dhruv.mittal Thank you for supplying this patch. It looks good to me. Moving to RTBC.

🇺🇸United States baldwinlouie

@jaydeep_patel. Thank you so much for your patch. The compiled main.css looks to have a lot of change. I think most of them is because the npx prettier did not run. Can you please review the https://git.drupalcode.org/project/rigel/-/blob/8.x/README.md?ref_type=h... and run grunt to do the SCSS compilation. It will run npx prettier so the main.css is formatted properly and we can review the changes made to main.css

🇺🇸United States baldwinlouie

@jaydeep_patel. Thank you so much for your patch. The compiled main.css looks to have a lot of change. I think most of them is because the npx prettier did not run. Can you please review the https://git.drupalcode.org/project/rigel/-/blob/8.x/README.md?ref_type=h... and run grunt to do the SCSS compilation. It will run npx prettier so the main.css is formatted properly and we can review the changes made to main.css

🇺🇸United States baldwinlouie

@dhruv.mittal Thank you for the patch. Can you please double check the compiling of the SCSS? The changes in _component.css is fairly minimal, but main.css has a lot of changes to it.

🇺🇸United States baldwinlouie

@jaydeep_patel and @dhruv.mittal, Thank you for the patch. I have made one comment on the code. Can you please review it.

🇺🇸United States baldwinlouie

@dhruv.mittal and @jaydeep_patel , Thank you for the merge request. Can you please double check the compiling of the SCSS? The changes in _component.css is fairly minimal, but main.css has a lot of changes to it.

🇺🇸United States baldwinlouie

@dhruv.mittal, I tested this patch and it looks good to me. Setting to RTBC

🇺🇸United States baldwinlouie

@dhruv.mittal

Thanks for looking at this ticket. I think `sass` is the option we go with.

🇺🇸United States baldwinlouie

@dhruv.mittal, thank you for the patch. It looks good to me. Changing to RTBC

🇺🇸United States baldwinlouie

@anish.ir, Thank you for providing the patch. It looks good to me. Moving it to RTBC.

🇺🇸United States baldwinlouie

@yas, I've updated the patch to fix the stylelint issues.

🇺🇸United States baldwinlouie

@yas, please review these patches.

🇺🇸United States baldwinlouie

@yas, I'll create the 7.x and 8.x branch

🇺🇸United States baldwinlouie

@sachin.addweb. Thank you for the fixes to the patch. It looks good to me now.

🇺🇸United States baldwinlouie

@sachin.addweb, Thank you for the updated patch. It fixes the "close" icon issue.

Please take a look at this comment: https://git.drupalcode.org/project/rigel/-/merge_requests/68#note_370892

Aside from that, it is looks good to me.

🇺🇸United States baldwinlouie

@sachin.addweb, Thank you for the updated patch. I made one code comment. Also, please see attached screenshot. When you added the new "X" as the close icon, there smaller one is still showing up.

🇺🇸United States baldwinlouie

Changing to needs review to trigger testing.

🇺🇸United States baldwinlouie

@sachin.addweb, Thank you for taking over this patch. There are stylelint issues reported with main.css during Unit testing. Can you please run Step 6 from the README.md, npx prettier --config .prettierrc.json --write "assets/css/main.css". That will fix all the stylelint issues.

🇺🇸United States baldwinlouie

@yas, thank you for the update on the patch! It looks good to me now.

🇺🇸United States baldwinlouie

@yas, thank you for the patch. I just have these minor comments. Aside from that, it looks good.

🇺🇸United States baldwinlouie

@yas, thank you for the patch. This looks good to me.

🇺🇸United States baldwinlouie

@yas this looks good to me. Thank you for the patch.

🇺🇸United States baldwinlouie

@yas this looks good to me. Thank you for the patch.

🇺🇸United States baldwinlouie

@yas, thank you for the patch. This looks good to me.

🇺🇸United States baldwinlouie

@yas, thank you for the patch. It looks good to me.

🇺🇸United States baldwinlouie

@yas, thank you for the updated patch. It looks good to me.

🇺🇸United States baldwinlouie

@yas, thank you for the patch. I have one comment.

🇺🇸United States baldwinlouie

@yas Please review this patch. This takes care of a few things

1. Fixes the white background because in Drupal 10.4+, the css class is accordion and not card anymore
2. Changes all double quotes to single quote because of Drupal coding standards reported by prettier
3. Moves css attributes around reported by prettier. For example, all transition attributes need to be moved lower in a css class
4. Setup Grunt so it automatically runs a local prettier to reformat all code based on the .prettierrc.json

🇺🇸United States baldwinlouie

@yas, thank you for the patch. It looks good to me.

🇺🇸United States baldwinlouie

@yas, thank you for the patch. It looks good to me.

🇺🇸United States baldwinlouie

@yas, thank you for the patch. It looks good to me.

🇺🇸United States baldwinlouie

@yas, thank you for the patch. This looks good to me.

🇺🇸United States baldwinlouie

@yas, please review this patch again. I've incorporated all your feedback. I also fixed the Unit Test: https://git.drupalcode.org/project/cloud/-/jobs/1681933

🇺🇸United States baldwinlouie

@yas, Please review this patch. This adds a new field to the K8s cloud service provider form.

When cloud store entities are imported, they will use the uid from the cloud service provider entity.

🇺🇸United States baldwinlouie

@yas, Thanks for the patch. It looks good to me.

🇺🇸United States baldwinlouie

@yas, Thanks for the patch. It looks good to me.

🇺🇸United States baldwinlouie

@yas, please review this patch. This fixes the hard-coded "Store Content" title on Cloud Store entities.

🇺🇸United States baldwinlouie

baldwinlouie changed the visibility of the branch 3446961-change-hard-coded-store to hidden.

🇺🇸United States baldwinlouie

@yas, please review this patch. This fixes the breadcrumb spacing issue.

🇺🇸United States baldwinlouie

@yas, please review this patch. This fix moves the Cancel button into the correct location in a modal. It turns out the following code removes the necessary css class that the Dialog JS needs to move the button into the lower right hand corner.

$form['actions']['cancel']['#attributes']['class']['0'] = '';

I also changed the color of the Cancel button. Best practice says the the cancel button should be a different color than the main "Delete" button. That way, the user can easily distinguish between the two.

What do you think about the color change.

🇺🇸United States baldwinlouie

@yas, thank you for the patch. This looks good to me.

🇺🇸United States baldwinlouie

@yas, thank you for the patch. This looks good to me.

🇺🇸United States baldwinlouie

@yas, thank you for the patch. This looks good to me.

🇺🇸United States baldwinlouie

@yas, thank you for the patch. It looks good to me.

🇺🇸United States baldwinlouie

@yas, I opened a hotfix branch to fix the coding issue. 3436310-coding-fix.

Please review it.

🇺🇸United States baldwinlouie

@yas, please review the hotfix. This fixes the coder issue.

🇺🇸United States baldwinlouie

@yas, please review this patch. It adds css styling to modals.

🇺🇸United States baldwinlouie

@yas, please review this patch. I've added a GitHub token field and removed the ability to build 4.x version of Cloud Orchestrator.

🇺🇸United States baldwinlouie

@yas thanks for the patch. This looks good to me.

🇺🇸United States baldwinlouie

@yas thanks for the patch. This looks good to me.

Production build 0.71.5 2024