In add new comment, Preview button is not visible.

Added background color for the preview button so it is now more visible.

@dhruvmittal

Thank you for supplying the patch. We need to modify the scss file(s) instead of the direct fix to css. Please take a look at the README.md about how to do it.

Thanks!

dhruv.mittal → changed the visibility of the branch 3483048-in-add-new to hidden.

I have made changes in scss now please have a look

Heyy @yas!!
while doing npm install

npm WARN deprecated osenv@0.1.5: This package is no longer supported.
npm WARN deprecated @npmcli/move-file@1.1.2: This functionality has been moved to @npmcli/fs
npm WARN deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm WARN deprecated npmlog@5.0.1: This package is no longer supported.
npm WARN deprecated npmlog@6.0.2: This package is no longer supported.
npm WARN deprecated har-validator@5.1.5: this library is no longer supported
npm WARN deprecated rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported
npm WARN deprecated are-we-there-yet@2.0.0: This package is no longer supported.
npm WARN deprecated are-we-there-yet@3.0.1: This package is no longer supported.
npm WARN deprecated glob@7.1.7: Glob versions prior to v9 are no longer supported
npm WARN deprecated gauge@3.0.2: This package is no longer supported.
npm WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated gauge@4.0.4: This package is no longer supported.
npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated node-sass@7.0.3: Node Sass is no longer supported. Please use sass or sass-embedded instead.
npm ERR! code 1
npm ERR! path /home/dhruv/Desktop/drupal101/web/themes/contrib/rigel/node_modules/node-sass
npm ERR! command failed
npm ERR! command sh -c node scripts/build.js
npm ERR! Building: /usr/bin/node /home/dhruv/Desktop/drupal101/web/themes/contrib/rigel/node_modules/node-gyp/bin/node-gyp.js rebuild --verbose --libsass_ext= --libsass_cflags= --libsass_ldflags= --libsass_library=
npm ERR! gyp info it worked if it ends with ok
npm ERR! gyp verb cli [
npm ERR! gyp verb cli   '/usr/bin/node',
npm ERR! gyp verb cli   '/home/dhruv/Desktop/drupal101/web/themes/contrib/rigel/node_modules/node-gyp/bin/node-gyp.js',
npm ERR! gyp verb cli   'rebuild',
npm ERR! gyp verb cli   '--verbose',
npm ERR! gyp verb cli   '--libsass_ext=',
npm ERR! gyp verb cli   '--libsass_cflags=',
npm ERR! gyp verb cli   '--libsass_ldflags=',
npm ERR! gyp verb cli   '--libsass_library='
npm ERR! gyp verb cli ]
npm ERR! gyp info using node-gyp@8.4.1
npm ERR! gyp info using node@18.19.1 | linux | x64
npm ERR! gyp verb command rebuild []
npm ERR! gyp verb command clean []
npm ERR! gyp verb clean removing "build" directory
npm ERR! gyp verb command configure []
npm ERR! gyp verb find Python Python is not set from command line or npm configuration
npm ERR! gyp verb find Python Python is not set from environment variable PYTHON
npm ERR! gyp verb find Python checking if "python3" can be used
npm ERR! gyp verb find Python - executing "python3" to get executable path
npm ERR! gyp verb find Python - executable path is "/usr/bin/python3"
npm ERR! gyp verb find Python - executing "/usr/bin/python3" to get version
npm ERR! gyp verb find Python - version is "3.12.3"
npm ERR! gyp info find Python using Python version 3.12.3 found at "/usr/bin/python3"
npm ERR! gyp verb get node dir no --target version specified, falling back to host node version: 18.19.1
npm ERR! gyp verb command install [ '18.19.1' ]
npm ERR! gyp verb install input version string "18.19.1"
npm ERR! gyp verb install installing version: 18.19.1
npm ERR! gyp verb install --ensure was passed, so won't reinstall if already installed
npm ERR! gyp verb install version is already installed, need to check "installVersion"
npm ERR! gyp verb got "installVersion" 9
npm ERR! gyp verb needs "installVersion" 9
npm ERR! gyp verb install version is good
npm ERR! gyp verb get node dir target node version installed: 18.19.1
npm ERR! gyp verb build dir attempting to create "build" dir: /home/dhruv/Desktop/drupal101/web/themes/contrib/rigel/node_modules/node-sass/build
npm ERR! gyp verb build dir "build" dir needed to be created? Yes
npm ERR! gyp verb build/config.gypi creating config file
npm ERR! gyp verb build/config.gypi writing out config file: /home/dhruv/Desktop/drupal101/web/themes/contrib/rigel/node_modules/node-sass/build/config.gypi
npm ERR! gyp verb config.gypi checking for gypi file: /home/dhruv/Desktop/drupal101/web/themes/contrib/rigel/node_modules/node-sass/config.gypi
npm ERR! gyp verb common.gypi checking for gypi file: /home/dhruv/Desktop/drupal101/web/themes/contrib/rigel/node_modules/node-sass/common.gypi
npm ERR! gyp verb gyp gyp format was not specified; forcing "make"
npm ERR! gyp info spawn /usr/bin/python3
npm ERR! gyp info spawn args [
npm ERR! gyp info spawn args   '/home/dhruv/Desktop/drupal101/web/themes/contrib/rigel/node_modules/node-gyp/gyp/gyp_main.py',
npm ERR! gyp info spawn args   'binding.gyp',
npm ERR! gyp info spawn args   '-f',
npm ERR! gyp info spawn args   'make',
npm ERR! gyp info spawn args   '-I',
npm ERR! gyp info spawn args   '/home/dhruv/Desktop/drupal101/web/themes/contrib/rigel/node_modules/node-sass/build/config.gypi',
npm ERR! gyp info spawn args   '-I',
npm ERR! gyp info spawn args   '/home/dhruv/Desktop/drupal101/web/themes/contrib/rigel/node_modules/node-gyp/addon.gypi',
npm ERR! gyp info spawn args   '-I',
npm ERR! gyp info spawn args   '/home/dhruv/.cache/node-gyp/18.19.1/include/node/common.gypi',
npm ERR! gyp info spawn args   '-Dlibrary=shared_library',
npm ERR! gyp info spawn args   '-Dvisibility=default',
npm ERR! gyp info spawn args   '-Dnode_root_dir=/home/dhruv/.cache/node-gyp/18.19.1',
npm ERR! gyp info spawn args   '-Dnode_gyp_dir=/home/dhruv/Desktop/drupal101/web/themes/contrib/rigel/node_modules/node-gyp',
npm ERR! gyp info spawn args   '-Dnode_lib_file=/home/dhruv/.cache/node-gyp/18.19.1/<(target_arch)/node.lib',
npm ERR! gyp info spawn args   '-Dmodule_root_dir=/home/dhruv/Desktop/drupal101/web/themes/contrib/rigel/node_modules/node-sass',
npm ERR! gyp info spawn args   '-Dnode_engine=v8',
npm ERR! gyp info spawn args   '--depth=.',
npm ERR! gyp info spawn args   '--no-parallel',
npm ERR! gyp info spawn args   '--generator-output',
npm ERR! gyp info spawn args   'build',
npm ERR! gyp info spawn args   '-Goutput_dir=.'
npm ERR! gyp info spawn args ]
npm ERR! Traceback (most recent call last):
npm ERR!   File "/home/dhruv/Desktop/drupal101/web/themes/contrib/rigel/node_modules/node-gyp/gyp/gyp_main.py", line 42, in <module>
npm ERR!     import gyp  # noqa: E402
npm ERR!     ^^^^^^^^^^
npm ERR!   File "/home/dhruv/Desktop/drupal101/web/themes/contrib/rigel/node_modules/node-gyp/gyp/pylib/gyp/__init__.py", line 9, in <module>
npm ERR!     import gyp.input
npm ERR!   File "/home/dhruv/Desktop/drupal101/web/themes/contrib/rigel/node_modules/node-gyp/gyp/pylib/gyp/input.py", line 19, in <module>
npm ERR!     from distutils.version import StrictVersion
npm ERR! ModuleNotFoundError: No module named 'distutils'
npm ERR! gyp ERR! configure error 
npm ERR! gyp ERR! stack Error: gyp failed with exit code: 1
npm ERR! gyp ERR! stack     at ChildProcess.onCpExit (/home/dhruv/Desktop/drupal101/web/themes/contrib/rigel/node_modules/node-gyp/lib/configure.js:259:16)
npm ERR! gyp ERR! stack     at ChildProcess.emit (node:events:517:28)
npm ERR! gyp ERR! stack     at ChildProcess._handle.onexit (node:internal/child_process:292:12)
npm ERR! gyp ERR! System Linux 6.8.0-47-generic
npm ERR! gyp ERR! command "/usr/bin/node" "/home/dhruv/Desktop/drupal101/web/themes/contrib/rigel/node_modules/node-gyp/bin/node-gyp.js" "rebuild" "--verbose" "--libsass_ext=" "--libsass_cflags=" "--libsass_ldflags=" "--libsass_library="
npm ERR! gyp ERR! cwd /home/dhruv/Desktop/drupal101/web/themes/contrib/rigel/node_modules/node-sass
npm ERR! gyp ERR! node -v v18.19.1
npm ERR! gyp ERR! node-gyp -v v8.4.1
npm ERR! gyp ERR! not ok 
npm ERR! Build failed with error code: 1

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/dhruv/.npm/_logs/2024-11-07T04_50_43_375Z-debug-0.log

These warning occur.
I think the error is encountering is related to the node-sass package, which is deprecated and not supported anymore
If you agree can i create a new issue for it.

Preview button is visible but Border radius and hover effect is different then Save button So moving it to Need Work. Attached screenshot for reference.

Note: I am happy to maintain this project if you give me an opportunity to maintain.

Thank you!!

@jaydeep_patel

Thank you for your review.

@dhruvmittal

Thank you for the update. Please fix the Sytlelint issue at https://git.drupalcode.org/issue/rigel-3483048/-/jobs/3364430.

For the other issues, please create a new issue if you can work on it.

Thanks

Hi @yas Now I have fixed stylelint issue please review

@dhruv.mittal, thank you for the patch. It looks good to me. Changing to RTBC

@dhruvmittal

Thank you for the update.

@baldwinlouie

Thank you for your review.

I’ll merge the patch into 7.x and 8.x; and close this issue as Fixed.

Automatically closed - issue fixed for 2 weeks with no activity.