- Issue created by @alok_singh
- 🇺🇸United States yas California 🇺🇸
@anish.ir
Thank you for the MR. I posted my comment. Can you please take a look at it? Thanks!
@yas
The comment you have posted on my MR has been resolved. Although there is a merge conflict since there has been a new commit that was merged into the main branch.
Working on it, resolving.- 🇺🇸United States baldwinlouie
@anish.ir, Thank you for providing the patch. It looks good to me. Moving it to RTBC.
- 🇺🇸United States yas California 🇺🇸
@anish.ir
Thank you for the fixes. It looks good now.
@baldwinlouie
Thank you for your review.
I’ll merge the patch into
7.x
and8.x
; and close this issue as Fixed. -
yas →
committed 0a65f55b on 8.x authored by
anish.ir →
Issue #3482653 by anish.ir, alok_singh, yas, baldwinlouie: Refactor...
-
yas →
committed 0a65f55b on 8.x authored by
anish.ir →
-
yas →
committed 5650486e on 7.x authored by
anish.ir →
Issue #3482653 by anish.ir, yas, alok_singh, baldwinlouie: Refactor...
-
yas →
committed 5650486e on 7.x authored by
anish.ir →
Automatically closed - issue fixed for 2 weeks with no activity.