Inactive tabs are not visible, needs to be fixed.

After fixing the issue.

I'll review it.

Hello,
I've reviewed the mentioned issue by following the belows steps,

• I cloned the theme having the default branch (7.x) in Drupal version 10.4.0.
• I visited a random node page and came across the inactive tabs not being visible however were visible only when hovered.
• I applied the MR!49, which applied cleanly.
• On revisiting the node page the inactive tabs text were visible.

The mentioned issue was resolved however I found the background property used in cloud.css file is kept commented which seems to be unnecessary for the provided issue. I've included the before and after ss.
Moving to NW for the unresolved comment in the MR.
Thanks

Hello,
The maintainer has requested the removal of the code instead of simply commenting it out in a few issues. Additionally, there was a conflict in one of the files, which I have now resolved with a new commit. Previously, I had moved the issue to NW due to the unresolved comment in the merge request, but it has now been addressed with the recent commits.
Please take a look.
Thanks!

I've reviewed the above MR,

I cloned the theme repo having the default branch (7.x) in Drupal version 10.4.0.
Tabs are visible for any random node .

@esha_kundu, @rohitsharma401 Thank you for the patch. It looks good to me.

@rohitsharma401 @baldwinlouie

Thank you for your review.

@esha_kundu

Thank you for the patch. Can you please rebase the MR due to the previous merge? Thanks!

Hello @yas,
I've rebased the MR please review. Thanks

@esha_kundu

Thank you for the update. I’ll merge the patch into 6.x and 7.x; and close this issue as Fixed.

@sagartiwari

It looks you assigned yourself for this issue. Do you have anything that you want to fix regarding the patch? If so, please change the status to Needs work. Otherwise, I'll merge the patch. Thanks

Yes, I was trying to review the updates looks good to me, Thanks.

@sagartiwari

Thank you for your review. I’ll merge the patch into 6.x and 7.x; and close this issue as Fixed.

@esha_kundu

Sorry, can you please rebase the patch again due to the previous merge at 🐛 Menu, submenu is not visual, needs to be fixed. Active ? Unfortunately, the patch is concentrated to the specific files, so we need to rebase and merge one by one.

Thanks!

@yas,
I've rebased the MR please check. Thanks!

@esha_kundu

Thank you for the update. I’ll merge the patch into 6.x and 7.x; and close this issue as Fixed.

Automatically closed - issue fixed for 2 weeks with no activity.