- Issue created by @alok_singh
- Merge request !88rigel-3491834: On mobile view, Searched page - Search button needs space. → (Open) created by alok_singh
- 🇮🇳India alok_singh
After fixing the issue. Please compile scss before review.
- 🇮🇳India jaydeep_patel Ahmedabad
@alok_singh, Please compile scss to css and then push your code. Changes not reflected hance moving back to NW.
Thank you
@jaydeep_patel I have compiled the scss to css now, Please have a look.
- 🇮🇳India jaydeep_patel Ahmedabad
Thanks for fixing the issue @dhruv.mittal,
I have reviewed this issue MR!88 applied successfully and it's looks good to me. I have attached screenshot for the reference and moving it to RTBC.
Thank you
- 🇺🇸United States baldwinlouie
@dhruv.mittal and @jaydeep_patel , Thank you for the merge request. Can you please double check the compiling of the SCSS? The changes in
_component.css
is fairly minimal, but main.css has a lot of changes to it. - 🇺🇸United States baldwinlouie
@dhruv.mittal, Thank you for updating the patch. It looks good to me now. Marking RTBC.
- 🇺🇸United States yas California 🇺🇸
@dhruv.mittal
Thank you for the update.
@baldwinlouie
Thank you for your review.
I’ll merge the patch into
7.x
and8.x
; and close this issue as Fixed. -
yas →
committed 60f2c722 on 8.x authored by
dhruv.mittal →
Issue #3491834 by dhruv.mittal, alok_singh, jaydeep_patel, akulsaxena,...
-
yas →
committed 60f2c722 on 8.x authored by
dhruv.mittal →