🇮🇳India @Vivek Panicker

Same question here.

Hey @phjou! Thank you for merging the fix!

I would just like to inform you that according to the latest update, the maintainer has to manually provide credits to the involved participants in the Credit and Committing section in the issue.

So if anyone deserves credit here, kindly do give them! :)

Thank you @bburg.
I believe the credit system changed sometime recently, so we might have missed the update.

@bburg I think they changed the rules recently https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett... → . Credits are not granted automatically it seems.

@bburg happy to help!!!

Additionally, can I request you to provide me credit for the work done, if it is alright with you? :)

vivek panicker → created an issue.

vivek panicker → created an issue.

vivek panicker → created an issue.

vivek panicker → created an issue.

vivek panicker → created an issue.

vivek panicker → created an issue.

vivek panicker → created an issue.

vivek panicker → created an issue.

Looks like the listed dependencies are not supporting the latest version of those modules, hence the error.

vivek panicker → made their first commit to this issue’s fork.

Haven't tested the changes.
So need someone to review and check this.

vivek panicker → created an issue.

@dmitriy-komarov So I guess we should keep this issue open till then, since Drupal 11 supports CKEditor 5 by default.
Or we can have another issue created for this.

@dmitriy-komarov I just checked the codebase and saw that indeed Drupal 11 is supported.
But I am getting this error:

I believe it's because of the related drupal/ckeditor module.
I am using Drupal CMS and here the ckeditor5 module is enabled.

I believe that's the issue.

@maintainers If the problem is fixed, can we move the move the issue to Fixed state?

As anish.ir has not worked on this issue for quite some time, unassigning the issue from him.

The most absurd thing happened.
The issue is not reproducible anymore.
I checked the validation code, and it looked fine to me, so not sure if there are any improvements to be made.
So for now, I think we are good to close the issue.

@prashant.c I do see an instance where we are passing $url.

So I don't think that can be removed now.

Also if the current patch is working for you, can you help move the issue to RTBC please?

Can we get this merged please?

@stephencamilo I think we missed merging the MR.
Can you please check?
Because the dev version of the module is still not supported in Drupal 11.

vivek panicker → created an issue.

vivek panicker → created an issue. See original summary → .

vivek panicker → created an issue.

We can close the issue then!

I think you have followed the proper steps.
Maybe we can have 1 more person give it a try, and if if it's not reproducible, we can close the issue.

Thank you for the quick action!

Hi @maintainers. Can we get this committed soon? We need to migrate a project to Drupal 11, and this module is blocking it.

Hi @maintainers. Can we get this committed soon? We need to migrate a project to Drupal 11, and this module is blocking it.

@kunal_singh Can we please get this committed? We need to migrate a project to Drupal 11, and this module is blocking it.

Hi @maintainers. Can we get this committed soon? We need to migrate a project to Drupal 11, and this module is blocking it.

Hi @maintainers! Is there any chance this is going to get merged soon?

vivek panicker → created an issue.

It's in my to-do list for now.
Will try to get it done by next week.

Hi @maintainers. Is there any plan to get this merged soon?

vivek panicker → created an issue.

I guess the provider options would only appear if the modules are enabled, not the other way around.
In the config form we can ask the user to enable any of the submodules to access a provider.
We can always provide a default provider if we want, so that on enabling itself a provider also appears.

I have a few ideas for this one then.

We can have a parent module with the base implementation, then a submodule for each of the different services we are supporting like 1 for AI module, 1 for Google and so on.
So if tomorrow someone wants to add a new translation service, they can easily do that from a custom or a third party module.

@bigbabert, thanks you so much for the consideration.

I would indeed like that, but I think for now, I'll do some more contribution here in this module, before I feel deserving to pick up the role of the maintainer. :)

I think you are right about this.

I'll move this to the AI module then so that the maintainers can have a look at it.

Happy to help!
I tested v1.3.1 and the issue is now resolved. :)

vivek panicker → created an issue.

vivek panicker → created an issue.

Even after doing this, one more issue remains.
That is if a formatted text field is sent for translation, then in the translated content, the translated text contains the HTML markups unescaped, i.e. we can see the markup.
We should try to resolve this also in a separate bug.

@bigbabert I am still facing issues. So I have created this issue https://www.drupal.org/project/auto_translation/issues/3509171 📌 TypeError: Drupal\ai_translate\Controller\AiTranslateController::translateSingleText(): Argument #1 ($singleText) must be of type array Active and am raising a fix for it.

vivek panicker → created an issue.

@bigabert Now I get this error

The website encountered an unexpected error. Try again later.

TypeError: Drupal\ai_translate\Controller\AiTranslateController::translateSingleText(): Argument #1 ($singleText) must be of type array, string given, called in /var/www/html/web/modules/contrib/auto_translation/src/Utility.php on line 218 in Drupal\ai_translate\Controller\AiTranslateController->translateSingleText() (line 133 of modules/contrib/ai/modules/ai_translate/src/Controller/AiTranslateController.php).
Drupal\auto_translation\Utility->drupalAiTranslateApiCall() (Line: 129)
Drupal\auto_translation\Utility->translate() (Line: 448)
Drupal\auto_translation\Utility->formTranslate() (Line: 39)
auto_translation_form_node_form_alter() (Line: 459)
Drupal\Core\Extension\ModuleHandler->alter() (Line: 833)
Drupal\Core\Form\FormBuilder->prepareForm() (Line: 249)
Drupal\autosave_form\Form\AutosaveFormBuilder->prepareForm() (Line: 280)
Drupal\Core\Form\FormBuilder->buildForm() (Line: 97)
Drupal\autosave_form\Form\AutosaveFormBuilder->buildForm() (Line: 48)
Drupal\Core\Entity\EntityFormBuilder->getForm() (Line: 413)
Drupal\content_translation\Controller\ContentTranslationController->add()
call_user_func_array() (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 593)
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext() (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 183)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 53)
Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle() (Line: 32)
Drupal\big_pipe\StackMiddleware\ContentLength->handle() (Line: 116)
Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 90)
Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle() (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 709)
Drupal\Core\DrupalKernel->handle() (Line: 19)

I checked. It's a valid error.

vivek panicker → created an issue.

vivek panicker → created an issue.

vivek panicker → created an issue.

Thanks for the quick action! :)

After enabling this option, the term reference field was also getting translated

Also new term reference was getting created when translating content.

So everything looks good. Hence closing this issue.

vivek panicker → created an issue.

Thank you @valthebald for your inputs.
I found that the variation fields we not marked translatable.
After doing that, I could see the content is getting translated.

However, not the terms are not getting translated and there is a separate bug for it https://www.drupal.org/project/ai/issues/3502990 🐛 AI Translation did not add value for term reference field Active .

But that is different from the scope of this issue and so we can takle that separately.

The issue does not seem to be resolved yet.
The issue is happening over here https://git.drupalcode.org/project/auto_translation/-/blob/1.0.x/src/Uti....
The method doesn't exist in the controller, but exists in a service, and I think that is what we need to fix.

Hi @bigbabert, thank you for taking action on the issue and getting it fixed!
Just a query - will no credit be given for reporting the issue?

@valthebald @MrDaleSmith Althought this issue has been fixed, but the commerce product variations don't seem to be getting translated.
If you guys have been successful in doing that, can you please point out how you did it.
If not can we create an issue for it and mention it here please?

vivek panicker → created an issue.

vivek panicker → created an issue.

That would be great. Thanks @seogow!

Flexibility of having block independent to View is important for design purposes, hence usage of View area (and thus View's own caching) would not be good for UX builders.

That's something I didn't think of. In that respect, the current implementation looks good.
Maybe we can later add a View area plugin so that if anyone did want to use it, they could.

I suggest to add fingerprinting of content and caching the LLM response. That way, should the content fingerprint - the View's result - remains the same, the LLM call is bypassed and output of a cache is used instead.
Would that be satisfactory?

That sounds good, if it does not add too much overhead.

vivek panicker → created an issue.

vivek panicker → created an issue.

Fixed the code based on the above mentioned points.

Tested the patch on commerce product and commerce product variation.
Patch looks good.

Someone please help to close https://git.drupalcode.org/issue/ai-3506994.

vivek panicker → created an issue.

Apologies for this @mindaugasd .
I was not aware that it's automatically generated.
Wouldn't have edited it if it was.

vivek panicker → created an issue.

vivek panicker → created an issue.

I haven't used that chatbot in a while.
Will need to update the codebase and test it again.
For now I am closing this.
I'll re-open this if I face the same issue again.

Have raise the MR.
Not sure if the branch is correct.

vivek panicker → created an issue.

Tested on D11. Working as expected.

@marcus I am getting this issue when I am creating a new API key from my personal account where I have not enrolled in any plan anytime.

Copying what you mentioned on Slack - "We will not even get the headers needed when testing, because you already passed the amount of requests you can do.".