๐Ÿ‡ฎ๐Ÿ‡ณIndia @Vivek Panicker

Kolkata
Account created on 7 August 2017, over 6 years ago
#

Merge Requests

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

Thanks @adam-delaney
Much appreciated!

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

@Indranil Roy has mentioned to me that the issue is resolved now.
Hence closing the issue.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

@adam-delaney Hi, just noticed that no credits were given for the contribution.
I believe @sandipta and @MukhtarM should receive credits for the help they've rendered?
https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett... โ†’
Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

@theMusician

> Not sure we need to target against 10.3.x, this should all work against the 11.x branch.
Got it, thanks.

> We'll keep this branch open as more attributes become available.
But we don't have any other code using annotations.
Is there any other code for which we are waiting for the attributes to become available?

> Thank you for your contributions to this work.
Happy to help! :)

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

No comment on this ticket for past 2 years.
Closing this ticket.
Please feel free to re-open if required.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

Code looks good.
Also requirements are fulfilled.
Hence moving to RTBC.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

@tjtj can we move the issue to RTBC state if that patch resolves the issue?

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

Thanks a lot @drumm and @fjgarlin for helping to resolve the issue!

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

Hello everyone!

Can someone please look into this?

I am not able to contact the module maintainers to help with review/merge of MRs :(

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

Hello everyone!

Can someone please look into this?

I am not able to contact the module maintainers to help with review/merge of MRs :(

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

@joachim @anybody, can someone help review the PR please?

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

@Tarun Chauhan, if you encounter the issue again, please feel free to open this issue.
Closing this for now.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

@SteveHanson As the issue does not seem related to Drupal Core, I am closing this issue.
Please feel free to re-open in case you do not agree.
Thanks.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

As the issue is very old, I am assuming that newever versions of the project has fixed it.
Hence closing this issue.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

Does not look like an issue.
Please follow the steps mentioned by Tanushree Gupta to resolve the issue.
Closing this issue.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

As discussed with the maintainer, @hansa11, a new version of the theme is in the works and so this fix is no longer required.
Closing this issue.
@hritick @hansa11, kindly close the MR.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata
๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

@ak-lbo Gaurav Gupta did not seem to receive any credit for the work done in this issue.
Any reason why?

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

I have raised the MR, but that needs to be targeted against the Drupal 10.3.x branch.
I am not sure how to do that.
Also, we need to thoroughly test this.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

Annotations are used by the following Field Formatters:
- AbleplayerVideoFormatter
- AbleplayerSignLanguageFormatter
- AbleplayerRemoteVideoFormatter
- AbleplayerPosterImageFormatter
- AbleplayerChapterFormatter
- AbleplayerCaptionFormatter
- AbleplayerAudioFormatter

We have Attribute available for Field formatter: https://www.drupal.org/node/3420980 โ†’

So we can start working on this.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

Happy to help!

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

@ramil g, actually what I am trying to say is that I am not able to reproduce the issue on a fresh Drupal installation with only this contrib module installed.
So can I request you to try to reproduce the issue on a fresh installation and then note down the exact steps followed to reproduce the issue?

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

First of all, we get $value == _none only when we intially had given a value for the field and saved the content and later selected None from the options.
So I think that point needs to be mentioned in the description.
The first time we save the content without selecting any value in the term reference field, we get "" in $value.

2nd point is regarding this code:

1.    if ($element['#shs']['settings']['anyValue'] === reset($value)) {
2.     if (!$element['#required']) {
3.        return;
4.      }
5.      elseif (count($element['#options']) > 1) {
6.        $form_state->setError($element, t('You need to select a term from the deepest level in field @name.', ['@name' => $element['#title']]));
7.        return;
8.      }
9.    }

Even when there is _none in $value, still the code seems to return from line 2, since the element is not required.

So I don't get the part where the error is occurring for you.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

I see that the form that you have is a bit different from the one that I have, for eg. a toggle button saying "Is Registration".

What I would request you to do is try out the module on a fresh install of Drupal and try to reproduce the issue.
Once you are able to do that, can you update the description with the exact steps you followed to arrive at the problem so that someone else can also reproduce the issue?

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

@linhnm I tried with the steps mention and see the date correctly appearing on the node page.
I have tried with smart_date_recur version 4.0.3.
Can you tell me what issue you see in front end?

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

Vivek Panicker โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

Seems some conflict with your existing configurations.

I installed the module on a Drupal 9.5 site and checked this.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

Can you ping me in Drupal Slack?
My name is Vivek Panicker.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

Followed the Drupal recommentations here and modified the previous patch.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

Please provide more details on how to reproduce the issue.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

Nice info!
Thanks for sharing!

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

@slogar32 Hi!
It seems neither me or @ankithashetty received any credit for this :|

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

I have updated the patch for D10.
Request everyone to review it once.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

This is not an issue of this module.
It is requiring some package which is not in fully stable version.

When working on a project, we encounter many such packages which have dev stability version.

So we have no option but to set "dev" stability version.

Closing this ticket as this is not module related.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

I think we should be raising PR against 2.1.0 branch.
Instead of 2.0 branch.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

@chancenyasulu I see the it written as

{@inheritDoc }<code> in your code.
An extra space seems to have crept in.
Can you please fix that to <code>{@inheritDoc}

and run phpcs again?

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

@chancenyasulu I checked this.

In SortPluginBase class, we have the query method defined.

`Length` class extends SortPluginBase class and overrides its `query()`.

So adding `{@inheritDoc}` on the function docblock does not cause any error.

Even VSCode โ†’ is not showing any error.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

Vivek Panicker โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

@alok_singh I am talking about core_version_requirement key.
It's already there in the latest 2.1.0 branch.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

I think doing a forceful redirection should be avioided.
So I updated the patch and added a link in the error message so that user can click on it and navigate to the configuration page.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

Tested on local.
The changes look good.

Just left 2 minor comments in the MR regarding the code comments.

Rest is good to merge.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

@chancenyasulu Please review the MR.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

Vivek Panicker โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

@admirlju Changes look good.

I applied the patch, followed your instructions and created the content.
When I edit the particular media I see the following:

It looks a bit out of place since it appears in the bottom of the page below the save button.
Can we fix that?

Also shouldn't we document the steps in the README file?

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

@chancenyasulu are you working on it?
Or can I pick this up?

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

Created a patch to fix the above issues.

Not sure if that is enough or an MR is required.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

Vivek Panicker โ†’ created an issue.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

The issue can be reproduced in the following way:
- Embed content A inside content B
- Delete content A
- Edit content B
- Now click on edit button for embedded content.
- See the error mentioned in the issue description in the log.

I applied the patch and checked.

We see the same popup that we see when we click on the embed button.


๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

However under what situation are we arriving at this condition?

I created a node, embedded it in an article page, then deleted the node.

When I load the article page I see this:

Code gets stopeed here:

In the error logs I get a proper log:

  2    20/Nov 14:06   entity_embed   Error      Drupal\entity_embed\Exception\EntityNotFoundException: Unable to load embedded node entity 593344e1-23fc-4524-8a8e-aadefe70f43a. in Drupal\entity_embed\Plugin\Filter\EntityEmbedFilter->process() (line 174  
                                                of /app/web/modules/contrib/entity_embed/src/Plugin/Filter/EntityEmbedFilter.php).                                                                                                                            

So we would need some steps to reproduce the issue first.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

@murphy @shelane After using this patch in my local site, I am facing an issue.
Patch used: https://www.drupal.org/files/issues/2023-07-25/quicktabs-js-fix_0.patch โ†’

I am using an AJAX quicktab.

After applying the patch, the default quicktab is not selected after page reload.
Whatever was the last tab the user clicked on, that persists after page reload.

The last clicked and the first quicktab both are loaded, thus causing issues in my project.

I request you to kindly check scenario.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

Thanks for the explanation @simonbaese.

@kaszarobert I think we should have an issue then to properly apply depdendency injection in the class files.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

Nice spot there @simonbaese.

I got inspiration from your idea to create this patch.

@sandipta please review this patch since it is not tested and see if it helps resolve your issue.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

@cliefen We checked again thoroughly, and actually the role is not getting deleted, it is just getting updated.

Orignally when @vishal mentioned about the role getting deleted, that was because we were trying out some random stuff in code, which must have corrupted the data.

So there's actually no issue and we're good to close this ticket.

Thanks for your time everyone and apologies for any inconvenience caused.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

@cliefen The code necessary to reproduce the issue has already been posted by @vishal.

It's as simple as creating a module with defines a permisison, assigning that permission to a user role and then trying to uninstall the module.

At that point, we see the issue as shown in the screenshot. The user role seems to be getting deleted.

And this is also reproducible when we try to uninstall any contrib module which provides permissions.

The Drupal version used here is 10.4.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vivek Panicker Kolkata

Thank you @jaypan for the clear explanation!

Production build https://api.contrib.social 0.62.1