- Issue created by @Vivek Panicker
- Merge request !3Issue #3507760: Added condition to check for url. → (Open) created by Vivek Panicker
- 🇮🇳India prashant.c Dharamshala
Thanks for the fix @vivek panicker I faced the same issue and applying the changes fixed it for me on Drupal 11.x.
However getting
$url
always emptyhttps://git.drupalcode.org/project/ai_seo/-/merge_requests/3/diffs#529cdd96345bf7dcbbce6cbd38ccb30984c74ed4_232_229
, maybe we could create another issue to address the URL not generating part. - 🇮🇳India Vivek Panicker Kolkata
@prashant.c I do see an instance where we are passing $url.
So I don't think that can be removed now.
Also if the current patch is working for you, can you help move the issue to RTBC please?
- 🇩🇪Germany a.dmitriiev
Method
analyzeHtml
allows$url
as NULL. So it is reasonable to check the variable before using it. And the othersaveReport
method that is executed with this variable also allows it to be NULL. So, I think the MR should be merged. RTBC. - 🇩🇪Germany a.dmitriiev
Uploading the patch, so that it can be easily used in composer projects.
- 🇩🇪Germany a.dmitriiev
I think as this issue prevents module features from being used, the priority should be raised to "Major", maybe even to "Critical" at some point.