Contrib.social

Automated Drupal 11 compatibility fixes for advagg

Open on Drupal.org →
Created on 16 March 2024, 12 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Needs review

Version

6.0

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @project update bot
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
    last update 12 months ago
    54 pass
  • Comment 12 months ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

    Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

    Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug info

    Bot run #11-120768

    This patch was created using these packages:

    1. drupal/upgrade_status: 4.1.0
    2. mglaman/phpstan-drupal: 1.2.7
    3. palantirnet/drupal-rector: 0.20.1
  • Merge request !39Automated Project Update Bot fixes → (Open) created by project update bot
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
    last update 12 months ago
    54 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
    last update 11 months ago
    54 pass
  • Comment 11 months ago →
    project update bot

    This comment was forced and has ignored the check if a change was already posted. This is only done when we want to update the issue without waiting for changes to happen.

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

    Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

    Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

    The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-137198

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.1.0
    2. mglaman/phpstan-drupal: 1.2.10
    3. palantirnet/drupal-rector: 0.20.1
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
    last update 9 months ago
    54 pass
  • Comment 9 months ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

    Currently Drupal Rector, version 0.20.2, cannot fix all Drupal 11 compatibility problems.

    Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

    The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-188138

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.3.2
    2. mglaman/phpstan-drupal: 1.2.11
    3. palantirnet/drupal-rector: 0.20.2
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
    last update 9 months ago
    54 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
    last update 9 months ago
    54 pass
  • Comment 9 months ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

    Currently Drupal Rector, version 0.20.3, cannot fix all Drupal 11 compatibility problems.

    Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

    The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-199781

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.3.2
    2. mglaman/phpstan-drupal: 1.2.11
    3. palantirnet/drupal-rector: 0.20.3
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
    last update 9 months ago
    54 pass
  • Comment 7 months ago →
    mattbloomfield

    I noticed these patches didn't patch the info.yml files in the module, so I'm attaching one that rerolls the latest patch while also patching the info.yml files. Please disregard if not useful.

  • Comment 7 months ago →
    mattbloomfield

    So I forgot to include the main info.yml file in the patch. Here's a better version.

  • Status changed to Needs work 6 months ago
  • Comment 6 months ago →
    🇮🇳India zeeshan_khan

    I tried to apply #8 patch got following errors.

    git apply --check advagg-d11-2.patch
    error: patch failed: advagg.info.yml:1
    error: advagg.info.yml: patch does not apply
    error: patch failed: advagg_bundler/advagg_bundler.info.yml:1
    error: advagg_bundler/advagg_bundler.info.yml: patch does not apply
    error: patch failed: advagg_cdn/advagg_cdn.info.yml:1
    error: advagg_cdn/advagg_cdn.info.yml: patch does not apply
    error: patch failed: advagg_css_minify/advagg_css_minify.info.yml:1
    error: advagg_css_minify/advagg_css_minify.info.yml: patch does not apply
    error: patch failed: advagg_ext_minify/advagg_ext_minify.info.yml:1
    error: advagg_ext_minify/advagg_ext_minify.info.yml: patch does not apply
    error: patch failed: advagg_js_minify/advagg_js_minify.info.yml:1
    error: advagg_js_minify/advagg_js_minify.info.yml: patch does not apply
    error: patch failed: advagg_mod/advagg_mod.info.yml:1
    error: advagg_mod/advagg_mod.info.yml: patch does not apply
    error: patch failed: advagg_old_ie_compatibility/advagg_old_ie_compatibility.info.yml:1
    error: advagg_old_ie_compatibility/advagg_old_ie_compatibility.info.yml: patch does not apply
    error: patch failed: advagg_validator/advagg_validator.info.yml:1
    error: advagg_validator/advagg_validator.info.yml: patch does not apply

  • First commit to issue fork.
  • Comment 4 months ago →
    🇫🇷France dydave

    Comment #9 shouldn't prevent this issue from being reviewed.

    Please use merge request MR!39 applied to
    6.0.x-dev.

    Switching back to Needs review.

    Thanks!

  • Comment 4 months ago →
    🇮🇳India ajitdalal

    ajit dalal → made their first commit to this issue’s fork.

  • Merge request !43Drupal 11 compatibility → (Open) created by Unnamed author
  • Comment 4 months ago →
    gaurav gupta Jaipur, Rajasthsan

    gaurav gupta → made their first commit to this issue’s fork.

  • Comment 4 months ago →
    gaurav gupta Jaipur, Rajasthsan

    Hello all ,
    Applied MR!39 and patch #8 and was getting the error so add a commit in MR!39.
    Please check.

  • Merge request !44Drupal 11 compatibility → (Open) created by Unnamed author
  • Status changed to Needs review 4 months ago
  • Comment 4 months ago →
    🇮🇳India ajitdalal

    ajit dalal → changed the visibility of the branch 3428774-d11-ready to hidden.

  • Comment 4 months ago →
    🇮🇳India anmolgoyal74

    After Updating getting this error =>
    Uncaught PHP Exception TypeError: "Drupal\advagg\Asset\CssOptimizer::__construct(): Argument #2 ($event_dispatcher) must be of type Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher, Symfony\Component\EventDispatcher\EventDispatcher given, called in /docroot/core/lib/Drupal/Component/DependencyInjection/Container.php on line 259"

  • Comment 3 months ago →
    🇮🇳India rahul1707

    Verified MR !43 in Drupal 10 and Drupal 11, functionality is working fine and module is compatible with Drupal 11.

  • Comment 3 months ago →
    heddn Nicaragua

    Chatted w/ @nickdickinsonwilde today in Slack. See https://drupal.slack.com/archives/C1BMUQ9U6/p1733936073358429. This will likely get marked won't fixed in the next few days. Feel free to remove the module from your install and use Drupal core's aggregation directly.

  • Comment 2 months ago →
    🇫🇷France dydave

    Thanks Lucas! (@heddn)

    Chatted w/ @nickdickinsonwilde today in Slack. See https://drupal.slack.com/archives/C1BMUQ9U6/p1733936073358429. This will likely get marked won't fixed in the next few days. Feel free to remove the module from your install and use Drupal core's aggregation directly.

    Are you saying the module is getting deprecated and could be removed as of D11?
    Did the module's features get integrated into D11 Core?

    Is there any recommended documentation on how to switch over module's configuration to Core's?

    Any help would be greatly appreciated!
    Thanks in advance!

  • Comment 2 months ago →
    heddn Nicaragua

    The changes to drupal core were actually added in 10.1. You don't need to do anything except uninstall advagg.

  • Comment 2 months ago →
    sd123

    I hope static gzip and brotli files support is then added soon to D11 Core as that is one feature that is still missing.

    Is it already possible to define a target number of CSS and JS bundles per page, with file size as grouping logic?

  • Comment 13 days ago →
    🇮🇳India Vivek Panicker Kolkata

    Hi @maintainers! Is there any chance this is going to get merged soon?

  • Comment 13 days ago →
    🇫🇷France dydave

    @vivek panicker: See comment above at #22 and #23:

    From what I have understood: Development for this module will be discontinued in Drupal 11, since the features have been integrated into Drupal Core.

    We uninstalled the module on all projects for D11 and moved to using Core features.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024