🇮🇳India @zeeshan_khan

@josephgut - Can you verify now if its working for you?

Thanks you for the fix.

Looks Good to me!

LGTM!

LGTM!

LGTM! - Thanks

Looks Good to me!

Looks good to me!

I tried to apply #8 patch got following errors.

git apply --check advagg-d11-2.patch
error: patch failed: advagg.info.yml:1
error: advagg.info.yml: patch does not apply
error: patch failed: advagg_bundler/advagg_bundler.info.yml:1
error: advagg_bundler/advagg_bundler.info.yml: patch does not apply
error: patch failed: advagg_cdn/advagg_cdn.info.yml:1
error: advagg_cdn/advagg_cdn.info.yml: patch does not apply
error: patch failed: advagg_css_minify/advagg_css_minify.info.yml:1
error: advagg_css_minify/advagg_css_minify.info.yml: patch does not apply
error: patch failed: advagg_ext_minify/advagg_ext_minify.info.yml:1
error: advagg_ext_minify/advagg_ext_minify.info.yml: patch does not apply
error: patch failed: advagg_js_minify/advagg_js_minify.info.yml:1
error: advagg_js_minify/advagg_js_minify.info.yml: patch does not apply
error: patch failed: advagg_mod/advagg_mod.info.yml:1
error: advagg_mod/advagg_mod.info.yml: patch does not apply
error: patch failed: advagg_old_ie_compatibility/advagg_old_ie_compatibility.info.yml:1
error: advagg_old_ie_compatibility/advagg_old_ie_compatibility.info.yml: patch does not apply
error: patch failed: advagg_validator/advagg_validator.info.yml:1
error: advagg_validator/advagg_validator.info.yml: patch does not apply

@benstallings - You have added "Related issues: #3465786: Add support for Drupal 11" this one is for tailwindcss project not for encrypt so I am opening it again.
Please correct me if I'm wrong.

Thank you @jaydeep_patel - Looks good now!

@bunty oberoi - @adarshv MR has only css changes but theme is using scss need to convert the styles to scss.

Thanks All for your contributions!

@esha_kundu - Agreed! - PR is merged!
Thanks

@esha_kundu - Thank you for the fixes everythings looks good to me however your merge request has a conflict that needs to be fixed in order to merge the PR.

Thanks @esha_kundu

Need to convert the fix into scss

@adarshv MR 14 - Looks Good to me thanks for the fix.

@maxilein - Yes, Either you choose create a proper field of this module or you can use its display widget for core number field it works in both ways.

Manual Test
I did a manual test on your patch I think you're creating a patch with older branch please check the "1.0.x" it already has all the PHPcs fixes.

@radheymkumar - Thank you for adding support by color field.
Manual Test
I did manual test on your patch and its working absolutely fine.

@atul_ghate - Thanks for fixing those issues However, I tried to test the patch but its not getting apply giving such errors.

This one fixes the problem for me.

Created patch for the issue.

.tabs ul.primary li a {
    border: unset!important;
  }

Can we not use !important as its not a good practice and may have dangerous impact on other components in component base structure.

Looks Good to me Thanks for fixing that.

This one looks ok to me Thanks for fixing that.

@alok - Same issue here your MR has all other commits.
Need to rebase and keep the commit only related to this issue

@alok - Same issue here your MR has all other commits.
Need to rebase and keep the commit only related to this issue

@alok - Same issue here your MR has all other commits.
Need to rebase and keep the commit only related to this issue

@alok - Thanks for fixing these issues. However your merge request is showing multiple commits some are not related to the scope of this issue.
Can you rebase it and raise MR again with the fix related to this issue only?

Also whole logic of increasing the number of slides is failing.
And Please provide steps to reproduce the issue

theme_get_setting('no_of_slide') == '' ? '5' : theme_get_setting('no_of_slide') Instead of using direct function try to inject service wherever possible.

$theme_handler = \Drupal::service('theme_handler');

// Get a setting from 'creative_innovative' theme.
$logo = $theme_handler->getThemeSetting('no_of_slide', 'creative_innovative');

Something like that.
Thanks

@weseze - Please provide interdiff
Also we need a re-roll for 11.x

@smustgrave - sure thanks :)

Thanks for fixing this issue.
I needed this fix for D10.1.8 so I have re-rolled it as patch.

Solution:
After digging it a lot I came up with a solution that after upgrade this module needs manual re-install we need to uninstall the module and the re-install it after that we need to include the linkit filter plugin in ckEditor.

Hope this information will help someone!
:)

zeeshan_khan → created an issue.

zeeshan_khan → created an issue.

@ion.macaria - Can you provide interdiff from #30 as it looks same to me.
Also we still need test case for this as mentioned by @smustgrave in #23
Also we need to update the code as suggested in #28 by @smustgrave I agree that using empty() check in this kind situation can cause deeper problems.

Do we have any possible solution for this??
This issue starts occurring after upgrade from Drupal 9 to Drupal 10. its not easily reproducible, However if we do lots of content entries it occurs but not every time.

For Mobile Detect issue please check if the module is upgraded to latest version 3.0.6

Rerolled patch for 10.1.x, I needed this for very important project.

zeeshan_khan → made their first commit to this issue’s fork.

I have added a check to confirm only check latest_version_tab if its available.

zeeshan_khan → created an issue.

zeeshan_khan → created an issue.

zeeshan_khan → created an issue.

Looks like #9 has also passed the PHP test now. Moving back to RTBC.

@smustgrave I am just checking with latest rebase why it was failing and getting back to Needs work. Because #9 looks absolutely fine and works perfectly.

Hi @coaston,
Current version of the module works with view modes. In order to work with views you'll have to choose content and display mode in Format section. I am attaching the SS for your reference.

@coaston - Can you provide more details how can we reproduce the issue you mention?

Above mentioned patch is not working from composer so updated patch to work with composer install.

@arpitk - Thanks for the patch!
Manually tested code works fine.

Patch works fine

@Akram Khan - doesn't seem to be relevant

Please fix this \ No newline at end of file in static_server.routing.yml

@dineshkumarbollu - Thanks for the work!

@dineshkumarbollu - everything seems to be fine accept one. Can you resolve this one \ No newline at end of file Thanks

Thanks @arpitk - Patch works absolutely fine.

Thanks @arpitk - for the fix and Thanks @clarkssquared - for the review.

Patch works fine.

https://www.drupal.org/project/creative_innovative/releases/9.0.0 →
checkout this release @arti_parmar

@sonam_sharma - issue summary is not descriptive kindly update how to reproduce the issue.

@arti_parmar - "Irrelevant" Did check project detailes?
latest released 9.1.x already is compatible with d10.

P.S Kindly install and test the project in actual scenario before creating issues
Thanks

error: patch failed: creative_innovative.theme:209
error: creative_innovative.theme: patch does not apply

Your patch doesn't apply

Manual Review!
@sonam_sharma - I did a quick review of your patch I am getting this error.

error: git diff header lacks filename information when removing 1 leading pathname component (line 5)

@sonam_sharma - Wondering status should be Needs review or Patch (to be ported)?

@maxilein - Thanks for creating the issue.
#1 - Its a field type
#2 - Its takes the field value as a percentage. e.g, - this field will allow you enter values from 1 to 100 and then it will show that value as percentage.

Thanks everyone for valuable feedbacks
@apaderno - https://www.drupal.org/project/projectapplications/issues/3366634 → I have created new issue for the review. Thanks