- Issue created by @shweta__sharma
- @shweta__sharma opened merge request.
- Status changed to Needs review
over 1 year ago 11:27am 1 August 2023 - Assigned to jay jangid
- Issue was unassigned.
- 🇮🇳India jay jangid Jaipur
Hello @shweta__sharma I verified the MR4 on Drupal !0.1.x and it's working.
Sharing the screenshots for reference.
Only getting this warning on applying it:-<stdin>:15: trailing whitespace. warning: 1 line adds whitespace errors.
Thanks.
- Status changed to Needs work
11 months ago 6:26pm 29 February 2024 - 🇮🇳India zeeshan_khan
.tabs ul.primary li a { border: unset!important; }
Can we not use !important as its not a good practice and may have dangerous impact on other components in component base structure.
- Assigned to Esha_Kundu
- Merge request !22Issue #3378208: Tabs dropdown button styling does not look good on mobile view → (Merged) created by Esha_Kundu
- Status changed to Needs review
5 months ago 10:59am 19 August 2024 Hello,
I installed the theme version 9.1.0 on Drupal version 10.3.2, the mentioned issue existed so I applied the MR!4 but got patch fail error. Updating the version for this issue. As per the comment by @zeeshan_khan, I have made changes and created MR!22. I also noticed that the dropdown arrow remained facing downward even when the menu list is expanded, according to me this is a design issue that can be solved here as well. I have addressed this and made the arrow face upward whenever the menu list is expanded.
Added ss and short clip for reference. Please review.
Thanks- Status changed to Needs work
5 months ago 3:45pm 19 August 2024 - 🇮🇳India zeeshan_khan
@esha_kundu - Thank you for the fixes everythings looks good to me however your merge request has a conflict that needs to be fixed in order to merge the PR.
- Issue was unassigned.
- Status changed to Needs review
5 months ago 4:28am 20 August 2024 Hi @zeeshan_khan,
I've resolved the conflicts, please check.
Thanks- Status changed to Needs work
5 months ago 6:57am 20 August 2024 - 🇮🇳India Kanchan Bhogade
Hi @esha_kundu
I have reproduced the issue on Drupal 10.3.1 with the theme version 9.01.
But MR 22 is failing
Attaching Screenshot for reference - Status changed to Needs review
5 months ago 7:56am 20 August 2024 Hi @Kanchan Bhogade,
As per the screenshot that you have provided I find the MR!22 failed at your end because you have been checking it in 9.1.0 version which is a tag consisting of previous changes. I think if you clone the project and checkout the current development branch 9.1.x, followed by applying the patch then this patch application error would be resolved.
Thanksesha_kundu → changed the visibility of the branch 3391588-readmore-button to hidden.
-
zeeshan_khan →
committed fca1c148 on 9.1.x authored by
esha_kundu →
Issue #3378208: Tabs dropdown button styling does not look good on...
-
zeeshan_khan →
committed fca1c148 on 9.1.x authored by
esha_kundu →
- Status changed to RTBC
5 months ago 2:49pm 20 August 2024 - Status changed to Fixed
5 months ago 2:50pm 20 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.