- Issue created by @mrit4406
- Status changed to Needs review
12 months ago 8:38am 22 November 2023 - 🇮🇳India SandeepSingh199
@mrit4406, I have removed that NO Of Slide: dropdown with textbox, now you can set as much as slider you want.
Thanks @SandeepSingh199 for your support! can you guide me how to include this patch file in site ?
- 🇮🇳India SandeepSingh199
sure.
Steps to merge the patch :-
1. Hope You have alreay downloaded the Creative & Innovative theme using composer, if not yet then run composer require 'drupal/creative_innovative:^9.1' on CLI.
2. Move to creative_innovative theme folder (e.g. cd themes/contrib/creative_innovative)
3. Download the patch using wget (e.g. wget https://www.drupal.org/files/issues/2023-11-22/3403068-4.patch → )
5. Finally apply the patch (e.g. git apply -v 3403068-1.patch) Thanks for your guide @SandeepSingh199 bhai. Is there any other way to do that or can I modify any theme file because I'm facing difficulty in applying patch file. I think there is path issue but I tried all the way, still couldn't applied.
$ git apply -v 3403068-1.patch
error: git diff header lacks filename information when removing 1 leading pathname component (line 5)- 🇮🇳India SandeepSingh199
@mrit4406, If you facing difficulty while applying patch, you can add manually in your theme file.
- Status changed to Needs work
9 months ago 6:10pm 29 February 2024 - 🇮🇳India zeeshan_khan
theme_get_setting('no_of_slide') == '' ? '5' : theme_get_setting('no_of_slide')
Instead of using direct function try to inject service wherever possible.$theme_handler = \Drupal::service('theme_handler'); // Get a setting from 'creative_innovative' theme. $logo = $theme_handler->getThemeSetting('no_of_slide', 'creative_innovative');
Something like that.
Thanks - 🇮🇳India zeeshan_khan
Also whole logic of increasing the number of slides is failing.
And Please provide steps to reproduce the issue