- Issue created by @pp
- last update
about 1 year ago 30,136 pass, 3 fail - last update
about 1 year ago 30,136 pass, 3 fail The last submitted patch, 3: 3388941-skip-arguments.patch, failed testing. View results →
- Status changed to Needs work
about 1 year ago 7:07pm 21 September 2023 - last update
about 1 year ago 30,165 pass, 2 fail - ðŸ‡ðŸ‡ºHungary pp
Found a problem: https://www.drupal.org/node/2452659 →
The real problem is try to render taxonomy/term/%/feed link when argument is not present. The argument is necessary because % in the base url. The real solution will be that deny preview in views_ui when (one of ) necessary arguments are missing.This is a working but not perfect solution.
- last update
about 1 year ago 30,139 pass, 2 fail - Status changed to Needs review
about 1 year ago 5:00am 22 September 2023 - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago 30,168 pass - ðŸ‡ðŸ‡ºHungary pp
This patch deny preview if necessary arguments are missing.
- 🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin
@zeeshan_khan I m confused: your patch seem not to add/correct relevant parts to the issue and adds grammar and Uppercase and sentence period comment corrections on other spots. It was surely by accident? So let me remove/hide it from the issue summary. Feel free to re-add it if I am mistaken.
- Status changed to Needs work
about 1 year ago 1:31pm 22 September 2023 - 🇺🇸United States smustgrave
Not sure this can just be removed. Can see from earlier patches it failed some tests, so shows it was setup by design. Think it will need a way to maintain existing functionality + add the new.
- Status changed to Needs review
9 months ago 9:31am 13 February 2024 - ðŸ‡ðŸ‡ºHungary pp
I did not enough time for create environment, where I can run tests. The first patch is for run all test only.
- Status changed to Needs work
9 months ago 4:14pm 14 February 2024 - First commit to issue fork.
- Merge request !6673issue:3388941 Skip remaining arguments if an empty exception found → (Open) created by shalini_jha
- Status changed to Needs review
9 months ago 1:05pm 19 February 2024 - 🇮🇳India shalini_jha
I have tested this patch and its working.
when i only pass the tid then the URL is skip the empty argument . so i have added a MR for this.
before patch url : /test/17/%2A/%2A
Afterpatch url: /test/17
Output is same for both. - Status changed to RTBC
9 months ago 6:47pm 23 February 2024 - 🇺🇸United States smustgrave
Used git blame all the way back to contrib day https://git.drupalcode.org/project/drupal/-/blob/5259e3b9eddb50f5b0cb604...
Original code seemed to be a placeholder
$pieces[] = '*'; // gotta put something if there just isn't one.
So think updating makes sense
- Status changed to Needs work
9 months ago 11:00am 5 March 2024 - 🇬🇧United Kingdom catch
This seems like it could add test coverage for the use-case in the issue summary.