Refactor Claro's card stylesheet

Believe this is postponed via our conversation a few weeks ago @ckrina. For the followup and a path forward

@smustgrave I think, it should be comitted on github. Can you say why it was postponed please ?

patch needed for 11.x

I have updated all the logical properties, attached patch for 11.x-dev. please review

working on it

I have tested patch #9, and it applied cleanly without any issues. The nesting and logical properties of the code changes appear to good to me. Nothing is appearing broken, for reference attaching the screenshot.

RTBC + 1

@Gauravvvv - I just want clarification in this code block for my better understanding. why didn't you use padding-inline shrothand instead of padding-inline-start as I see padding-right and padding-left both are present.
Rest everything seems good to me Thanks

  /* Card content with image. */ 
   .card--horizontal .card__image ~ .card__content-wrapper {
-    padding-left: var(--space-m);
-  }
-  [dir="rtl"] .card--horizontal .card__image ~ .card__content-wrapper {
-    padding-right: var(--space-m);
-    padding-left: var(--space-l);
+    padding-inline-start: var(--space-m);
   }
 }

Follow up is no longer needed and screenshots added in #11

The last submitted patch, 9: 3303543-9.patch, failed testing. View results →

Unrelated failure, restoring status.

The last submitted patch, 9: 3303543-9.patch, failed testing. View results →

@zeeshan_khan can you provide an interdiff of what’s different from #9. From what I can tell #9 still applies cleanly to 11.x and failure was probably unrelated.

@smustgrave I am just checking with latest rebase why it was failing and getting back to Needs work. Because #9 looks absolutely fine and works perfectly.

Looks like #9 has also passed the PHP test now. Moving back to RTBC.

Since #17 was reupload going to hide that one.

Committed 6985e23 and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.