Account created on 29 January 2018, over 6 years ago
#

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia anmolgoyal74

This project needs work right now. Hence merging it for now. I will correct it, if required in the later releases.

๐Ÿ‡ฎ๐Ÿ‡ณIndia anmolgoyal74

Thanks @apaderno
The contributor roles added by these users are still getting reflected in our profiles. Can that also be updated?

๐Ÿ‡ฎ๐Ÿ‡ณIndia anmolgoyal74

Fixed. Pushed to 8.x-1.x
Thanks.

๐Ÿ‡ฎ๐Ÿ‡ณIndia anmolgoyal74

Remove core key.

๐Ÿ‡ฎ๐Ÿ‡ณIndia anmolgoyal74

It should be TYPE_TRANSFORM_REVERSIBLE.

๐Ÿ‡ฎ๐Ÿ‡ณIndia anmolgoyal74

Closing since other issue is fixed.
https://www.drupal.org/project/nofollowlist/issues/3369571 ๐Ÿ“Œ Automated Drupal 10 compatibility fixes Fixed

๐Ÿ‡ฎ๐Ÿ‡ณIndia anmolgoyal74

Not requried since https://www.drupal.org/project/cleantaxonomy/issues/3336068 ๐Ÿ“Œ Update README.md file according to "README.md template" Fixed

๐Ÿ‡ฎ๐Ÿ‡ณIndia anmolgoyal74

anmolgoyal74 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia anmolgoyal74

Fixed. Push to 2.0.x.
Thanks.

๐Ÿ‡ฎ๐Ÿ‡ณIndia anmolgoyal74

Re-rolled #214 for 9.2.x. And also updated one of the failing tests.
Not able to generate the interdiff.
Here is the diff for the test.

diff --git a/core/tests/Drupal/FunctionalTests/Entity/ContentEntityFormFieldValidationFilteringTest.php b/core/tests/Drupal/FunctionalTests/Entity/ContentEntityFormFieldValidationFilteringTest.php
index 7bbcd1b27f..f5e7faa450 100644
--- a/core/tests/Drupal/FunctionalTests/Entity/ContentEntityFormFieldValidationFilteringTest.php
+++ b/core/tests/Drupal/FunctionalTests/Entity/ContentEntityFormFieldValidationFilteringTest.php
@@ -135,9 +135,8 @@ public function testFieldWidgetsWithLimitedValidationErrors() {
     // The 'Test multiple' field is the only multi-valued field in the form, so
     // try to add a new item for it. This tests the '#limit_validation_errors'
     // property set by \Drupal\Core\Field\WidgetBase::formMultipleElements().
+    $this->submitForm([], 'Add item');
     $assert_session->elementsCount('css', 'div#edit-test-multiple-wrapper div.form-type-textfield input', 1);
-    $this->submitForm([], 'Add another item');
-    $assert_session->elementsCount('css', 'div#edit-test-multiple-wrapper div.form-type-textfield input', 2);
 
     // Now try to upload a file. This tests the '#limit_validation_errors'
     // property set by
@@ -150,20 +149,19 @@ public function testFieldWidgetsWithLimitedValidationErrors() {
     $this->submitForm($edit, 'Upload');
     $assert_session->elementExists('css', 'input#edit-test-file-0-remove-button');
 
-    // Make the 'Test multiple' field required and check that adding another
-    // item throws a validation error.
+    // Make the 'Test multiple' field required and check saving the form
+    // without entering any value for the required field still throws the
+    // proper validation errors.
     $field_config = FieldConfig::loadByName($this->entityTypeId, $this->entityTypeId, $this->fieldNameMultiple);
     $field_config->setRequired(TRUE);
     $field_config->save();
 
-    $this->drupalPostForm($this->entityTypeId . '/add', [], 'Add another item');
-    $assert_session->pageTextContains('Test multiple (value 1) field is required.');
+    $this->drupalGet($this->entityTypeId . '/add');
 
     // Check that saving the form without entering any value for the required
     // field still throws the proper validation errors.
     $this->submitForm([], 'Save');
-    $assert_session->pageTextContains('Test single field is required.');
-    $assert_session->pageTextContains('Test multiple (value 1) field is required.');
+    $assert_session->pageTextContains('This value should not be null.');
   }
 
 }
Production build 0.69.0 2024