🇮🇳India @anmolgoyal74

Used the former suggestion to keep the same label: "Display even if view has no result".
I did it as a part of contribution sprint at DrupalCon Singapore 2024.

I have re-rolled the patch and used OOP hooks to purge the field definitions. I did it as a part of contribution sprint at DrupalCon Singapore 2024.

anmolgoyal74 → made their first commit to this issue’s fork.

I think the CSS, JS and Images are allowed to be crawled. In D7, the modules, themes, profiles and misc directories are not not allowed to be crawled that's why it was add in robots.txt of D7. I think we can close this.

https://git.drupalcode.org/project/drupal/-/blob/7543eae758df91a217e6464...

anmolgoyal74 → made their first commit to this issue’s fork.

Patch naming is not correct.
Read this
https://www.drupal.org/docs/develop/git/using-git-to-contribute-to-drupal/working-with-patches/making-a-patch

benjifisher → credited anmolgoyal74 → .

MR need to be updated. It has extra changes from #2986255.

Thanks. Pushed to 8.2.x.

This need to go to 2.0.x as well.

Thanks. Pushed to 2.0.x

After Updating getting this error =>
Uncaught PHP Exception TypeError: "Drupal\advagg\Asset\CssOptimizer::__construct(): Argument #2 ($event_dispatcher) must be of type Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher, Symfony\Component\EventDispatcher\EventDispatcher given, called in /docroot/core/lib/Drupal/Component/DependencyInjection/Container.php on line 259"

Updated the target branch

Updated the target branch

Email Validator service should be added as a dependency injection.

anmolgoyal74 → created an issue.

Thanks. Pushed to 9.x-dev

anmolgoyal74 → made their first commit to this issue’s fork.

I tried the steps mentioned in #15, and it worked fine. The selected content is deleted and the user stays on the homepage.

benjifisher → credited anmolgoyal74 → .

benjifisher → credited anmolgoyal74 → .

I am also getting the same error on Drupal 10.2.4. But this error only comes when switching to the ImageMagick toolkit, not with GD.

image.settings:preview_image: core/modules/image/sample.png

This project needs work right now. Hence merging it for now. I will correct it, if required in the later releases.

Thanks @apaderno
The contributor roles added by these users are still getting reflected in our profiles. Can that also be updated?

benjifisher → credited anmolgoyal74 → .

benjifisher → credited anmolgoyal74 → .

benjifisher → credited anmolgoyal74 → .

anmolgoyal74 → created an issue.

Fixed. Pushed to 8.x-1.x
Thanks.

Fixed. Thanks

Remove core key.

It should be TYPE_TRANSFORM_REVERSIBLE.

Closing since other issue is fixed.
https://www.drupal.org/project/nofollowlist/issues/3369571 📌 Automated Drupal 10 compatibility fixes Fixed

Fixed.
Thanks

Pushed to 2.0.x.
Fixed.

Already fixed in https://www.drupal.org/project/cleantaxonomy/issues/3319389 →

Attended.

Not requried since https://www.drupal.org/project/cleantaxonomy/issues/3336068 📌 Update README.md file according to "README.md template" Fixed

Fixed

anmolgoyal74 → made their first commit to this issue’s fork.

Fixed. Push to 2.0.x.
Thanks.

smustgrave → credited anmolgoyal74 → .

chrisfromredfin → credited anmolgoyal74 → .

anmolgoyal74 → created an issue.

Fixed CS issue.

Re-rolled #214 for 9.2.x. And also updated one of the failing tests.
Not able to generate the interdiff.
Here is the diff for the test.

diff --git a/core/tests/Drupal/FunctionalTests/Entity/ContentEntityFormFieldValidationFilteringTest.php b/core/tests/Drupal/FunctionalTests/Entity/ContentEntityFormFieldValidationFilteringTest.php
index 7bbcd1b27f..f5e7faa450 100644
--- a/core/tests/Drupal/FunctionalTests/Entity/ContentEntityFormFieldValidationFilteringTest.php
+++ b/core/tests/Drupal/FunctionalTests/Entity/ContentEntityFormFieldValidationFilteringTest.php
@@ -135,9 +135,8 @@ public function testFieldWidgetsWithLimitedValidationErrors() {
     // The 'Test multiple' field is the only multi-valued field in the form, so
     // try to add a new item for it. This tests the '#limit_validation_errors'
     // property set by \Drupal\Core\Field\WidgetBase::formMultipleElements().
+    $this->submitForm([], 'Add item');
     $assert_session->elementsCount('css', 'div#edit-test-multiple-wrapper div.form-type-textfield input', 1);
-    $this->submitForm([], 'Add another item');
-    $assert_session->elementsCount('css', 'div#edit-test-multiple-wrapper div.form-type-textfield input', 2);
 
     // Now try to upload a file. This tests the '#limit_validation_errors'
     // property set by
@@ -150,20 +149,19 @@ public function testFieldWidgetsWithLimitedValidationErrors() {
     $this->submitForm($edit, 'Upload');
     $assert_session->elementExists('css', 'input#edit-test-file-0-remove-button');
 
-    // Make the 'Test multiple' field required and check that adding another
-    // item throws a validation error.
+    // Make the 'Test multiple' field required and check saving the form
+    // without entering any value for the required field still throws the
+    // proper validation errors.
     $field_config = FieldConfig::loadByName($this->entityTypeId, $this->entityTypeId, $this->fieldNameMultiple);
     $field_config->setRequired(TRUE);
     $field_config->save();
 
-    $this->drupalPostForm($this->entityTypeId . '/add', [], 'Add another item');
-    $assert_session->pageTextContains('Test multiple (value 1) field is required.');
+    $this->drupalGet($this->entityTypeId . '/add');
 
     // Check that saving the form without entering any value for the required
     // field still throws the proper validation errors.
     $this->submitForm([], 'Save');
-    $assert_session->pageTextContains('Test single field is required.');
-    $assert_session->pageTextContains('Test multiple (value 1) field is required.');
+    $assert_session->pageTextContains('This value should not be null.');
   }
 
 }