- Issue created by @benjifisher
- 🇩🇪Germany rkoller Nürnberg, Germany
I wanted to copy over the suggestion from last week about discussing the changes on the display modes that are already in combination with 📌 Allow user to add display modes from respective field UI's. Needs work that adds the ability for the user to add display modes directly.
And I wanted to add 📌 Make Description Field Labels Consistent Needs work . I've taken a brief look and noticed a few more inconsistency aside the plain field labels
- 🇫🇮Finland simohell
@laurii suggested this on Slack and I'm happy to have a go with this one
https://www.drupal.org/project/drupal/issues/3325551 ✨ Add "Disable image resize" setting to image fields Needs review - 🇬🇧United Kingdom AaronMcHale Edinburgh, Scotland
benjifisher → credited AaronMcHale → .
- 🇩🇪Germany rkoller Nürnberg, Germany
Left a comment on the issue: #2721727-51: Allow user to add display modes from respective field UI's. →
- 🇺🇸United States benjifisher Boston area
Here is the summary provided by the Zoom AI assistant. I have not edited it except for formatting. The section "Follow-Up on Open Issues" makes us look a little silly. And the general impression from this summary is that everything needs further discussion.
Modal Discussion and UI Suggestions.
There were issues with the audio and video setup at the beginning of the meeting, which caused some confusion. The meeting then proceeded to discuss issue 3, specifically the use of modals in field creation flow. Simo suggested that the radio buttons should be arranged vertically, in line with the web design system. Christina partially agreed with this suggestion, and Aaron suggested that the radio buttons should be replaced with links. However, there was concern that with the bugs now fixed, the issue might be committed soon, and there wouldn't be time to implement these suggestions.
Field Storage and Forms Improvement
Benji, Ralf, and Aaron discussed issues related to the field storage and field instance forms in their system. The team acknowledged an improvement in the system with the use of a modal window, but recognized room for further enhancement. They also discussed the accessibility of the system's dialogue modal, with Ralf pointing out a general issue with the model dialog for screen readers. Aaron suggested exploring the use of the native HTML dialog element as a potential solution. The team decided to mark this issue as related to a ten-year-old issue and leave the radio button aspect to a follow-up discussion. Simo added that there is an ongoing effort to replace the modal dialogue system.
Follow-Up on Open Issues
Benji, Ralf, Aaron, and Simo discussed an issue that needed further attention. Aaron expressed his willingness to work on the issue in a follow-up meeting. Benji then brought up an issue related to the previous discussion, which was tagged for follow-up by Ralf. Simo also shared an issue, but mistakenly provided the link for a different meeting. The team agreed to continue discussing these matters in a future meeting.
Disabling Image Resizing Beyond Max Dimensions
Simo proposed a new setting to allow users to disable image resizing beyond maximum dimensions. The team discussed the behavior of the current image resizing system and potential improvements to the user interface regarding checkboxes and help text. Aaron suggested a change to the default setting of the check box, which was met with concerns from Ralf about the visibility of the check box. Simo then suggested using radio buttons to allow users to choose between resizing and rejecting an image that is larger than the maximum allowed size, which was generally agreed upon by the team.
Default Resizing Behavior for Images
Benji, Simo, Aaron, and Ralf discussed the possibility of allowing resizing of images on fields by default. They deliberated on the potential impact on existing sites and agreed to target a new version for this change. Aaron emphasized that the default resizing behavior should remain unchanged for now. Simo expressed concerns about the quality loss when images are resized, and Ralf pointed out the need for a message indicating that resizing is disabled, which triggers the error. The team agreed to explore this further in future discussions.
System Permissions and Configuration Issues
Ralf, Simo, and Benji discussed potential issues with their system, particularly regarding user permissions and configuration. Benji proposed different error messages for users with varying permissions, while Ralf suggested looking into the ability for users to add display modes from their respective field labs. The team agreed to consider these suggestions, with the understanding that further discussion and exploration would be necessary.
Display and Content Modifications
Ralf discussed changes that have already been implemented, including modifications to the display, page, and content. He identified a few visible problems and other new changes. Ralf also introduced a new view mode, demonstrated how to add a description, and explained how to enable it for specific content types. Benji acknowledged the usefulness of the new modes and suggested that the link to the new view mode should be placed at the New View Mode page.
Modal Form Issues Discussed
Benji, Ralf, Simo, and Thomas discussed issues related to the use of a modal form for adding view modes on content. Benji proposed a new model that he believed would address some of these issues, but it was met with mixed opinions. Some team members, like Ralf and Thomas, voiced concerns about the inconsistent use of terminology and the need for a more contextually aware system. Another issue raised was the lack of immediate feedback when a required field was missed. The team decided to further investigate these problems and potentially create a new issue to address them.
Next Steps
• Ralf will post a comment on the issue.
- 🇩🇪Germany rkoller Nürnberg, Germany
For reference, created two issues for view/form mode pages:
🐛 The delete button on the Edit view mode modal has a too low color contrast Active
✨ Improve the readability of the view mode and form mode page Active - Status changed to RTBC
about 1 year ago 5:16pm 29 October 2023 - 🇩🇪Germany rkoller Nürnberg, Germany
and the link to the comment @simohell left on the other issue is: #3325551-82: Add "Disable image resize" setting to image fields → . is there anything else missing for the issue? comments are all done, the video got already published (i've added the link to the issue summary), and the transcript was created. i anything else missing?
- 🇺🇸United States benjifisher Boston area
@rkoller: Thanks for reviewing the status of this issue, and updating the list of active issues.
Just now, I left a comment on ✨ Use modals in field creation and field edit flow Needs work . Now all the comments are done.
I thought I had added the transcript and the link to the recording. The transcript is still TODO. As in
href="TODO"
. - 🇩🇪Germany rkoller Nürnberg, Germany
ohhh i just saw that there was a file with the date of the meeting listed in the issue summary and there was the comment with the text produced by the AI assistant - so i thought the transcripts were done. i havent hovered and checked the href for the transcript file. that was an oversight on my end.
- Status changed to Fixed
about 1 year ago 4:51pm 30 October 2023 - 🇺🇸United States benjifisher Boston area
These meeting issues are s little different from most issues. When I first create the issue (cloning it from the one for the previous week) I set the link text and leave the target as TODO.
The summary from the AI assistant is a new idea. I am not sure how useful it is.
A few weeks ago, I started using the "Remaining tasks" section from the standard issue template. Like the rest of the issue description, it gets copied over when I clone the issue. You can check that to see the status, assuming that I remember to update it.
I am uploading the rough transcript now, so this issue is done.
Automatically closed - issue fixed for 2 weeks with no activity.