- Issue created by @rkoller
- First commit to issue fork.
- @utkarsh_33 opened merge request.
- Status changed to Needs review
10 months ago 1:14pm 2 November 2023 - Status changed to RTBC
10 months ago 2:29pm 2 November 2023 - 🇺🇸United States smustgrave
Tested at various widths/breakpoints and columns remain even through out.
The solution
try to avoid large gaps
think could be it's own issue to fix across entire Drupal.
- Status changed to Needs work
10 months ago 12:42pm 6 November 2023 - 🇩🇪Germany rkoller Nürnberg, Germany
Thanks for working on this. I finally found time to test and write up a reply. I agree with @smustgrave in #9 ✨ Improve the readability of the view mode and form mode page Active that the larger gap issue should be tackled for core in general. But i think there are still a few aspects that should be covered within this issue imho:
1. The changes in the MR affect other pages as well. I've just noticed a regression on
/admin/modules/uninstall
while testing something for another issue:2. I wonder if it would make sense to set the column width for name narrower than the one for the description. that the name column is half or two third of the description column? because the odds are high that a name is usually shorter than a verbose description.
3. If you have a long name for a display mode the column extends. would there be an option to wrap a name instead of extending the column width? In german the odds are high that you get long words (one example from a legislative text: "Rindfleischetikettierungsüberwachungsaufgabenübertragungsgesetz" - it got removed after a few years but still just wanted to illustrate the possibility of the occurance of extra long words - cuz in my screenshot i've simply used a numeric sequence that eases counting)
I have added a custom css file that overrides the css of the generic table's css for the current page.I think editing the generic css file for tables makes it difficult to handle different layouts on different pages so i thought that this can be better approach.
We can have a discussion around some other approach , if someone has a better idea to handle these issues at a generic level.
Attaching the SS with the current changes applied.- Status changed to Needs review
10 months ago 9:24am 8 November 2023 - Status changed to RTBC
10 months ago 5:13pm 8 November 2023 - 🇺🇸United States smustgrave
Appears feedback has been addressed. I added black border to help see.
- 🇩🇪Germany rkoller Nürnberg, Germany
I've also taken a look at the latest changes and a +1 to RTBC from my end as well. Looks real good @utkarsh:33!
@smustgrave also a good idea adding a screenshot illustrating the new column width by adding visible borders to each table cell
- Status changed to Fixed
10 months ago 7:13am 15 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.