Boca Raton, FL
Account created on 11 May 2006, almost 18 years ago
  • Senior frontend developer at Phase2Β  …
#

Recent comments

πŸ‡ΊπŸ‡ΈUnited States shaal Boca Raton, FL

This patch fixes an edge case where file stage proxy + webp, doesn't allow checking the width of a public URI.

πŸ‡ΊπŸ‡ΈUnited States shaal Boca Raton, FL

And fixing a bug in my own previous patch...

πŸ‡ΊπŸ‡ΈUnited States shaal Boca Raton, FL

Fixing a couple of bugs found in previous patch

πŸ‡ΊπŸ‡ΈUnited States shaal Boca Raton, FL

shaal β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States shaal Boca Raton, FL

@drumm, thank you for your help with this.

Opening any Drupal project hosted on git.drupalcode.org in Gitpod establishes Gitpod authorization for the user.

To test this, I opened the following URL in my browser:

https://gitpod.io/#https://git.drupalcode.org/project/drupalpod

I clicked on the "Authorize" link, which opened a new window where I authorized Gitpod. After authorizing and refreshing the original URL, I was able to open the project in Gitpod.

However, when I tried pushing code back to Drupal, I received an error. Looking at the Gitpod permissions in https://gitpod.io/user/integrations, it seems the missing "write_repository" is likely the cause.
(As the screenshot shows, Gitpod currently only showing "read_user" and "read_org" permissions enabled. It does not seem possible to enable even the "read_repository" permission at this time.)

@drumm, could you please add the write_repository? That is the original intent of this issue.

πŸ‡ΊπŸ‡ΈUnited States shaal Boca Raton, FL

+1
@finnsky is doing fantastic work! thank you

πŸ‡ΊπŸ‡ΈUnited States shaal Boca Raton, FL

When styling anchor elements, it might be better to use the :link pseudo-class instead of styling the a element itself. The :link selector specifically targets anchors containing an href attribute, while avoiding styling anchor elements with just a name.

Using :link improves specificity and avoids inadvertently styling elements that aren't links.

Reference:
https://developer.mozilla.org/en-US/docs/Web/CSS/:link

πŸ‡ΊπŸ‡ΈUnited States shaal Boca Raton, FL

shaal β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States shaal Boca Raton, FL

There's a really nice technique to animate dropdowns using CSS grid.

πŸ‡ΊπŸ‡ΈUnited States shaal Boca Raton, FL
πŸ‡ΊπŸ‡ΈUnited States shaal Boca Raton, FL

Update gitpod info and added a link to gitpod CDE page

πŸ‡ΊπŸ‡ΈUnited States shaal Boca Raton, FL

I think using the CSS trick described here
https://www.youtube.com/watch?v=B_n4YONte5A

would achieve a smooth transition for any height (since the browser handles it).

For accessibility, the patch should include support for reduced-motion

@media (prefers-reduced-motion: no-preference) {
    .claro-details--accordion-item {
        transition: max-height 1s ease-in-out;
    }
}
πŸ‡ΊπŸ‡ΈUnited States shaal Boca Raton, FL

shaal β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States shaal Boca Raton, FL

I think the right side-panel is a separate issue, out of the scope of the code of same_page_preview itself.

In my opinion, most people would prefer using the real estate of the editing page for the live preview side by side, and deal with metadata somewhere else, probably at the bottom of that page.

πŸ‡ΊπŸ‡ΈUnited States shaal Boca Raton, FL

Here's an example of how same_page_preview side-by-side to editing form, using flex.
(Which will allow narrow screens to display the preview below the edit form)

πŸ‡ΊπŸ‡ΈUnited States shaal Boca Raton, FL

I gave a session on APCA and fluid typography

πŸ‡ΊπŸ‡ΈUnited States shaal Boca Raton, FL

Vue is the best. :)

It's easy to learn and it's easy to understand even for people who don't know Vue yet.

I saw this post #3145958: [META] Re-evaluate use of Backbone.js in core β†’ yesterday, and I thought - Vue could probably be a good replacement for whatever backbone was used for!

Production build https://api.contrib.social 0.61.6-2-g546bc20