- ๐ฎ๐ชIreland markconroy
Let's move this to the theme system queue if we still think it's worth pursuing. And remove some of the redundant issue tags.
- Status changed to Needs work
almost 2 years ago 9:47am 21 February 2023 - Status changed to Active
almost 2 years ago 9:50am 21 February 2023 - ๐ซ๐ฎFinland lauriii Finland
This would have to be done in Claro. Would be great to hear from the Claro designers what are their thoughts about this.
- Status changed to Needs review
over 1 year ago 2:22pm 10 May 2023 - last update
over 1 year ago 29,383 pass - ๐ฎ๐ณIndia gauravvvv Delhi, India
As the detail accordion icon have a transition, and the detail doesn't have. It's not smooth experience. Detail opens up without and transition and the icon take some time (transition) to rotate.
I have added a patch with same transition timings as per icon. please review
- Assigned to nilesh.k
- Issue was unassigned.
- Status changed to Needs work
over 1 year ago 5:56pm 17 May 2023 - ๐ฎ๐ณIndia shashwat-tiwari Bengaluru
I have reviewed #106 but I don't see any transition happening while expanding of details element.
- Status changed to Needs review
over 1 year ago 7:16pm 17 May 2023 - last update
over 1 year ago Custom Commands Failed - ๐ฎ๐ณIndia shashwat-tiwari Bengaluru
- last update
over 1 year ago 29,388 pass - ๐ฎ๐ณIndia shashwat-tiwari Bengaluru
Recreated the patch after fixing the error in test `order/properties-order`.
- Status changed to Needs work
over 1 year ago 3:12pm 18 May 2023 - ๐บ๐ธUnited States shaal Boca Raton, FL
I think using the CSS trick described here
https://www.youtube.com/watch?v=B_n4YONte5Awould achieve a smooth transition for any height (since the browser handles it).
For accessibility, the patch should include support for reduced-motion
@media (prefers-reduced-motion: no-preference) { .claro-details--accordion-item { transition: max-height 1s ease-in-out; } }
- ๐ฎ๐ณIndia shashwat-tiwari Bengaluru
The above suggested trick is not working with the current structure. To incorporate the change, we have to use generic accordion structure instead of since it has its own mechanism to show and hide the elements.
- Status changed to Needs review
over 1 year ago 8:31am 24 May 2023 - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 29,397 pass - last update
over 1 year ago Custom Commands Failed - ๐บ๐ธUnited States smustgrave
#113 has a trailing space issue but still applies to 11.x
- ๐ช๐ธSpain ckrina Barcelona
I'd love to see animation here:) But I'm a bit concerned with the max-height approach: have this been tried with longer content that exceeds these max-height defined? Like with the Metatags modules, where you can have really long forms inside the item. Or even custom items on the sidebar that jump into 3 lines (and take more than 90px)?
- Status changed to Needs work
over 1 year ago 7:29pm 31 May 2023 - ๐บ๐ธUnited States smustgrave
Just tested with metatags and it does cut off. So agree with @ckrina setting max-height doesn't seem the correct approach.
- ๐ฎ๐ณIndia hamid.ali
Hamid.ali โ made their first commit to this issueโs fork.
- ๐บ๐ธUnited States charles belov San Francisco, CA, US
The patch in #113 doesn't seem to respect ๐ฑ [policy, no patch] Use "prefers-reduced-motion" media query to disable animations Active . Is that now handled automatically by core, or is a change needed to the patch to agree with policy?