@sachin sure will review the MR and confirm
@cleavinjosh why you want to disable active link or button. It is good UI practise to show the active page with some different bg then the rest.
@sachin.addweb instead of patch kindly create a MR for the same.
Created the MR for the same. I am attaching the post-fix screenshot below. Also, there are some Phpcs errors can someone look into the same since these are not from my code?
Working on the issue.
Fixed the advanced search button spacing. Attaching a post-fix screenshot for the same kindly review.
Working on the issue
Fixed the breadcrumb spacing issue and created the MR for the same. I am attaching post-fix screenshot kindly review the same.
Fixed all the css related linting errors. Rest of the phpcs errors are coming from the template files.
Working on the phpc errors
Created the MR for the same. I am attaching post-fix screenshot below.
Have created the MR for the same. I am attaching post-fix screenshots below. Kindly review.
Updated the full and mini pager stylings. Attaching the post-fix screenshots below kindly review.
Created MR for the same. Attaching post-fix screenshot below.
working on the fix
Working on the fix.
Created the MR for the same. Also attaching post fix screenshots below kindly review.
Working on the issue
Created the MR for the same. Attaching the post-fix screenshot below.
Working on the issue
Created MR for the same. Adding post fix screenshots below.
Working on the issue.
Created the MR for the issue. Attaching the post-fix screenshot kindly review it.
Hamid.ali → made their first commit to this issue’s fork.
I created an MR and updated the mini pager stylings. Attaching postfix screenshot.
Created the MR for the same. Adding post fix screenshot below.
Working on the issue
Working on the issue
@bhaveshdas correct the test screenshots.
I created the MR for the same. I am adding a post-fix screenshot of the same below.
Created the MR for the same. Adding a post-fix screenshot of the same below.
Working on the issue
Working on the issue
Created an MR for the same. Attaching the post-fix screenshot.
Since its best practice to raise an MR rather than patch I Will raise an MR for the fix.
Reopening the issue as it still exists in the latest version 3.0.1. I am adding the screenshot. Also, I updated the issue summary to make the problem clearer.
Hamid.ali → created an issue.
Updated the issue summary.
@riddhi.addweb Have done assessment on my end sharing the results screen recording below.
Created the MR for the same. Attaching a fix screenshot below. Kindly review.
Working on the fix.
Hamid.ali → created an issue.
Created the MR for the fix. Attaching the post fix screenshot kindly review
Working on the fix
Hamid.ali → created an issue. See original summary → .
Created the MR for the following issue. Adding the screenshot below kindly review the same.
Working on the fix
Hamid.ali → created an issue.
Have created a MR for the mini pager stylings kindly review the same. Have attached the screenshot for the post fix.
Working on the fix
Hamid.ali → created an issue. See original summary → .
Hamid.ali → created an issue.
Hamid.ali → created an issue.
Create MR for the same. Attaching post fix screenshot below kindly review the same.
I made some updates for the active item styles.
Working on the fix.
Hamid.ali → created an issue.
I have created the MR for the fix. I am attaching Screenshots of the post fix. Kindly review the same
Working on the issue.
Hamid.ali → created an issue.
Kindly refer to the following issue : https://www.drupal.org/project/decorx/issues/3447338 🐛 Pagination need to be styled RTBC . All the developers here kindly check for duplication of the issue before start working on the same. Thanks
I created an MR for the issue and added the screenshot of the post-fix. Kindly review the same.
The pager is not centred. I am attaching the screenshot for the same kindly review it.
Working on the fix
Hamid.ali → created an issue.
Working on the patch
@anoopsingh92 kindly review the issue as well and move it further. Thanks
Hamid.ali → created an issue.
@anoopsingh92 created the MR for the same kindly review.
Hamid.ali → created an issue.
Hamid.ali → created an issue.
I reviewed the patch, Everything looks good to me apart from the alignment page number text. Which isn't aligned with the buttons, to fix the same you can add the align-items centre property to the ul.js-pager-items. I am adding screenshot for my assessment
kindly review the patch. Attaching the post fix screenshot.
Working on the issue.
Hamid.ali → created an issue.
Hamid.ali → created an issue.
Hamid.ali → created an issue.
@sahana_N I have reviewed the PR. The changes I request is to update font awesome library from the older version to the latest one since in the older version we dont have updated icon. Once it is done you can update the twitter icon from the page.html.twig file where currently twitter icon is being used as fa-twitter which after the update of the font awesome library needs to be changed to fa-x-twitter. This way we can fix this issue.
Hamid.ali → created an issue.
Hamid.ali → created an issue.
Hamid.ali → created an issue.
Tested the patch on local it is working fine but on sandbox its not working. Since it is working on the local moving the issue to for further review also adding the post patch screenshot below
Hamid.ali → created an issue.
Hamid.ali → created an issue.
Hamid.ali → created an issue.
Hamid.ali → created an issue.
Hamid.ali → created an issue.
@rajan kumar i was working on the issue but i can see you have still picked the issue so kindly work on the same and update the status accordingly
Hamid.ali → created an issue.
Hamid.ali → created an issue.
Hamid.ali → created an issue.
Hamid.ali → created an issue.
Hamid.ali → created an issue.
Hamid.ali → created an issue.
Hamid.ali → created an issue.
Hamid.ali → created an issue.