Mini pager need to be styled

Created on 10 June 2024, 5 months ago
Updated 20 September 2024, 2 months ago

Problem/Motivation

While going through the theme for issues I found out that the mini pager is not styled. Attaching the screenshot for a better understanding and making the issue clearer.

Steps to reproduce

Install the theme
Add 10-20 articles and check for the pagination.
Go to the page view setting and change the pager to mini.

Proposed resolution

The mini pager should be styled in the same style as the full pager.

Remaining tasks

none

User interface changes

Yes

API changes

none

Data model changes

none

šŸ› Bug report
Status

RTBC

Version

3.0

Component

User interface

Created by

šŸ‡®šŸ‡³India hamid.ali

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @hamid.ali
  • šŸ‡®šŸ‡³India hamid.ali

    Working on the patch

  • Issue was unassigned.
  • Status changed to Needs review 3 months ago
  • šŸ‡®šŸ‡³India hamid.ali

    Have created the MR for the same. I am attaching post-fix screenshots below. Kindly review.

  • Assigned to cleavinjosh
  • šŸ‡µšŸ‡­Philippines cleavinjosh

    I'll review this. Thank you.

  • Issue was unassigned.
  • Status changed to Needs work 3 months ago
  • šŸ‡µšŸ‡­Philippines cleavinjosh

    Hi @hamid.ali,

    Thank you for providing an MR. I applied MR!9, it was applied smoothly and the changes were reflected.

    āžœ  creative-responsive-theme git:(heads/8.x-1.0) curl https://git.drupalcode.org/project/creative-responsive-theme/-/merge_requests/9.diff | patch -p1
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
    100 17041    0 17041    0     0  34079      0 --:--:-- --:--:-- --:--:-- 34082
    patching file config/install/creative_responsive_theme.settings.yml
    patching file creative_responsive_theme.info.yml
    patching file creative_responsive_theme.libraries.yml
    patching file creative_responsive_theme.theme
    patching file css/custom-media.css
    patching file css/custom-style.css
    patching file js/custom.js
    patching file templates/content/comment.html.twig
    patching file templates/content/node.html.twig
    patching file templates/layout/page.html.twig
    patching file templates/misc/status-messages.html.twig
    patching file templates/navigation/book-navigation.html.twig
    patching file templates/navigation/toolbar.html.twig
    āžœ  creative-responsive-theme git:(heads/8.x-1.0) āœ—

    Before:

    After:

    Issue/Concern

    1. For the Full pager, is it possible to disable the current page as a link or button? Please see attached video.

    Please check and advise.
    Thank you.

  • Status changed to Needs review 3 months ago
  • šŸ‡®šŸ‡³India hamid.ali

    @cleavinjosh why you want to disable active link or button. It is good UI practise to show the active page with some different bg then the rest.

  • šŸ‡µšŸ‡­Philippines cleavinjosh

    Hi @hamid.ali,

    What I meant when I said to disable the current page is that the user can't click the current page but it will still retain the different background.

    It prevents users from accidentally clicking on the current page, which would be redundant and potentially confusing.

    Please check and advise.
    Thank you.

  • Status changed to RTBC 2 months ago
  • šŸ‡®šŸ‡³India riddhi.addweb

    The mentioned page issue is resolved, & I have also checked and it is working as expected. I am attaching the Screenshots & doing RTBC for the same.

Production build 0.71.5 2024