- Issue created by @hamid.ali
- Merge request !9Issue #3146935 by Project Update Bot, midlot-team, zymphonies-sales-team,... ā (Open) created by hamid.ali
- Issue was unassigned.
- Status changed to Needs review
3 months ago 11:07am 28 August 2024 - š®š³India hamid.ali
Have created the MR for the same. I am attaching post-fix screenshots below. Kindly review.
- Assigned to cleavinjosh
- Issue was unassigned.
- Status changed to Needs work
3 months ago 6:56am 5 September 2024 - šµšPhilippines cleavinjosh
Hi @hamid.ali,
Thank you for providing an MR. I applied MR!9, it was applied smoothly and the changes were reflected.
ā creative-responsive-theme git:(heads/8.x-1.0) curl https://git.drupalcode.org/project/creative-responsive-theme/-/merge_requests/9.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 17041 0 17041 0 0 34079 0 --:--:-- --:--:-- --:--:-- 34082 patching file config/install/creative_responsive_theme.settings.yml patching file creative_responsive_theme.info.yml patching file creative_responsive_theme.libraries.yml patching file creative_responsive_theme.theme patching file css/custom-media.css patching file css/custom-style.css patching file js/custom.js patching file templates/content/comment.html.twig patching file templates/content/node.html.twig patching file templates/layout/page.html.twig patching file templates/misc/status-messages.html.twig patching file templates/navigation/book-navigation.html.twig patching file templates/navigation/toolbar.html.twig ā creative-responsive-theme git:(heads/8.x-1.0) ā
Before:
After:
Issue/Concern
- For the Full pager, is it possible to disable the current page as a link or button? Please see attached video.
Please check and advise.
Thank you. - Status changed to Needs review
3 months ago 7:33am 5 September 2024 - š®š³India hamid.ali
@cleavinjosh why you want to disable active link or button. It is good UI practise to show the active page with some different bg then the rest.
- šµšPhilippines cleavinjosh
Hi @hamid.ali,
What I meant when I said to disable the current page is that the user can't click the current page but it will still retain the different background.
It prevents users from accidentally clicking on the current page, which would be redundant and potentially confusing.
Please check and advise.
Thank you. - Status changed to RTBC
2 months ago 1:24pm 20 September 2024 - š®š³India riddhi.addweb
The mentioned page issue is resolved, & I have also checked and it is working as expected. I am attaching the Screenshots & doing RTBC for the same.