Footer needs to be styled.

Working on the issue

Created the MR for the same. I am attaching post-fix screenshot below.

Working on the phpc errors

Fixed all the css related linting errors. Rest of the phpcs errors are coming from the template files.

Hi @hamid.ali,

Thank you for providing an MR. I applied MR!11 and it was applied smoothly. However, the changes were not reflected.

➜  rover git:(1.0.6) curl https://git.drupalcode.org/project/rover/-/merge_requests/11.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1023    0  1023    0     0   1859      0 --:--:-- --:--:-- --:--:--  1856
patching file css/style.css
➜  rover git:(1.0.6) ✗

Before and After:

Please check and advise.
Thank you.

I've cloned the project (branch 1.0.x) in Drupal version 10.3.2 and applied the MR!11, the patch couldn't apply got the below error

Checking patch css/style.css...
error: while searching for:
.custom-pagination .page-item .page-link[title="Go to last page"] {
  border-radius: 5px;
}
.breadcrumb a, 
.breadcrumb-saprator {
  color: #f34573;
}
.breadcrumb-saprator {
  padding: 0 8px;
}

error: patch failed: css/style.css:1049
error: css/style.css: patch does not apply

I'll work on this.

I've resolved the conflicts in the MR!11. The previous code targeted #footer_nav id for styling due to which the styling wasn't being applied as the first part (i.e, footer is the menu machine name) is dynamic cause one can create custom menu and not necessarily have machine named footer. I've addressed this by changing the id to class selector and updated the MR!11.
Included ss for before and after. Please review.
Thanks

yogesh.k → closed merge request !11