Mini pager need to be styled

Created on 12 June 2024, 6 months ago
Updated 3 September 2024, 4 months ago

Problem/Motivation

While going through the theme for issues I found out that the mini pager is not styled. Attaching the screenshot for a better understanding and making the issue clearer.

Steps to reproduce

Install the theme
Add 10-20 articles and check for the pagination.
Go to the page view setting and change the pager to mini.

Proposed resolution

The mini pager should be styled in the same style as the full pager.

Remaining tasks

none

User interface changes

Yes

API changes

none

Data model changes

none

šŸ› Bug report
Status

Needs work

Version

3.0

Component

User interface

Created by

šŸ‡®šŸ‡³India hamid.ali

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @hamid.ali
  • Assigned to hamid.ali
  • šŸ‡®šŸ‡³India hamid.ali

    Working on the issue

  • Issue was unassigned.
  • Status changed to Needs review 4 months ago
  • šŸ‡®šŸ‡³India hamid.ali

    I created an MR and updated the mini pager stylings. Attaching postfix screenshot.

  • šŸ‡®šŸ‡³India Kanchan Bhogade

    Hi
    I have tested MR 4 on Drupal 10
    The MR is applied cleanly...

    Test Result:
    The Full and Mini pager style is updated.

    RTBC+1

    Attchaing Screenshot

  • Assigned to cleavinjosh
  • šŸ‡µšŸ‡­Philippines cleavinjosh
  • Issue was unassigned.
  • Status changed to Needs work 4 months ago
  • šŸ‡µšŸ‡­Philippines cleavinjosh

    Hi @hamid.ali,

    Thank you for providing an MR. I applied MR!4 and it styled the pagination. I'll be attaching some screenshots for reference:

    Full pager before:

    Full pager after:

    Mini pager before:

    Mini pager after:

    Concerns/Suggestions

    1. Improve the hover state effect of the "Next" and "Previous" buttons. In the current style, it just darkens the color a little bit. It would be great if you add an underline.
    2. Improve the color of the "current" page so that it will standout more than the buttons.
    3. Improve the responsiveness of the pagination. In mobile view, the space on the left is larger than the right.

    Please check and advise.
    Thank you.

  • Assigned to hamid.ali
  • šŸ‡®šŸ‡³India hamid.ali

    working on the fix

  • Issue was unassigned.
  • Status changed to Needs review 4 months ago
  • šŸ‡®šŸ‡³India hamid.ali

    Updated the full and mini pager stylings. Attaching the post-fix screenshots below kindly review.

  • Assigned to cleavinjosh
  • šŸ‡µšŸ‡­Philippines cleavinjosh
  • Issue was unassigned.
  • Status changed to Needs work 4 months ago
  • šŸ‡µšŸ‡­Philippines cleavinjosh

    Hi @hamid.ali,

    Thank you for providing the changes. I applied MR!4, it was applied smoothly and the changes were reflected.

    āžœ  freelancer_zymphonies_theme git:(8.x-1.x) curl https://git.drupalcode.org/project/freelancer_zymphonies_theme/-/merge_requests/4.diff | patch -p1
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
    100 41300    0 41300    0     0    98k      0 --:--:-- --:--:-- --:--:--   98k
    patching file css/global.css
    patching file freelancer_zymphonies_theme.info.yml
    patching file freelancer_zymphonies_theme.libraries.yml
    patching file freelancer_zymphonies_theme.theme
    patching file templates/field/link-formatter-link-separate.html.twig
    patching file templates/form/dropbutton-wrapper.html.twig
    patching file templates/form/select.html.twig
    patching file templates/navigation/toolbar.html.twig
    āžœ  freelancer_zymphonies_theme git:(8.x-1.x) āœ—

    I'll be attaching screenshots of the changes:
    Full pager:

    Mini pager:

    Great job in addressing the hover effect issue.

    Concerns/Suggestions

    1. In the mini pager, the button will outshine the current page
    2. In full pager, is it possible to disable the current page as a link or button?
    3. Is it possible to automatically switch from full pager to mini pager in mobile view?.

    Please check and advise.
    Thank you.

Production build 0.71.5 2024