- Issue created by @hamid.ali
- Assigned to hamid.ali
- Merge request !3Issue #3147609 by Project Update Bot, zymphonies-sales-team, zymphonies-team,... ā (Closed) created by hamid.ali
- Merge request !4Issue #3147609 by Project Update Bot, zymphonies-sales-team, zymphonies-team,... ā (Open) created by hamid.ali
- Issue was unassigned.
- Status changed to Needs review
4 months ago 10:43am 22 August 2024 - š®š³India hamid.ali
I created an MR and updated the mini pager stylings. Attaching postfix screenshot.
- š®š³India Kanchan Bhogade
Hi
I have tested MR 4 on Drupal 10
The MR is applied cleanly...Test Result:
The Full and Mini pager style is updated.RTBC+1
Attchaing Screenshot
- Assigned to cleavinjosh
- Issue was unassigned.
- Status changed to Needs work
4 months ago 7:06am 27 August 2024 - šµšPhilippines cleavinjosh
Hi @hamid.ali,
Thank you for providing an MR. I applied MR!4 and it styled the pagination. I'll be attaching some screenshots for reference:
Full pager before:
Full pager after:
Mini pager before:
Mini pager after:
Concerns/Suggestions
- Improve the hover state effect of the "Next" and "Previous" buttons. In the current style, it just darkens the color a little bit. It would be great if you add an underline.
- Improve the color of the "current" page so that it will standout more than the buttons.
-
Improve the responsiveness of the pagination. In mobile view, the space on the left is larger than the right.
Please check and advise.
Thank you. - Assigned to hamid.ali
- Issue was unassigned.
- Status changed to Needs review
4 months ago 11:40am 27 August 2024 - š®š³India hamid.ali
Updated the full and mini pager stylings. Attaching the post-fix screenshots below kindly review.
- Assigned to cleavinjosh
- Issue was unassigned.
- Status changed to Needs work
4 months ago 8:02am 3 September 2024 - šµšPhilippines cleavinjosh
Hi @hamid.ali,
Thank you for providing the changes. I applied MR!4, it was applied smoothly and the changes were reflected.
ā freelancer_zymphonies_theme git:(8.x-1.x) curl https://git.drupalcode.org/project/freelancer_zymphonies_theme/-/merge_requests/4.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 41300 0 41300 0 0 98k 0 --:--:-- --:--:-- --:--:-- 98k patching file css/global.css patching file freelancer_zymphonies_theme.info.yml patching file freelancer_zymphonies_theme.libraries.yml patching file freelancer_zymphonies_theme.theme patching file templates/field/link-formatter-link-separate.html.twig patching file templates/form/dropbutton-wrapper.html.twig patching file templates/form/select.html.twig patching file templates/navigation/toolbar.html.twig ā freelancer_zymphonies_theme git:(8.x-1.x) ā
I'll be attaching screenshots of the changes:
Full pager:
Mini pager:
Great job in addressing the hover effect issue.
Concerns/Suggestions
- In the mini pager, the button will outshine the current page
- In full pager, is it possible to disable the current page as a link or button?
- Is it possible to automatically switch from full pager to mini pager in mobile view?.
Please check and advise.
Thank you. - In the mini pager, the button will outshine the current page