🇺🇸United States @charles belov

Did some HTML in that last comment get rendered as HTML instead? There appears to be blank space between "necessary to add" and the period.

charles belov → created an issue.

I'll note "Suggest the minimum font size for Admin UI." might be too small for some people to read if they haven't set it. Although I realize they can use browser zoom to read it, make the setting, then reset browser zoom to actual size once they've set it.

@nayana_mvr That mock-up is exactly what I have in mind, thank you. I would be likely to use the Unreduced setting.

Actually it could be a drop-down for minimum font size:

Extra Extra Small (default)
Extra Small
Small
Unreduced

Then could the separate window could be generated from the database? The source doesn't matter; what matters is that it be the same source.

+1 for parsing the yaml tour as it ensures the steps and labels are in sync and no duplicate effort.

Hmmm, if the behavior of whether or not a new content type is automatically enabled is dependent on whether or not all existing content types are enabled...

Then is there any feedback to the administrator that this logic decision has taken place? While this may be the expected behavior, it is still easy to overlook if it is not the desired behavior for a particular content type. I recognize that the change in configuration may have occurred in code rather than through interaction with the administrative user interface. Just trying to avoid surprises.

Another use case is accessibility. Words in all caps can be misread by screen readers. Sentences in all caps also present cognitive load to some - myself included - and are also harder for people with low vision to read. Therefore, we want to be able to review all content in all caps to ensure that they are acronyms/initialisms and not words in all caps. Definitely two consecutive word units in all caps would be highly suspicious as being words in all caps.

Adding accessibility tag. While it doesn't affect Drupal's accessibility, it is a blocker to monitoring for accessibility in editor content.

I'm not sure why it would be harmful if something has been specified twice to only do it once. That said, I guess if one removes something, then one would expect it to go away, which wouldn't happen if it were specified twice.

Then I would suggest the following wording for Source editing:

This plugin adds a list of HTML tags that can be used while editing source. Remove or do not add tags that are already supported by other enabled plugins. For example, if "Bold" is enabled in the toolbar, do not add the tag. If another plugin requires a tag but does not supply it, you will need to add that tag here.

Reviewed and tested in simplytest.me, thank you!

I didn't change the status because I don't know whether my test is sufficient to be considered Reviewed and Tested by the Community.

The part above about adding "other" to the Source Editing instructions is out of date because that change has already been made to core code. It is correctly not part of the current MR.

Ah, if that comment was directed at me then I'm not going to be able to test it. I'm QA not a developer.

Agreed. This is dependent on 🐛 Add an "alt text" to tour tips describing the situation and the highlighted element Active and I'm adding it as a related issue.

charles belov → created an issue.

It would also need to be possible to add language spans if one of the accordion titles is in a different language.

charles belov → created an issue.

I am unable to test this code due to existing issues 🐛 Adding accordion to CKEditor toolbar gets error Active and ✨ Make CKEditor be forgiving of enabling something that's already enabled Active . But it seems this patch has not fully shed the <dl> tag.

Details follow:

I added CKEditor Accordion module to Drupal core in SimplyTest.me and applied this patch.

• Drupal 10.3.2
• CKEditor Accordion 2.2.0
• plus patch https://www.drupal.org/files/issues/2024-08-27/2024-08-27-ckeditor_accor... →

I believe this patch has been applied, as when I go to /admin/config/content/ckeditor-accordion I see the following setting:

Variant
Default: Default HTML structure which uses <div> <h2> <div> style tags.
Select the variant to be used.

and that is the only selection available. (Is this correct? Would I expect to see the original <dl> option? Perhaps not if it doesn't meet WCAG.)

However, when I go to /admin/config/content/formats/manage/basic_html and drag the accordion icon from Available Buttons to Active Toolbar, I get the following error:

The following tag(s) are already supported by enabled plugins and should not be added to the Source Editing "Manually editable HTML tags" field: accordion (<dl>).

So, even though with this patch we are no longer using the <dl> tag, the CKEditor 5 module still "thinks" we are trying to use that tag.

@rkoller @smustgrave I concur. I would be unable to reproduce the issue, so I am not that one to file the second issue if there's not an easy way to reproduce on the Mac.

charles belov → created an issue. See original summary → .

Thank you.

I've viewed the reduced motion video. It went by a little fast (I wound up watching it at half speed) but I'm able to suss out some comments.

The question with reduced motion can sometimes be that there was some advantage with the motion that needs to be replaced in a safe way. Here, the point would be that with long pages, it may be hard to tell where you are on the page, and whether you went up or down to get there. This is relevant to a tour, because the visitor needs to be able to replicate the action.

While your demo video has scroll bars, and I have my scroll bars set to always on, some operating systems (in my case macOS) allow setting the scroll bars to only display when you need them. So people who have that setting may not be able to tell where the particular tour point of interest is on the page. So they trade information for safety.

I don't want to over-engineer this, but such people might need a brief arrow cue that we are going down the page. Maybe even one arrow for a short distance or three for a long distance. Maybe the arrow would fade in and out.

Please split the example video into two videos, one with motion and one with the reduce-motion setting. I didn't know what I was getting into and the motion part of the video made my eyes feel ill.

The non-motion part is likely what I'm seeking, but until my eyes calm down (and you provide a reduced-motion-only video that I can safely watch) I'm not in a position to judge.

Happy to test on simplytest.me if someone can point me to instrux and a sample tour. Not a developer here, I'm Quality Assurance.

If ability to set the link target is added, please make it configurable as to whether it is available or not, to allow setting a site policy, for example:

• Allow editors to set target
• Always set target _blank on external links
• Don't allow setting target

charles belov → created an issue.

charles belov → created an issue. See original summary → .

charles belov → created an issue.

charles belov → created an issue.

charles belov → created an issue.

Have these changes been pushed to the release version yet? I'm still getting the same results - no space between "to" and Contact even though the source code has a space between "to" and the emphasis tag - in simplytest.me using the (adjusted to reflect current behavior) steps above.

Charles Belov → created an issue.

Charles Belov → created an issue.

The HTTP Status Code project → is not covered by the security advisory and has very few installs. I'm in agreement that the Redirect module's user interface is the best place for this because it does not require going to a different user interface.

I suppose a workaround might be to redirect to a page such as [website domain]/410gone and have that page return a 410 status code. That's an unpleasant kluge though, because the browser would improperly show the replacement URL rather than the originally requested URL.

It appears that I never filed this with with joyride. I have now filed this as Respect prefers-reduced-motion #241

Actually, this issue is probably obsolete. If Tours were to respect prefers-reduced-motion, then there would be no need for a separate setting.

Charles Belov → created an issue.

I filed this as a result of a real-life issue. Another staff member asked me to check why a particular redirect didn't seem to be having any effect. It turned out when they copied and pasted the path, they accidentally copied some additional text after the end of the path, causing the path not to match. It wasn't obvious because the full path ran past the end of the field.

Charles Belov → created an issue.

Charles Belov → created an issue.

I believe that the menu navigation as described in 📌 Ensure keyboard navigation works with the drawer Active is not behaving as described. The issue is marked as fixed. Would you prefer that I open a new issue or reopen 📌 Ensure keyboard navigation works with the drawer Active ?

Specifically, I can only navigate through the menu using tab and enter keys; the arrow keys don't accomplish anything. I actually prefer that. However, concerningly, escape does not work to exit sub-menus and I have to tab out of them. (I'm not filing this here in the current issue - I just wanted it here so that when you respond I can simply follow the desired instructions and not have to hunt this down somewhere else.)

Please advise.

Charles Belov → created an issue.

I would be concerned about a setting which disables keyboard accessibitily for all users. I would expect disabling keyboard accessibility to be a user setting, not a sitewide setting.

I'd also like to see what that top bar might look like in the context of viewing the published version (if one exists) or viewing the current draft. I'm not a big fan of hiding things under "more options"; can that be an individual user's preference setting? Some users probably prefer less clutter, others like me prefer my options to be in sight.

I have filed 📌 Ensure Local task functionality provided by Admin toolbar extra can be implemented in Navigation Active .

Charles Belov → created an issue.

Trying with a backslash immediately before the left bracket:

\ 🐛 Navigation module gets error when added on simplytest.me Active

Hoped-for result: That it prevents the expansion (not that I would expect to need to do this; my expected result without the backslash stands)
Actual result: No effect

And here I am repeating those steps as a comment:

🐛 Navigation module gets error when added on simplytest.me Active

Charles Belov → created an issue.

Reapplying this comment to the current issue (which it does not apply to) to verify reproducibility and confirming that it happens here as well following the steps listed above in the current issue description:

Okay, I don't want to mess up your Tugboat instance. The instance on 🐛 navigation_theme() loads 'extension.list.module' for no purpose. Needs review doesn't seem to have Admin Toolbar.

However, the specific configuration I want to test is as follows:

1. On /admin/modules, in addition to the Admin Tool bar, enable Admin Toolbar Extra Tools
2. Click Install
3. Expand Admin Toolbar Extra Tools
4. Click Configure
5. Check Enable/Disable local tasks display
6. Click Save configuration
7. Navigate to some existing content

Expected result: there is a local task menu, with the following sub-items:

• View
• Edit
• Delete
• Revisions

Presumably with Navigation also installed, the local task menu would be incorporated into the left side bar navigation.

If Admin Tool Bar isn't compatible with navigation, then I would expect there to be some other means by which I could incorporate such a menu and sub-menu into the navigation menu.

As a sidenote, I dislike the "local task" label as being jargon, and have separately filed 🐛 "Local tasks" is hard to understand Active

Charles Belov → created an issue.

Okay, I don't want to mess up your Tugboat instance. The instance on 🐛 navigation_theme() loads 'extension.list.module' for no purpose. Needs review doesn't seem to have Admin Toolbar.

However, the specific configuration I want to test is as follows:

1. On /admin/modules, in addition to the Admin Tool bar, enable Admin Toolbar Extra Tools
2. Click Install
3. Expand Admin Toolbar Extra Tools
4. Click Configure
5. Check Enable/Disable local tasks display
6. Click Save configuration
7. Navigate to some existing content

Expected result: there is a local task menu, with the following sub-items:

• View
• Edit
• Delete
• Revisions

Presumably with Navigation also installed, the local task menu would be incorporated into the left side bar navigation.

If Admin Tool Bar isn't compatible with navigation, then I would expect there to be some other means by which I could incorporate such a menu and sub-menu into the navigation menu.

As a sidenote, I dislike the "local task" label as being jargon, and have separately filed 🐛 "Local tasks" is hard to understand Active

That's unfortunate. I wanted to check whether there were any conflicts between the Navigation and Admin Toolbar modules.

Charles Belov → created an issue.

Needs section on prefers-reduced-motion.

Note that use of the word "reduced" is an artifact that Apple got there first with their "Reduce Motion" setting in macOS and iOS. Windows uses "Animation effects" while Android uses "Remove animations," both of which imply all or nothing.

Sorry, accidentally po

Not sure whether this is a separate issue, but I'm getting the same errors today for:

Drupal core (10.2.5)
and
Additional project name:
Navigation 1.x-dev

I was on someone else's Tugboat site which had Navigation installed, so evidently there is a way to create it, but simply adding Navigation 1.x-dev, which I chose from the autocomplete drop-down, does not seem to be it.

The Tugboat environment in the current issue description is no longer available as of 4:49 pm PDT (+7) April 8, 2024.

Noting that the filename coming from an iPhone is typically just IMG followed by a sequence number, something that is not accessible. I also see many image file names on our website that are gibberish.

Has an accessibility review been done on this issue?