πŸ‡ΊπŸ‡ΈUnited States @Charles Belov

San Francisco, CA, US
Account created on 6 August 2009, over 14 years ago
#

Recent comments

πŸ‡ΊπŸ‡ΈUnited States Charles Belov San Francisco, CA, US

What is the best practice for a long-closed-as-fixed issue which has regressed/re-appeared? Comment on that issue? Or file a new issue and reference the closed issue?

I can't reopen the issue because only the maintainer can do that.

πŸ‡ΊπŸ‡ΈUnited States Charles Belov San Francisco, CA, US

This issue appears to have regressed. As of Feb. 28, 2024:

Steps to reproduce

1. Go to https://simplytest.me
2. In the field, type "Core" (without the quotes)
3. Choose Drupal core
4. Click the add project button
5. In the project field, type "Paragraphs"
6. Choose Paragraphs
7. Click the button to create the site
8. Once the site has been created, log in as admin
9. In the admin menu, choose Manage, then Structure, then Paragraphs types
10. Click Add paragraph type
11. Type label "Single contact"
12. Click Save and manage fields
13. Click Create a new field
14. Type label "Contact name"
15. Choose text
16. Click Continue
17. Change Allowed number of values to unlimited
18. Click Save settings
19. Choose Structure, then Content types, then, on the row for Basic page, choose Manage fields
20. Click Create a new field
21. Type label "Contact information"
22. Choose Paragraphs
23. Click Continue
24. Under paragraph types, check Single contact
25. Click Save settings
26. In the admin menu, choose Manage, then Content, then Add content, then Basic page

Expected result: Contact information has no vertical three dots icon

Actual result: Contact information has a vertical three dots icon. Clicking the three dot icon reveals the menu item Drag & Drop

πŸ‡ΊπŸ‡ΈUnited States Charles Belov San Francisco, CA, US

Would the postponement correctly be removed at this point? It looks like the issue that this item is waiting on was resolved in 2019.

πŸ‡ΊπŸ‡ΈUnited States Charles Belov San Francisco, CA, US

For clarification, the research requested was done in #17 and #21.

πŸ‡ΊπŸ‡ΈUnited States Charles Belov San Francisco, CA, US

\core\modules\ckeditor5\js\ckeditor5_plugins\drupalImage\src\imagealternativetext\ui\imagealternativetextformview.js
shows the line
labeledInput.label = Drupal.t('Text alternative');
was last committed with
c6d7b83fa35 (bnjmnm 2022-03-31 08:18:19 -0400 254)

However, if I search for c6d7b83fa35 on either drupal.org or git.drupalcode.org, I get no results.

I do see relevant issues involving @bnjmnm which were updated around that time:

The latter issue does have the comment:

Is "Default alternative text" the right term? Does it convey enough information?

I think that something like "Alternative text from Media Library" might be clearer?

but I don't see anything in the issue discussing "Alternative text" versus "Text alternative".

πŸ‡ΊπŸ‡ΈUnited States Charles Belov San Francisco, CA, US

I'm actually QA, not a developer, and setting up an environment to run git blame against Drupal core is beyond my knowledge.

πŸ‡ΊπŸ‡ΈUnited States Charles Belov San Francisco, CA, US

Minor word omission fix

πŸ‡ΊπŸ‡ΈUnited States Charles Belov San Francisco, CA, US

@wim-leers I did a search in DuckDuckGo and Google for pages on URLs beginning www.drupal.org/project/drupal/issues which contained both "text alternative" and "alternative text" (with quotes) as character strings. None of the issues which turned up as obvious choices had a discussion about which was the appropriate choice for the label.

I also searched for git.drupalcode.org content containing "text alternative," with no results in either engine.

I have updated the issue descriptions to add my reasoning as to why I believe "Alternative text" is the correct label.

πŸ‡ΊπŸ‡ΈUnited States Charles Belov San Francisco, CA, US

Charles Belov β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States Charles Belov San Francisco, CA, US

Adding accessibility and needs accessibility review tags. In my experience, file names are typically not appropriate as alt text.

πŸ‡ΊπŸ‡ΈUnited States Charles Belov San Francisco, CA, US

For maximum usability, I would suggest the following.

  • Show the existing media library default alternative text outside the field, so that someone who is typing new text in the field can refer to the existing text while they are typing the new text. This reduces cognitive load and also makes it easier for the content editor to
    • decide whether they want to keep the default alt text or write new alt text.
    • revert any edits while still having the original available to them.
  • Ensure that the displayed existing text is copy-and-paste-able.
πŸ‡ΊπŸ‡ΈUnited States Charles Belov San Francisco, CA, US

It appears from the demonstration animated gif of the decorative image toggle β†’ that the default is decorative. The default would best be non-decorative, requiring that the editor assertively choose that the image is decorative.

Please clarify as to whether this animation shows the default or reflects an image that was previously set to decorative.

πŸ‡ΊπŸ‡ΈUnited States Charles Belov San Francisco, CA, US

Confirmed working as requested in Drupal 10.2.2. Closing as unable to reproduce.

πŸ‡ΊπŸ‡ΈUnited States Charles Belov San Francisco, CA, US

Charles Belov β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States Charles Belov San Francisco, CA, US

While waiting for this, wondering whether the title subfield might be usable as a workaround for websites that are not already using the title field on images. A site could theme the title subfield as a figcaption tag rather than as a title attribute. Hover tooltips are a pain on mobile anyway.

πŸ‡ΊπŸ‡ΈUnited States Charles Belov San Francisco, CA, US

For clarification, are we talking about a caption or something else? I understand that captions (intended to be seen or heard by all, whether or not they can see the image) and alternative text (intended to be seen or heard only by people who cannot see the image) are two different things, but is description a third thing, that is intended to be seen or heard by content maintainers?

πŸ‡ΊπŸ‡ΈUnited States Charles Belov San Francisco, CA, US

Confirmed as being addressed in πŸ“Œ Let users disable animation in Olivero Needs work .

πŸ‡ΊπŸ‡ΈUnited States Charles Belov San Francisco, CA, US

The patch in #113 doesn't seem to respect 🌱 [policy, no patch] Use "prefers-reduced-motion" media query to disable animations Active . Is that now handled automatically by core, or is a change needed to the patch to agree with policy?

πŸ‡ΊπŸ‡ΈUnited States Charles Belov San Francisco, CA, US

Extra-small creates usability/accessibility issues for me. I created Give users option to override Claro --font-size-xs with --font-size-s ✨ Give users option to override Claro --font-size-xs with --font-size-s Active , which I believe would also apply to the current issue.

πŸ‡ΊπŸ‡ΈUnited States Charles Belov San Francisco, CA, US

Changing the description and title back, as I misunderstood the issue with 10.2.0, with an update to the proposed message based on my current understanding.

πŸ‡ΊπŸ‡ΈUnited States Charles Belov San Francisco, CA, US

Sorry, missed the part about only coding <span>.

πŸ‡ΊπŸ‡ΈUnited States Charles Belov San Francisco, CA, US

I am consistently able to reproduce the problem using the steps I provided. I am also attaching supporting screen capture and recordings demonstrating the issue.

Screenshot 2024-01-02 at 5.32.19β€―PM.png shows me requesting Drupal 10.2.0 at simplytest.me.
Sandbox build log.txt is the site build log from simplytest.me showing what was installed.
Screen Recording 2024-01-02 at 5.37.12β€―PM 1080p.mov is a screen recording of my following the steps I outlined in my original post (plus showing the system status to reveal the reason for an installation error Drupal found). I apologize for the shrunk size, but the original video exceeded the maximum upload size.

πŸ‡ΊπŸ‡ΈUnited States Charles Belov San Francisco, CA, US

Updated the issue description on December 28, 2023, to reflect changed behavior in Drupal 10.2.

πŸ‡ΊπŸ‡ΈUnited States Charles Belov San Francisco, CA, US

The documentation request is for the UI to be updated, which will take a while, at the very least to the next release. I did the separate support request because I am seeking to accomplish this right now and need the support timely. They are two separate things even though they cover the same topic.

πŸ‡ΊπŸ‡ΈUnited States Charles Belov San Francisco, CA, US

I'd prefer not to see https://github.com/ckeditor/ckeditor5/issues/15554 as a blocker to the current issue as it seems to be a separate issue. While waiting for that issue, a developer could use display:none to not render the drop down for unordered lists from the WYSIWYG, no?

πŸ‡ΊπŸ‡ΈUnited States Charles Belov San Francisco, CA, US

If/when this is implemented, I would want this to be an administrator configuration, not the choice of individual editors. That is, if I as administrator configure the site that pasting from Word into the CKEditor WYSIWYG is to strip non-semantic styling, then editor pastes would always strip non-semantic styling from the code as well as any span tags which were now empty because of the stripping of that styling.

πŸ‡ΊπŸ‡ΈUnited States Charles Belov San Francisco, CA, US

I renamed the issue to "Allow copying structure from Word without styling" because, according to a maintainer comment concerning non-breaking spaces in Can't use non-breaking-space in the editor from one of the maintainers, CKEditor5, CKEditor5 manages non-breaking spaces and places them where it "thinks" they belong.

The title reads like a feature request. However, because CKEditor5 inserts unwanted non-breaking spaces into some documents copied from Word, lack of this feature manifests as a bug. Either non-breaking spaces in CKEditor5 need to be fixed (see #1669) or it has to be possible to strip Word styling on paste so that CKEditor 5 no longer inserts extraneous non-breaking spaces.

πŸ‡ΊπŸ‡ΈUnited States Charles Belov San Francisco, CA, US

Setting to Active on the basis that I provided the info, as I don't see a Postponed (waiting on upstream) option.

πŸ‡ΊπŸ‡ΈUnited States Charles Belov San Francisco, CA, US

@Wim Leers: in answer to your questions:

1. I am unable to tell whether I can reproduce it on the CKEditor feature-rich editor page, as that page does not provide a Source button. However, I am able to reproduce it on the CKEditor demo page.

2. There was an existing issue [Safari] Non-breaking space present in a model after view upcasting in some specific cases #2522. However, it was different enough that I filed a separate issue Paste from Word introduces non-breaking spaces #15488.

πŸ‡ΊπŸ‡ΈUnited States Charles Belov San Francisco, CA, US

As of Drupal 10.0.2-beta1:

14. At the bottom, click Save Configuration.

Expected result: Return to Text formats and editors; get message The text format Basic HTML has been updated. If I click Source editing, the Manually editable HTML tags field contains <span>

Actual results:
Error message: The Language plugin needs another plugin to create <span>, for it to be able to create the following attributes: <span lang dir>. Enable a plugin that supports creating this tag. If none exists, you can configure the Source Editing plugin to support it.

If I click Source editing, the Manually editable HTML tags field does not contain <span> even though I previously added it and saved the configuration.

πŸ‡ΊπŸ‡ΈUnited States Charles Belov San Francisco, CA, US

@poker10: Assuming you mean all supported modules would show the shield, I'd concur with that, as it would be consistent with what we show on the project page on drupal.org. It would need the corresponding alt and title text as well.

πŸ‡ΊπŸ‡ΈUnited States Charles Belov San Francisco, CA, US

I suppose there could also be a search filter at the top of the list, which is friendlier than scrolling. An editor could start typing the desired language name into that field and only the matches would show, likely to be a short list. That said, it depends on how the languages are displayed. If they are displayed in their native name rather than the website administration language, typing the name could be an issue, for example, if the editor is trying to retrieve traditional Chinese but can only type in Latin characters.

πŸ‡ΊπŸ‡ΈUnited States Charles Belov San Francisco, CA, US

@rkoller Thank you for your detailed ask.

My preference is that sites take me at my word that I don't want animations and only show animations that I have explicitly requested, preferably by explicitly toggling a switch from not-animate to animate or by clicking a play control.

So, if you do have a toggle switch on the page, it would default to animate if I don't have prefers-reduced-motion set to reduce, but default to not animate if I do have prefers-reduced-motion set to reduce. And that would be the behavior I would advocate for Drupal core and contributions to follow.

Always take my stated preference as the default for my visit, please, because I am counting on websites to respect my system-wide request. Having to look for an additional setting in order to be free of unrequested animations places a barrier to my interacting with a website in a safe manner.

As a side note, the example site you provided (https://holohalo.net), is not automatically animating for me in Firefox or Safari (and that is true for Safari whether I have System Settings, Accessibility, Display, Auto-play animated images turned on or off). It is animating for me in Chrome, and the labels on the toggle switch appear to be backward, that is, off is on the left but to turn the animation off I need to move the switch to the right; again, if I have prefers-reduced-motion set to reduce, the proper behavior would be to default to off and let me decide if I want to turn it on. That said, it is in an obvious, easy to reach, location, as long as I'm using a pointing device and not keyboard-only.

πŸ‡ΊπŸ‡ΈUnited States Charles Belov San Francisco, CA, US

"Filtered HTML format" in Drupal 7 is now called "Basic HTML format" in Drupal 10, if I am understanding this correctly. I have made this change to the Body section.

πŸ‡ΊπŸ‡ΈUnited States Charles Belov San Francisco, CA, US

@rkoller re:

but on the other hand i am not sure if the scrolling poses a visual challenge and trigger for some groups of people.

All smooth-scrolling poses a trigger for me. The code needs to check for prefers-reduced-motion and just jump to the location rather than smooth-scrolling if it is set to reduce.

Production build https://api.contrib.social 0.61.6-2-g546bc20