- Issue created by @charles belov
- First commit to issue fork.
- Merge request !9517Issue #3471896: Inconsistent use of language regarding plugins → (Open) created by annmarysruthy
- Status changed to Needs work
about 2 months ago 1:08pm 17 September 2024 - First commit to issue fork.
- Status changed to Needs review
about 2 months ago 2:04pm 17 September 2024 - 🇮🇳India KumudB Ahmedabad
I have verified the changes and have raised a MR to address the issue of inconsistent plugin representation in the CKEditor configuration interface. Please review the PR at your convenience. Thank you!
- 🇺🇸United States charles belov San Francisco, CA, US
Reviewed and tested in simplytest.me, thank you!
I didn't change the status because I don't know whether my test is sufficient to be considered Reviewed and Tested by the Community.
The part above about adding "other" to the Source Editing instructions is out of date because that change has already been made to core code. It is correctly not part of the current MR.
- Merge request !9548Issue-3471896: Inconsistent use of language regarding plugins. → (Open) created by KumudB
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇺🇸United States benjifisher Boston area
Usability review
We discussed this issue at 📌 Drupal Usability Meeting 2024-10-25 Active . That issue has a link to a recording of the meeting.
For the record, the attendees at the usability meeting were @benjifisher, @rkoller, @shaal, @amazingrando, @rosendo.fig, @simohell, and @worldlinemine.
We agree that the language here is inconsistent, but we think the right way to fix this is to remove references to "plugins", not add more. The word "plugin" has too many meanings (in Drupal, CKEditor, and WordPress, for example) and someone configuring the toolbar is more likely to think of "features", "buttons", or "toolbar items".
We also think we should use something more generic, like "toolbar items", instead of "buttons", since the toolbar also includes drop-down lists and separators.
We suggest making the following changes to the interface text:
- Change the label "Toolbar buttons" to "Toolbar items".
- Change the text "Move a button into the Active toolbar to enable it, or into the list of Available buttons to disable it." to "Move a button into the Active toolbar to enable it, or into the list of Available items to disable it. "
- Change the text "The toolbar buttons that don't fit ..." to "The toolbar items that don't fit ...".
- Change the header "CKEditor 5 plugin settings" to "Settings".
- Change the help text for "Manually editable HTML tags" (under the "Source editing" vertical tab) to
A list of HTML tags that can be used while editing source. It is only necessary to add tags that are not already supported by other enabled toolbar configuration. For example, if "Bold" is enabled, it is not necessary to add the tag. If there is no "Definition list" item, then it may be necessary to add
If you want more feedback from the usability team, a good way to reach out is in the #ux channel in Slack.
- 🇺🇸United States charles belov San Francisco, CA, US
Did some HTML in that last comment get rendered as HTML instead? There appears to be blank space between "necessary to add" and the period.
- 🇺🇸United States benjifisher Boston area
Thanks for pointing out that problem. I edited Comment #15.