The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
about 2 years ago 6:13am 8 February 2023 - 🇮🇳India TanujJain-TJ
added wrong patch file on #34
Tried to fix CCF on #33
attached interdiff file The last submitted patch, 35: 2907780-35.patch, failed testing. View results →
The last submitted patch, 36: 2907780_34.patch, failed testing. View results →
- Status changed to Needs work
3 months ago 4:26pm 10 December 2024 - First commit to issue fork.
- 🇮🇳India anmolgoyal74
I have re-rolled the patch and used OOP hooks to purge the field definitions. I did it as a part of contribution sprint at DrupalCon Singapore 2024.
- 🇮🇳India immaculatexavier
Hi @anmolgoyal74
The reroll seems to be good.
Fix PHPCS Violations:
Go through the generated PHPCS report and resolve the coding standard violations. This may involve reformatting the code, adding missing docblocks, or updating variable names.
Address PHPStan Issues:
Review the PHPStan analysis and resolve any potential type mismatches, missing variables, or logical errors. - 🇷🇴Romania amateescu
While this issue was quite a nice trip down memory lane, I wasn't really serious with the previous service name :)
Updated it to "field purger" and brought this old patch up to current core standards, with a change record as well: https://www.drupal.org/node/3494023 →
- 🇺🇸United States nicxvan
Went through it a couple of times.
Just one question in the mr.
- 🇺🇸United States smustgrave
Comment seems valid.
Also will need test coverage for the update hook around the config updates.