- ๐บ๐ธUnited States mradcliffe USA
I resolved the CS nits. I removed the use of t completely because other tests do not use it such as MapBaseFieldTest and FieldItemTest. Also I switched to using FieldType attribute.
- First commit to issue fork.
- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
Merge request created with the patch in #90.
- @liam-morland opened merge request.
- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
liam morland โ made their first commit to this issueโs fork.
- ๐ฉ๐ชGermany geek-merlin Freiburg, Germany
Bot has some cs nits:
FILE: ...pal11/core/tests/Drupal/KernelTests/Core/Field/FieldMappingStorageTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------
19 | ERROR | Missing member variable doc comment
29 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
--------------------------------------------------------------------------------