hook_entity_base_field_info_alter() (and similarly, hook_entity_bundle_field_info_alter()) is documented as receiving an array of FieldDefinitionInterface (FDI) objects as the first parameter.BaseFieldDefinition, and invoke those setters, as the example does, then that will break whenever the module that defines the field changes that implementation decision.Needs work
11.0 🔥
Changes an existing API or subsystem. Not backportable to earlier major versions, unless absolutely required to fix a critical bug.
The issue is available for high level reviews only. If there is a patch or MR it is not to be set to 'Needs work' for coding standards, minor or nit-pick changes.
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
I converted the patch to a merge request and rerolled against 11.x
Note that from @daffie in #40, a test still needs to be added for BaseFieldDefinition::createFromFieldDefinition (the wrong function was referenced in the comment above)