Perform all c_t $form alterations in CTH::entityFormAlter()

Created on 28 October 2014, over 10 years ago
Updated 16 April 2025, 6 days ago

ContentTranslationHandler::entityFormAlter() is called from content_translation_form_alter(), that does this :

$controller = content_translation_controller($entity->getEntityTypeId());
$controller->entityFormAlter($form, $form_state, $entity);

// @todo Move the following lines to the code generating the property form
//   elements once we have an official #multilingual FAPI key.
[10 lines that perform additional $form altering]

- That @todo is dangling without any issue ?

- Meanwhile, why isn't this moved into CTH::entityFormAlter() as well ?
That's confusing, you'd expect CTH::entityFormAlter() to do all the required $form massaging.
Plus, that extra code adds a couple #multilingual properties, and CTH::entityFormAlter() also does something like that (on different elements ?)

πŸ“Œ Task
Status

Postponed: needs info

Version

11.0 πŸ”₯

Component

content_translation.module

Created by

πŸ‡«πŸ‡·France yched

Live updates comments and jobs are added and updated live.
  • D8MI

    (Drupal 8 Multilingual Initiative) is the tag used by the multilingual initiative to mark core issues (and some contributed module issues). For versions other than Drupal 8, use the i18n (Internationalization) tag on issues which involve or affect multilingual / multinational support. That is preferred over Translation.

  • stale-issue-cleanup

    To track issues in the developing policy for closing stale issues, [Policy, no patch] closing older issues

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Thank you for creating this issue to improve Drupal.

    We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

    Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

    Thanks!

Production build 0.71.5 2024