Hi, at the patch #41 the part:
+++ b/core/modules/views/tests/src/Kernel/Entity/EntityViewsDataTest.php @@ -513,6 +513,10 @@ public function testDataTableFields() { 'value' => 0, 'numeric' => TRUE, ],
doesnโt match my version:
public function testDataTableFields() { $entity_test_type = new ConfigEntityType([ 'class' => ConfigEntityBase::class, 'id' => 'entity_test_bundle', 'entity_keys' => [ 'id' => 'type', 'label' => 'name', ], ]);
Including all the following changes.
Iโm running Drupal 10.1.0. Does the version 10.1.1 make that difference?regards
- ๐ณ๐ฑNetherlands bbrala Netherlands
Well at least everything is green. So thats good. But it some weirdness with the event subscriber. Not sure how that should work. I didn't investigate the redirects and such. Mostly just refactored the current recent patch to work with an event subscriber.
- ๐ณ๐ฑNetherlands bbrala Netherlands
I played around with this and moved the implementation to a eventsubscriber as asked for by @znerol. I see one things that is very weird though as per comment in the code:
/** * Either Drupal\Tests\page_cache\Functional\PageCacheVaryTest::testPageCacheWithVary * fails or Drupal\Tests\language\Functional\LanguageBrowserDetectionAcceptLanguageTest::testAcceptLanguageEmptyDefault * fails if you remove one of those. Not sure why */ $events[KernelEvents::RESPONSE][] = ['onRespond', -100]; $events[KernelEvents::RESPONSE][] = ['onRespond', 100]; return $events;
Not sure why, those priorities sometimes confuse me a little.
- @bbrala opened merge request.
- ๐ณ๐ฑNetherlands bbrala Netherlands
bbrala โ changed the visibility of the branch 2430335-browser-language-detection to active.
- ๐บ๐ธUnited States smustgrave
Thanks @sleitner for updating the CR
@ronttizz your issue sounds like a block issue. Would recommend searching the issue queue to see if there is a similar ticket and leave a comment. Sometimes a simple comment of "saw this today on 10.3 while testing xyz" could bring people back to it. Joy of open source! haha
Feedback on the MR here appears to be address