- 🇧🇬Bulgaria a.sotirov
Tested #53 with
php 8.1and Drupal Core9.5.4. Works perfectly both with single or multiple selections for delete.
RTBTC +1 - 🇯🇵Japan ptmkenny
I re-rolled #57 and created an MR for work going forward. The patch is the current state of the MR.
- 🇨🇿Czech Republic Bohus Ulrych Pilsen (Czechia)
FYI Patch #57 works with the latest Drupal 10.1.6
But #59 can't be applied, maybe works only with the latest core dev?
Drush error: Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2023-12-02/2503893-59-fix-string-reg... → - 🇯🇵Japan ptmkenny
Patch #59 is for the 11.x-dev branch, because that's the current commit target. It should also work with Drupal 10.2.x, which will be out in a few days.
- last update
10 months ago 25,880 pass, 1,781 fail - last update
10 months ago Build Successful - First commit to issue fork.
- Status changed to Needs review
7 months ago 1:31pm 5 May 2024 - 🇨🇦Canada SKAUGHT
Drupal Usability Meeting 📌 Drupal Usability Meeting 2024-05-10 Active reviewed 🐛 Regression: not possible to delete source strings in Drupal (>7) interface translation Needs review
[placeholder for notes]
- Status changed to Needs work
6 months ago 9:48pm 10 May 2024 - 🇺🇸United States benjifisher Boston area
For the record, the attendees at the usability meeting (Comment #64) were @AaronMcHale, @benjifisher, @rkoller, @shaal, @simohell, @skaught, and @worldlinemine.
We all agreed that the two submit buttons ("Save translations" and "Delete translations") were confusing. Given that, I do not think we should implement a confirmation form.
Deleting a translatable string is temporary. As soon as someone visits a page where the string is used, the string is re-added to the list of strings available for translation. This whole approach seems confusing from a usability perspective.
Opinions at the usability meeting were divided. Some of us were in favor of each of these proposals:
- Close this issue as "won't fix".
- Add a checkbox as in the current MR, but not a second submit button. When the form is submitted, the checkbox has the same effect as deleting the text in the "Translation for ..." column.
- Add help text to clarify that deleting the translation means the source string will be used.