Account created on 14 February 2011, over 14 years ago
#

Merge Requests

More

Recent comments

🇪🇸Spain facine

Fixed! Thanks everyone.

The issue was that Remove Commerce Product dependency from Commerce Cart and Commerce Checkout Needs review was finally merged into Commerce, and now Commerce Product is no longer required by the cart. The recipe has been updated to remove the dependency on Commerce Product and a basic verification test has been added.

🇪🇸Spain facine

facine created an issue.

🇪🇸Spain facine

facine made their first commit to this issue’s fork.

🇪🇸Spain facine

facine created an issue.

🇪🇸Spain facine

facine created an issue.

🇪🇸Spain facine

facine created an issue.

🇪🇸Spain facine

Thank you! Merged.

🇪🇸Spain facine

I've created a MR porting the these changes, but we still need tests.

🇪🇸Spain facine

facine made their first commit to this issue’s fork.

🇪🇸Spain facine

facine created an issue.

🇪🇸Spain facine

facine created an issue.

🇪🇸Spain facine

facine created an issue.

🇪🇸Spain facine

facine created an issue.

🇪🇸Spain facine

facine changed the visibility of the branch 3550620-make-compatible-with to active.

🇪🇸Spain facine

facine changed the visibility of the branch 3550620-make-compatible-with to hidden.

🇪🇸Spain facine

facine changed the visibility of the branch 3550620-make-compatible-with to hidden.

🇪🇸Spain facine

facine created an issue.

🇪🇸Spain facine

facine created an issue.

🇪🇸Spain facine

facine created an issue.

🇪🇸Spain facine

facine created an issue.

🇪🇸Spain facine

facine created an issue.

🇪🇸Spain facine

facine created an issue.

🇪🇸Spain facine

facine changed the visibility of the branch 3548737-add-gitlab-ci to hidden.

🇪🇸Spain facine

facine created an issue.

🇪🇸Spain facine

Merged! It looks great, thanks @divyanshgupta

🇪🇸Spain facine

The logic is fine, what is wrong is the comment. If the commerce_payment module does not exist we cannot process payments.
The wrong comment is in the checkout pane.

The fix should be:
- Update the comment in: \Drupal\commerce_webform_order\Plugin\Commerce\CheckoutPane\PaymentProcess
- Make sure that only one of the two checkout panes is active in the checkout flow.

Thanks for reporting the issue.

🇪🇸Spain facine

Thank you very much for reporting this issue. I’ve just pushed some changes that should fix the problem.

Could you please give them a try?

Thanks!

🇪🇸Spain facine

facine changed the visibility of the branch 3525534-can-not-to to hidden.

🇪🇸Spain facine

As we are move the demo submodule to a recipe: https://www.drupal.org/project/cwo_demo , I think we can close this issues.

Thanks!

🇪🇸Spain facine

facine changed the visibility of the branch 3524262-add-support-for to hidden.

🇪🇸Spain facine

This change was implemented here [3270231], 3.x branch.

For now you can add hidden o value fields with your actual tokens. They should work before the submission is saved.

🇪🇸Spain facine

Closing this issue as it is a duplicate. There is already a feature request addressing this point, which you can find here: [3484948]. Thanks for your understanding!

🇪🇸Spain facine

Thank you for reporting this bug and for your work in fixing it! The fix has now been merged 🚀

🇪🇸Spain facine

facine made their first commit to this issue’s fork.

Production build 0.71.5 2024