Allow to configure the timeout

Created on 27 January 2023, almost 2 years ago
Updated 29 May 2023, over 1 year ago

Configure the timeout with the UI

Feature request
Status

Needs work

Version

1.0

Component

Code

Created by

🇪🇸Spain jmaties

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @jmaties
  • Status changed to Needs work almost 2 years ago
  • 🇪🇸Spain facine

    Hello @jmaties, thanks for your work, please could you review the following changes I propose?

    1. +++ b/go_wkhtmltox.links.menu.yml	2023-01-27 13:47:16
      @@ -0,0 +1,5 @@
      +  title: go_wkhtmltox settings
      

      Use module name instead of the machine name.

    2. +++ b/go_wkhtmltox.links.menu.yml	2023-01-27 13:47:16
      @@ -0,0 +1,5 @@
      +  description: Configure go_wkhtmltox module.
      

      Use module name instead of the machine name.

    3. +++ b/go_wkhtmltox.routing.yml	2023-01-26 18:27:17
      @@ -0,0 +1,7 @@
      +  path: /admin/config/system/go_wkhtmltox
      

      We should use "go-wkhtmltox" not "go_wkhtmltox" and move it under "services": /admin/config/services, update also the route definition.

    4. +++ b/src/API/Resource/ConvertResource.php	2023-01-27 13:45:01
      @@ -50,6 +56,7 @@
      +    $this->configFactory = \Drupal::config('go_wkhtmltox.settings');
      

      We need to inject this service.

    5. +++ b/src/API/Resource/ConvertResource.php	2023-01-27 13:45:01
      @@ -93,8 +100,7 @@
      +      'timeout' => $this->configFactory->get('timeout'),
      

      Use 15 as default value.

    6. +++ b/src/Form/SettingsForm.php	2023-01-26 18:35:07
      @@ -0,0 +1,61 @@
      +      'go_wkhtmltox.settings',
      

      We need to add the module schema.

    7. +++ b/src/Form/SettingsForm.php	2023-01-26 18:35:07
      @@ -0,0 +1,61 @@
      +    $form['timeout'] = [
      

      There are other settings:

      - endpoint
      - path

Production build 0.71.5 2024