MappedObject does opposite of what it says it does

// If $value is TypedData, it should have been set during pullValue(). if (!$value instanceof TypedDataInterface) { $drupal_field = $field->get('drupal_field_value'); $drupal_entity->set($drupal_field, $value); }

Comments & Activities

Issue created by @keopx
Merge request !77Issue #3443380: Remove opposite TypedData verification → (Open) created by keopx
Comment 8 months ago →
🇪🇸Spain keopx Basque Country
keopx → changed the visibility of the branch 5.0.x to hidden.
Pipeline finished with Failed
8 months ago
Total: 176s
#156115
Status changed to Needs review 8 months ago7:33am 25 April 2024
Comment 8 months ago →
🇪🇸Spain keopx Basque Country
I removed the negative validation
Status changed to Needs work 8 months ago1:30pm 25 April 2024
Comment 8 months ago →
🇺🇸United States AaronBauman Philadelphia
The comment is perhaps unclear.
A clearer comment might be:

// If $value is TypedData, it should have been set during pullValue(), so we don't need to set it again here.

MappedObject does opposite of what it says it does

Problem/Motivation

Proposed resolution

Merge Requests

!77MappedObject does opposite of what it says it does
Open

Comments & Activities

MappedObject does opposite of what it says it does

Problem/Motivation

Proposed resolution

Merge Requests

!77MappedObject does opposite of what it says it doesOpen

Comments & Activities

!77MappedObject does opposite of what it says it does
Open