- Issue created by @safallia joseph
- Merge request !283465501: Update profile view as per change record in 3441945 → (Merged) created by safallia joseph
- Status changed to Needs review
8 months ago 4:02pm 2 August 2024 - 🇮🇱Israel jsacksick
The problem is that makes the Profile module compatible with Drupal > D10.3... So not sure what to do... Should we live with the deprecation, or introduce a new major branch.
- Status changed to RTBC
2 months ago 9:08pm 29 January 2025 - 🇺🇸United States dww
I added this deprecation to core. Turns out that due to extreme weirdness with Views, it doesn't actually matter what plugin ID you use in your views.yml files until 🐛 Views handler loading should respect configuration Active is released (11.2.0 at the earliest). 🙃 So it's actually safe to change this now. In D9 and <10.2, the plugin won't exist, but it'll be ignored. In >=10.3.0, the new plugin will exist, and be used, regardless of what your views config says. In >=11.2.0 the Views config will actually start to matter. 😅 See #3451750-18: Fix: The update to convert "numeric" arguments to "entity_target_id" is deprecated → as an example.
I just updated the CR to add a Note on Backwards compatibility → section to explain this weirdness, and the recommended approach (which is to update immediately, even for modules that are compatible with pre-10.3.x core):
https://www.drupal.org/node/3441945/revisions/view/13586313/13871846 →Therefore, the changes in the MR are proper, we don't have to touch
core_version_requirements
, and everything should work fine on older versions of core. Arguably the summary here could be fleshed out, but I'm going to go ahead and RTBC this.Thanks!
-Derek -
jsacksick →
committed 82d3abcc on 8.x-1.x authored by
safallia joseph →
Issue #3465501 by safallia joseph, jsacksick, dww: Fix Deprecation...
-
jsacksick →
committed 82d3abcc on 8.x-1.x authored by
safallia joseph →
- 🇮🇱Israel jsacksick
We might need to reopen this as we have phpunit failures on the next minor version:
├ Exception: Warning: Undefined array key "target_entity_type_id"
├ Drupal\views\Plugin\views\argument\EntityReferenceArgument->titleQuery()() (Line: 57)Don't really have time to investigate this atm, but it looks related so reopening this.
- 🇺🇸United States dww
Oh yeah, apologies about that. I forgot we ran into that at 📌 Fix: The update to convert "numeric" arguments to "entity_target_id" is deprecated Needs review , too. The only problem is the
$strictConfigSchema
being set toTRUE
in this case. Everything still works, but the strict config schema checks will not in 10.2.x and earlier.We can either disable those checks entirely, or conditionally for older test runs. See https://git.drupalcode.org/project/scheduler/-/merge_requests/159/diffs for one approach.
p.s. The failure is for "Previous minor", not next, which makes sense.