- ๐บ๐ธUnited States hargobind Austin, Texas
Readding the D7 patch that was hidden by @Lekstat
@Lekstat why did you hide your own patch in #79?
- Status changed to Needs work
over 1 year ago 4:23pm 2 March 2023 - ๐บ๐ธUnited States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request โ as a guide.
The issue summary could be updated to show what the proposed solution is? Remaing tasks, etc.
Also will need test coverage to ensure it doesn't break.
- Status changed to Needs review
over 1 year ago 2:03pm 24 March 2023 - ๐ซ๐ฎFinland jheinon_finland
I had some issues in #74 on the project for which I'm working on. The code section where all the available string translation contexts are fetched in the function
translateFilters()
didn't apply.This is an updated version of the patch where the said code segment is placed between the
filters
array and language fetching sans English. - Status changed to Needs work
over 1 year ago 2:46pm 24 March 2023 - ๐ฑ๐ปLatvia Phonoman
#83 seems to have some linting errors, please adjust those so that the tests can pass :)
FILE: /var/www/html/core/modules/locale/src/StringContextInterface.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
9 | ERROR | [x] Opening brace should be on the same line as the
| | declaration
16 | ERROR | [x] Expected 1 blank line before function; 0 found - Status changed to Needs review
over 1 year ago 3:27pm 24 March 2023 - ๐ซ๐ฎFinland jheinon_finland
All right, as stated in #84, these should be fixed with the version provided in this comment, #85.
- ๐ณ๐ฑNetherlands Martijn de Wit ๐ณ๐ฑ The Netherlands
@jheinon_finland Drupal core issues are fixed in development versions. So please don't move versions down.
Current development versions is 10.1.x. Maybe the patch can be applied to previous versions and back-ported if needed but that's up to the core maintainers. - Status changed to Needs work
over 1 year ago 9:52pm 25 March 2023 - ๐บ๐ธUnited States smustgrave
Issue summary still needs updating.
Tests are still needed.
And yes interdiffs need to be uploaded for #83 and #85
- Status changed to Needs review
about 1 year ago 12:42pm 27 March 2023 - ๐ซ๐ฎFinland jheinon_finland
In this, I will upload the interdiff between versions
#83
and#85
. To answer#86
, it appears it's not possible to edit an old comment and provide a file with it, so I will be uploading the interdiff file in this comment. - Status changed to Needs work
about 1 year ago 3:02pm 4 April 2023 - Open on Drupal.org โEnvironment: PHP 8.2 & MySQL 8last update
about 1 year ago Not currently mergeable. - @parisek opened merge request.
- First commit to issue fork.
- Open on Drupal.org โEnvironment: PHP 8.2 & MySQL 8last update
about 1 year ago Not currently mergeable. - @parisek opened merge request.
- last update
about 1 year ago 29,448 pass - Open on Drupal.org โEnvironment: PHP 8.2 & MySQL 8last update
about 1 year ago Not currently mergeable. - @parisek opened merge request.
- First commit to issue fork.
- last update
9 months ago 30,360 pass - last update
5 months ago Patch Failed to Apply