The solution I found is to consider also the base path when doing the str_replace. This solved the issue for my case.
lisotton → created an issue.
Hi @damienmckenna,
Do you have any estimation for the rollout of this version? If it does not have all the features you have planned for this version, maybe you could release a beta or rc version, so we can upgrade and unblock the upgrade to Drupal 11 of the websites using this module.
Thank you for you good work on this module.
In my project, we had a Drupal 10.3 installation pointing to the patch of the MR, but with the rebase of the MR, the MR is not applicable anymore in Drupal 10.3.
So for those looking for a patch that work with Drupal 10.3, I'm attaching one to the issue.
lisotton → created an issue.
Making #153 compatible with Drupal 10.3.
I have opened the MR.
lisotton → changed the visibility of the branch 2.x to hidden.
lisotton → changed the visibility of the branch 2.0.x to hidden.
I applied the #22 and it worked fine with Hook Event Dispatcher.
Moving it to RTBC.
lisotton → created an issue.
I still don't understand why cannot have a version that is both compatible with Drupal 9 and 10 like most of other modules.
If we would have this, we could upgrade this module first (like I'm doing with other contrib modules) and then in a latest stage, upgrade Drupal 10 (as all contrib modules are already compatible).
I created a PR removing the file video_transcode.install.
The function video_transcode_schema had the whole content commented and the function video_transcode_install is empty. So I don't think is necessary to keep this file.
lisotton → created an issue.
I also tested MR 17 and it is working fine.
@_renify with your patch, you are fixing things that is not related to this issue and is fixed in #3348748 🐛 Missing Entity Query Access Check - D10 Compatibility Error Fixed .
There was one more place reported by Upgrade Status where the `accessCheck` was not called.
lisotton → made their first commit to this issue’s fork.
Hi @jibran,
The ideal scenario would be to have a version that is both compatible with latest version of Drupal 9 and also compatible with Drupal 10.
I'm working in an upgrade of a big site to Drupal 10 and the approach that we are following (and I believe most of the developers that are working in big projects are doing the same) is to upgrade all contrib modules to a version that is compatible with both versions and then when everything is compatible we will upgrade only the Drupal core. Otherwise we will have a huge release with dozens of modules upgraded.
Is there a lot of changes to make one of the versions also compatible with Drupal 9.5?
Hi @jcontreras, I see that the new version (2.1.0) will be only compatible with Drupal 10 and the version 2.0.2, you marked as not compatible with Drupal 10. Actually you made a commit before releasing the version removing the compatibility at commit 5e8ebf5e.
I'm working in a big site, migrating it to Drupal 10 and I would like to make all contrib modules compatible with Drupal 10, before upgrading the core itself.
Do you have any plan to release 2.0.3 with compatibility with both Drupal 9 and Drupal 10?
I had similar issues in many places where I manipulate retrieve the menu tree.
I have some routes that share the same Controller and Action, but in the route declaration it declares default parameters. For example I have the route mymodule.news_list (/news) which have the controller ListPageController::entryPoint with a default parameter called type with value news-list. Then I have another route called mymodule.articles_list (/articles) which shares the same controller, but the default parameter type with value articles-list.
Before when I was calling \Drupal::service('plugin.manager.menu.link')->loadLinksByRoute('news_list'), without any second second parameter (route params), it was returning me the menu links, but with the change in 9.5.9, I'm enforced to call \Drupal::service('plugin.manager.menu.link')->loadLinksByRoute('news_list', ['type' => 'news-list').
For me this broke many small things, like breadcrumbs, custom menu blocks, etc.
I created a MR applying what was suggested by @jensschuppe.
The problem I see is that using the function "is_scalar", it will not enter even when the value is null and before if the value was null, it was using an empty string.
What do you think is the best option?
- Not set the value if is null or array
- Leave the value as empty string if is null and not set the value if is array
- Set the value as empty string if both null or array
lisotton → made their first commit to this issue’s fork.