- last update
9 months ago 26 pass, 1 fail - 🇧🇾Belarus e.bogatyrev
Hi everyone,
Please review the patch.
I suggest to use callback arguments as a string with line ending separation in the Cron Job configuration form since we don't actually know the final amount of them. It depends on the particular implementation of each callback. Then this string will be parsed, split to arguments and passed to callback. - Merge request !40Issue #2909191: Added ability to pass arguments to cron job callback. → (Open) created by e.bogatyrev
- last update
9 months ago 26 pass, 1 fail The last submitted patch, 5: ultimate_cron-callback-arguments-2909191-5.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- last update
9 months ago 26 pass, 1 fail - last update
9 months ago 26 pass, 1 fail - last update
9 months ago 35 pass - last update
9 months ago 35 pass - Status changed to Needs review
9 months ago 1:19pm 27 February 2024 - 🇧🇬Bulgaria nikolabintev
I just set it up on a project and it works well. I believe that this is e must-have feature.
- Status changed to RTBC
9 months ago 3:13pm 15 March 2024 - Status changed to Needs work
4 months ago 8:41pm 15 August 2024 - 🇨🇭Switzerland berdir Switzerland
This has a few conflicts. I have some concerns about the argument structure, XSS filtering doesn't seem relevant here as it's not displayed.
The schema talks about comma separated values, but according to tests and code, it's really line breaks.
What about storing arguments as a sequence, then only the form needs to process them into an array and runtime can just pass it through directly as an array?
- Status changed to Needs review
about 2 months ago 4:50pm 17 October 2024 - 🇧🇾Belarus e.bogatyrev
Hi @berdir,
Thanks for findings, they make sense.
Please take a look and review updated patch or MR - 🇨🇭Switzerland berdir Switzerland
> What about storing arguments as a sequence, then only the form needs to process them into an array and runtime can just pass it through directly as an array?
This hasn't been addressed yet.
To be honest, I'm not sure this should even be exposed in the UI. We don't allow to set/change the callback, also for security reasons, so this should just display the arguments as well.