πŸ‡§πŸ‡¬Bulgaria @nikolabintev

Account created on 7 March 2016, about 9 years ago
#

Recent comments

πŸ‡§πŸ‡¬Bulgaria nikolabintev

The patch is updated, so the logger factory service is used for error logging and the D11 version is added to the info.yml file.

πŸ‡§πŸ‡¬Bulgaria nikolabintev

Yes, this is what's need to be done. We need a new major version that supports Drupal 10.3 and 11

πŸ‡§πŸ‡¬Bulgaria nikolabintev

Please find the uploaded patches that solved the issue.

πŸ‡§πŸ‡¬Bulgaria nikolabintev

Hi @thejimbirch,

Thank you for the extensive feedback! It is much appreciated. I will adjust my recipe based on your recommendation. What I was missing is the advanced SEO schema, however, I have some comments on it. Is it a good idea to have the following modules included:

  • dashboard
  • field_group
  • focal_point
  • layout_builder
  • shortcut
  • tour

I'd categorize them editorial-related rather than SEO-related. Shouldn't they be moved in a separate recipe?

πŸ‡§πŸ‡¬Bulgaria nikolabintev

It feels like it is not reproducible anymore. Could you please confirm that this can be closed as outdated?

πŸ‡§πŸ‡¬Bulgaria nikolabintev

Thank you guys for the patch and for the testing. It is merged into the 2.x-dev branch.

πŸ‡§πŸ‡¬Bulgaria nikolabintev

nikolabintev β†’ made their first commit to this issue’s fork.

πŸ‡§πŸ‡¬Bulgaria nikolabintev

Hi Team,

Thank you for that initiative!

We've been working on a SEO recipe as part of a company project. We created one with the idea that it will be reused in other websites, so what we've built is content type-agnostic set up.

Please find the implementation here

Here's the list of features that it provides:

  • Metatags: basic and advanvced
  • Schema.org
  • URL alisases
  • Redirects
  • Robots.txt
  • XML Sitemaps

The idea is that the SEO recipe will be applied prior to having any data model definition, so all of the above features come with a pre-defined configurations that are content type-agnostic.

If you think that might be useful for the Drupal CMS initiative, I am happy to move those features in the core SEO recipe

πŸ‡§πŸ‡¬Bulgaria nikolabintev

I just set it up on a project and it works well. I believe that this is e must-have feature.

πŸ‡§πŸ‡¬Bulgaria nikolabintev

I've managed to reproduce the issue and I can confirm that copying the idMap property to the rows solves the problem

πŸ‡§πŸ‡¬Bulgaria nikolabintev

I am uploading a patch that can be applied to the latest stable Drupal 10 version: 10.2.4

πŸ‡§πŸ‡¬Bulgaria nikolabintev

I just created a configuration entity by following the article. I experienced no issues, so I think we can change the status to "No known problems" 

πŸ‡§πŸ‡¬Bulgaria nikolabintev

The reported bugs are fixed as well as the coding standards so I released a stable version of the module: 2.0.0 β†’

πŸ‡§πŸ‡¬Bulgaria nikolabintev

This one is duplicate of https://www.drupal.org/project/default_paragraphs/issues/3203024 πŸ“Œ Fix the errors/warnings reported by PHP_CodeSniffer RTBC . I am closing it.

πŸ‡§πŸ‡¬Bulgaria nikolabintev

Hi @broon,

We've fixed a couple of issues in the recent months. It is not abandoned. A stable version will be released soon

πŸ‡§πŸ‡¬Bulgaria nikolabintev

Hi @dalin,

There's one more issue that we'd like to fix first and then we will release a stable version. You can still apply the patch by using the drupal lenient package. Check this β†’

πŸ‡§πŸ‡¬Bulgaria nikolabintev

@Nikolay Penchev, The MR should be against the 2.x branch, not 8.x-2.x. Could you please change it? I'll update the branches these days.

πŸ‡§πŸ‡¬Bulgaria nikolabintev

I tested the issue fork locally. It seems like all issues are fixed.

πŸ‡§πŸ‡¬Bulgaria nikolabintev

Thank you, everyone, for the effort! I am closing the issue.

πŸ‡§πŸ‡¬Bulgaria nikolabintev

Hi all! Thank you for your effort. We are going to review the suggested changes and prepare a stable release shortly.

πŸ‡§πŸ‡¬Bulgaria nikolabintev

After further investigation, I realized that we don't need CRUD permission to handle this. I checked the implementation of the Vocabulary entity and they handle it by using the "access taxonomy overview" so I introduced the "view external link popup" permission that can be assigned to the anonymous user role. Another way to solve it is to implement entity_access or ENTITY_TYPE_access hooks.

Please find the attached patch and let me know your opinion.

Production build 0.71.5 2024