ID map not copied when cloning row without destination

Created on 23 January 2024, about 1 year ago

Updated 23 March 2024, 12 months ago

Problem/Motivation

When calling \Drupal\migrate\Row::cloneWithoutDestination() the cloned row also doesn't have the ID map.

This causes issues when doing e.g. an update of a content entity migration with the overwrite_properties destination setting. \Drupal\migrate\Plugin\migrate\destination\EntityContentBase::updateEntity() will clone the row and later override the previously defined rollback option because the $id_map is empty in \Drupal\migrate\Plugin\migrate\destination\DestinationBase::setRollbackAction()

Steps to reproduce

Create a content entity migration and specify the overwrite_properties destination setting
Import
Check the rollback action in the DB, make sure it's not 1 (preserve)
Import again with the --update option
Check the rollback action in the DB, it's changed to 1 (preserve)

Proposed resolution

Copy the idMap property in the \Drupal\migrate\Row::cloneWithoutDestination() method

🐛 Bug report

Status

Needs work

Version

11.0 🔥

Component

Migration →

Last updated 35 minutes ago

Maintained by
🇺🇸United States @benjifisher
@heddn
🇺🇸United States @mikelutz
🇳🇿New Zealand @quietone

Created by

🇧🇪Belgium matthijs

Live updates comments and jobs are added and updated live.

Merge Requests

!6292ID map not copied when cloning row without destination
Open
🇧🇪Belgium matthijs
updated about 1 year ago

Comments & Activities

Issue created by @matthijs
Merge request !6292Issue #3416543: Fix missing idMap on cloned row → (Open) created by matthijs
Comment about 1 year ago →
🇧🇪Belgium matthijs
Comment 12 months ago →
🇧🇬Bulgaria nikolabintev
I've managed to reproduce the issue and I can confirm that copying the idMap property to the rows solves the problem
Status changed to RTBC 12 months ago11:44am 15 March 2024
Comment 12 months ago →
🇧🇬Bulgaria nikolabintev
Status changed to Needs work 12 months ago11:54pm 23 March 2024
Comment 12 months ago →
🇬🇧United Kingdom alexpott 🇪🇺🌍
Can we extend \Drupal\Tests\migrate_drupal\Kernel\d6\EntityContentBaseTest::testOverwriteProperties to test this case as this a complex part of the codebase and this is not obvious. I think the change is correct but it would be great to automated test evidence.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024